From patchwork Mon Feb 15 16:00:58 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Rzeszutek Wilk X-Patchwork-Id: 8316311 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 7AAC59F72C for ; Mon, 15 Feb 2016 16:04:02 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8C6F8202F0 for ; Mon, 15 Feb 2016 16:04:01 +0000 (UTC) Received: from lists.xen.org (lists.xenproject.org [50.57.142.19]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9E66120398 for ; Mon, 15 Feb 2016 16:04:00 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aVLaD-0000Q5-9p; Mon, 15 Feb 2016 16:01:05 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aVLaC-0000Pv-55 for xen-devel@lists.xensource.com; Mon, 15 Feb 2016 16:01:04 +0000 Received: from [85.158.137.68] by server-6.bemta-3.messagelabs.com id 20/B0-08479-F36F1C65; Mon, 15 Feb 2016 16:01:03 +0000 X-Env-Sender: konrad@char.us.oracle.com X-Msg-Ref: server-12.tower-31.messagelabs.com!1455552061!22474666!1 X-Originating-IP: [156.151.31.81] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogMTU2LjE1MS4zMS44MSA9PiAyODgzMzk=\n X-StarScan-Received: X-StarScan-Version: 7.35.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 40544 invoked from network); 15 Feb 2016 16:01:02 -0000 Received: from userp1040.oracle.com (HELO userp1040.oracle.com) (156.151.31.81) by server-12.tower-31.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 15 Feb 2016 16:01:02 -0000 Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u1FG0xXR020416 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 15 Feb 2016 16:01:00 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u1FG0xBE026601 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL) for ; Mon, 15 Feb 2016 16:00:59 GMT Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u1FG0xjp002505 for ; Mon, 15 Feb 2016 16:00:59 GMT Received: from char.us.oracle.com (/10.137.176.158) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 15 Feb 2016 08:00:59 -0800 Received: by char.us.oracle.com (Postfix, from userid 1000) id 199866A3C8D; Mon, 15 Feb 2016 11:00:58 -0500 (EST) Date: Mon, 15 Feb 2016 11:00:58 -0500 From: Konrad Rzeszutek Wilk To: xen-devel@lists.xensource.com Message-ID: <20160215160057.GA4308@char.us.oracle.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Subject: [Xen-devel] git workflow and http://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hey, I wanted to ask what folks would think of expanding the Wiki to include (making it a diff for simpler) this change. With my giant 30 set of patches that not only CC-ed xen-devel twice but had some patches CC some maintainers but not others - I figured it may be good to describe this in the Wiki: --- orig 2016-02-15 10:45:27.719204371 -0500 +++ new 2016-02-15 10:58:33.113755665 -0500 @@ -140,7 +140,35 @@ * The maintainers are listed in the MAINTAINERS file at the top of the Xen source tree. If no maintainer is listed then there is no need for a CC (if you are modifying code with no maintainer then you might like to consider becoming the maintainer for that piece of code!). ** You can pipe your patch to the ./scripts/get_maintainer.pl tool and it will list the relevant maintainers. * In addition to CCing the maintainer you should always send patches to (via TO) the xen-devel@lists.xenproject.org mailing list as well. -* To add a CC when sending the mail you can use the ''--cc'' option to the ''git send-email'' command, or you can do it manually in your MUA. +* To add a CC when sending the mail you can: + * use the ''--cc'' option to the ''git send-email'' command - however if your + patchset is to multiple maintainers - you may end up sending all of the + patches to all maintainers - where some of them have no interest in + viewing them (as they are not under their responsibility). + * edit each patch to have the proper maintainer on the CC list by adding: +
+CC: joe@doe.com
+
+ in the patch. + * or alternatively use --cc-cmd in your .gitconfig: +
+[sendemail]
+    cc-cmd = scripts/get_maintainer.pl --remove-duplicates --no-l
+
+which will automatically add the proper maintainer on the CC line. +The ''no-l'' is to not add the mailing list to the CC (as you would +be adding that via the TO - see above) + * or you can do it manually in your MUA. + +In short, it could look like this: +
+$pwd
+/home/joedoe/xen
+git send-email --to xen-devel@lists.xenproject.org --to jo@doe.com --compose --subject "[PATCH v1] Fixes to frobnicator." *.patch
+
+ +Which will send all patches to yourself on the TO, to xen-devel mailiing list (on the TO:) +and the patches will have their CC: list generated based on scripts/get_maintainer.pl. === Providing a git branch ===