From patchwork Tue Feb 23 19:04:01 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Rzeszutek Wilk X-Patchwork-Id: 8395611 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id E6DF89F372 for ; Tue, 23 Feb 2016 19:07:25 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0AF22202FF for ; Tue, 23 Feb 2016 19:07:25 +0000 (UTC) Received: from lists.xen.org (lists.xenproject.org [50.57.142.19]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95ACA202F0 for ; Tue, 23 Feb 2016 19:07:23 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aYIG1-0004wt-5k; Tue, 23 Feb 2016 19:04:25 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aYIFz-0004wo-Vf for xen-devel@lists.xenproject.org; Tue, 23 Feb 2016 19:04:24 +0000 Received: from [193.109.254.147] by server-11.bemta-14.messagelabs.com id 96/F0-28228-73DACC65; Tue, 23 Feb 2016 19:04:23 +0000 X-Env-Sender: konrad@char.us.oracle.com X-Msg-Ref: server-3.tower-27.messagelabs.com!1456254260!25822052!1 X-Originating-IP: [156.151.31.81] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogMTU2LjE1MS4zMS44MSA9PiAyODgzMzk=\n X-StarScan-Received: X-StarScan-Version: 7.35.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 57105 invoked from network); 23 Feb 2016 19:04:22 -0000 Received: from userp1040.oracle.com (HELO userp1040.oracle.com) (156.151.31.81) by server-3.tower-27.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 23 Feb 2016 19:04:22 -0000 Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u1NJ49mY003222 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 23 Feb 2016 19:04:10 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u1NJ49he029856 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Tue, 23 Feb 2016 19:04:09 GMT Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by aserv0122.oracle.com (8.13.8/8.13.8) with ESMTP id u1NJ47Xx028715; Tue, 23 Feb 2016 19:04:07 GMT Received: from char.us.oracle.com (/10.137.176.158) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 23 Feb 2016 11:04:02 -0800 Received: by char.us.oracle.com (Postfix, from userid 1000) id 7A93C6A3C8D; Tue, 23 Feb 2016 14:04:01 -0500 (EST) Date: Tue, 23 Feb 2016 14:04:01 -0500 From: Konrad Rzeszutek Wilk To: Jan Beulich Message-ID: <20160223190401.GA15838@char.us.oracle.com> References: <1455877209.6225.75.camel@citrix.com> <1455892362-1560-1-git-send-email-konrad.wilk@oracle.com> <56CB0E0502000078000D4B49@prv-mh.provo.novell.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <56CB0E0502000078000D4B49@prv-mh.provo.novell.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Source-IP: userv0021.oracle.com [156.151.31.71] Cc: Keir Fraser , Ian Campbell , rcojocaru@bitdefender.com, Tim Deegan , Ian Jackson , xen-devel@lists.xenproject.org Subject: Re: [Xen-devel] [PATCH] version: Document guest_handle X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, Feb 22, 2016 at 05:32:53AM -0700, Jan Beulich wrote: > >>> On 19.02.16 at 15:32, wrote: > > --- a/xen/include/public/version.h > > +++ b/xen/include/public/version.h > > @@ -79,6 +79,10 @@ typedef struct xen_feature_info xen_feature_info_t; > > #define XENVER_pagesize 7 > > > > /* arg == xen_domain_handle_t. */ > > +/* > > + * The toolstack fills it out for the guest consumption. Usually it is > > + * the UUID of the guest but can be anything. > > + */ > > #define XENVER_guest_handle 8 > > Generally fine, but I'm not overly happy with the wording. I'd > prefer if it was made slightly less vague this is meant to be the > UUID. Maybe "The toolstack fills it out for guest consumption. It > is intended to hold the UUID of the guest"? > > Jan > Attached as well: From 7da6d169835acb4aa93bfa48b1ae6b8e198f8e5f Mon Sep 17 00:00:00 2001 From: Konrad Rzeszutek Wilk Date: Fri, 19 Feb 2016 09:26:02 -0500 Subject: [PATCH] version: Document guest_handle And what it is usually used for. Signed-off-by: Konrad Rzeszutek Wilk Reviewed-by: Razvan Cojocaru Acked-by: Jan Beulich --- v2: Reword per Jan's suggestion. --- xen/include/public/version.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/xen/include/public/version.h b/xen/include/public/version.h index adca602..5e6a7ea 100644 --- a/xen/include/public/version.h +++ b/xen/include/public/version.h @@ -78,7 +78,11 @@ typedef struct xen_feature_info xen_feature_info_t; /* arg == NULL; returns host memory page size. */ #define XENVER_pagesize 7 -/* arg == xen_domain_handle_t. */ +/* arg == xen_domain_handle_t. + * + * The toolstack fills it out for guest consumption. It is intended to hold + * the UUID of the guest. + */ #define XENVER_guest_handle 8 #define XENVER_commandline 9