From patchwork Wed Feb 24 17:19:31 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Dario Faggioli X-Patchwork-Id: 8410111 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id B710CC0553 for ; Wed, 24 Feb 2016 17:22:05 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DE8D520263 for ; Wed, 24 Feb 2016 17:22:04 +0000 (UTC) Received: from lists.xen.org (lists.xenproject.org [50.57.142.19]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E5E3F201C7 for ; Wed, 24 Feb 2016 17:22:03 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aYd6A-0003jQ-CG; Wed, 24 Feb 2016 17:19:38 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aYd68-0003jE-Oi for xen-devel@lists.xenproject.org; Wed, 24 Feb 2016 17:19:36 +0000 Received: from [85.158.139.211] by server-12.bemta-5.messagelabs.com id 9A/BA-02994-726EDC65; Wed, 24 Feb 2016 17:19:35 +0000 X-Env-Sender: raistlin.df@gmail.com X-Msg-Ref: server-6.tower-206.messagelabs.com!1456334375!24455856!1 X-Originating-IP: [74.125.82.52] X-SpamReason: No, hits=0.2 required=7.0 tests=RCVD_ILLEGAL_IP X-StarScan-Received: X-StarScan-Version: 7.35.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 24706 invoked from network); 24 Feb 2016 17:19:35 -0000 Received: from mail-wm0-f52.google.com (HELO mail-wm0-f52.google.com) (74.125.82.52) by server-6.tower-206.messagelabs.com with AES128-GCM-SHA256 encrypted SMTP; 24 Feb 2016 17:19:35 -0000 Received: by mail-wm0-f52.google.com with SMTP id b205so43597977wmb.1 for ; Wed, 24 Feb 2016 09:19:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:from:to:cc:date:message-id:user-agent:mime-version :content-type:content-transfer-encoding; bh=OSimWwiwN1fNhKC97iNzc3wGG+SrtVW7cJJ3nUJtOzA=; b=ADKFOjU63RzwU5ry2o6+5o5sgogva6Tzg4XhnRS2CJo7OKTDEY1n25x7uWOimXSUup 0+WA+NVUjKzUyH8PoKqgdZl+04gjXZTvwqBf7lO6IlMjAH0SfanoHj77gUiQUf4GtVpb 21gHZy+efJmoZ325RVd8XfV9aBqzDEQb6E162DwxVHl0+7pF0au1PeTjJbUOBgu2iq2s uYChyhRIVWh79iWYjGKgvVuMxrDiIc+5B8SpCWF9kuHNWg9fq07bQZ9B6aIVNqONJp6U 3fXPHrxdpY95b1iKlqfFv+O+T5MF/KMpKZYMHNN1bNKNqAR+iTi+4q+o8VAsAIhuO2xo Phxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:from:to:cc:date:message-id :user-agent:mime-version:content-type:content-transfer-encoding; bh=OSimWwiwN1fNhKC97iNzc3wGG+SrtVW7cJJ3nUJtOzA=; b=jJW9/WcYAGC/UqqikDM3Dmsq/mwGI4Rj7bHa/YS3ZJWNddqP1YIlgqjbU6LmgI101G KEcW5DpJLTgyAJbFxPnkgk8XCXqErwE3FgbWwz8Nk0VChPVKFwuAunVmipWz9rwTVjUO 1cLBPBdpyOwqlzZIHnwVIg1iJOOaT7DjZzfhHWOArBnwjKDZlwX64H1zY5nMRhHyNpyG QITyG2o8Zp29uBF6SAFE0R3U7TQwIt50Og6XrdPFKLgUFm11yFonEiaGMynd2tPUzpXG zI6n7pTN48+6aZf2sbcqRb+WCoxrNxRSrU2nScRhPMCi5FlL4yCwqQBSZhi5d6JCjSFx sj9A== X-Gm-Message-State: AG10YORI7MasBUsGimJnaD6EP1LYiPsBqFzG2FBgkxYjaqF4ecx2OhIKgqhnSx0IrTM6TQ== X-Received: by 10.194.94.138 with SMTP id dc10mr47364535wjb.37.1456334374898; Wed, 24 Feb 2016 09:19:34 -0800 (PST) Received: from Solace.station (net-2-35-170-8.cust.vodafonedsl.it. [2.35.170.8]) by smtp.gmail.com with ESMTPSA id g1sm4095381wmc.0.2016.02.24.09.19.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Feb 2016 09:19:33 -0800 (PST) From: Dario Faggioli To: xen-devel@lists.xenproject.org Date: Wed, 24 Feb 2016 18:19:31 +0100 Message-ID: <20160224171931.26396.58255.stgit@Solace.station> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Cc: Anthony Perard , Ian Jackson , Ian Campbell , Jan Beulich Subject: [Xen-devel] [PATCH] xen: typo: use ' as apostrophe in grant_table.h X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If grep 2.23 is installed, build fails like this: ... mkdir -p compat grep -v 'DEFINE_XEN_GUEST_HANDLE(long)' public/grant_table.h | \ python /home/SOURCES/xen/xen/xen.git/xen/tools/compat-build-source.py >compat/grant_table.c.new mv -f compat/grant_table.c.new compat/grant_table.c gcc ... -o compat/grant_table.i compat/grant_table.c compat/grant_table.c:33:1: error: unterminated comment /* ^ compat/grant_table.c:28:0: error: unterminated #ifndef #ifndef __XEN_PUBLIC_GRANT_TABLE_H__ ^ Makefile:62: recipe for target 'compat/grant_table.i' failed make[3]: *** [compat/grant_table.i] Error 1 rm compat/grant_table.c make[3]: Leaving directory '/home/SOURCES/xen/xen/xen.git/xen/include' ... This is because grant_table.h contains this (note the apostrophe): "granter’s memory", and `grep -v', in version 2.23, stops processing the file (while, for instance, until 2.22, this was not happening). Although the above behavior is likely an issue in grep, (https://debbugs.gnu.org/cgi/bugreport.cgi?bug=22461) I think we better switch to using " ' " in that line anyway, as we do basically everywhere else (even in the same file). Signed-off-by: Dario Faggioli --- Cc: Ian Campbell Cc: Ian Jackson Cc: Jan Beulich Cc: Anthony Perard --- xen/include/public/grant_table.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/include/public/grant_table.h b/xen/include/public/grant_table.h index e9393fd..e5f04ec 100644 --- a/xen/include/public/grant_table.h +++ b/xen/include/public/grant_table.h @@ -43,7 +43,7 @@ * table are identified by grant references. A grant reference is an * integer, which indexes into the grant table. It acts as a * capability which the grantee can use to perform operations on the - * granter’s memory. + * granter's memory. * * This capability-based system allows shared-memory communications * between unprivileged domains. A grant reference also encapsulates