From patchwork Thu Mar 17 00:44:06 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Rzeszutek Wilk X-Patchwork-Id: 8606281 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id A0A58C0553 for ; Thu, 17 Mar 2016 00:47:29 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8E620201EF for ; Thu, 17 Mar 2016 00:47:28 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95B33201C0 for ; Thu, 17 Mar 2016 00:47:27 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1agM2y-0002VT-3J; Thu, 17 Mar 2016 00:44:16 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1agM2x-0002VN-1z for xen-devel@lists.xenproject.org; Thu, 17 Mar 2016 00:44:15 +0000 Received: from [85.158.137.68] by server-7.bemta-3.messagelabs.com id DA/A1-04060-EDDF9E65; Thu, 17 Mar 2016 00:44:14 +0000 X-Env-Sender: ketuzsezr@gmail.com X-Msg-Ref: server-3.tower-31.messagelabs.com!1458175452!29582321!1 X-Originating-IP: [209.85.192.68] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 8.11; banners=-,-,- X-VirusChecked: Checked Received: (qmail 47595 invoked from network); 17 Mar 2016 00:44:13 -0000 Received: from mail-qg0-f68.google.com (HELO mail-qg0-f68.google.com) (209.85.192.68) by server-3.tower-31.messagelabs.com with AES128-GCM-SHA256 encrypted SMTP; 17 Mar 2016 00:44:13 -0000 Received: by mail-qg0-f68.google.com with SMTP id y89so4003787qge.0 for ; Wed, 16 Mar 2016 17:44:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=thwPLk1USXxb9AZ3ggdfTM9yF/5ViCA/2qjdS6LmtB0=; b=oOXRNClwA6w4KMve/qAYX2DF4IiyJRnyC7mmm2OTFRVHGv+XsnXqJUhN7nBVsIhsbP e6X/OmNHTSPbMuR9klfugrfJx9ayTaGNfjdyz7mPslYx5P4JAMDoP5wUup7242XRvnvy x+y6mVslYBTkgM7MG//uUFcGBexHjl4kFAIwEzFTCtwyplqRZt0YVUxuQQkOIqvtto/E Uzxv9AwEvhOylOXpMZQmsed1nPQ2E58dpDpLITnlwRB7XQI1+uyDudLyQURmPFSESbG7 CFzDgNAFYq+7T0fFOvk+gyPD1oePMkU3rY1rj4un7k/mzwjbFNXNBi2xe3IupbqwibYm 0Hkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=thwPLk1USXxb9AZ3ggdfTM9yF/5ViCA/2qjdS6LmtB0=; b=GD7vslzTtMufAbANklp83S3hULd9FZg66Uryl1yu+adJboNZtEKpJmuJTT5/S7LLBW M4pLf8QT3ZUJwlmk5555OGH/jvY5D5U09wXoj4ULsmSF3hDWombOzatnVLhrI9zVpF2u 88b15ycEirEm1UHqsT/cfkAyK651wWlB0aCvzbk6WmK1VI4gCTOXpuYs/8jzrmitWgej ssFO5pX0NCXGh5pszvap/lvICt2iP0hDT3Ts3sNJUGq9Mcld8HNq9Ib07HPL4Ri1BqNv i3IGfYdpMKgeWb+NmNJcxtX+sEdJWba12LFSmD8EtMD80TLsVgJ/aDcL8Yv+tlKC/HUA n8ew== X-Gm-Message-State: AD7BkJLam41vtOTs9/huGvcu5JlyzVBhwNDIUkr+mmYXhaUYfz592shtyUeMc4NXhf/CiQ== X-Received: by 10.140.128.21 with SMTP id 21mr3197867qha.59.1458175452220; Wed, 16 Mar 2016 17:44:12 -0700 (PDT) Received: from localhost.localdomain (209-6-196-81.c3-0.smr-ubr2.sbo-smr.ma.cable.rcn.com. [209.6.196.81]) by smtp.gmail.com with ESMTPSA id 107sm2702624qge.16.2016.03.16.17.44.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Mar 2016 17:44:11 -0700 (PDT) Date: Wed, 16 Mar 2016 20:44:06 -0400 From: Konrad Rzeszutek Wilk To: Jan Beulich Message-ID: <20160317004356.GA5173@localhost.localdomain> References: <1458064616-23101-1-git-send-email-konrad.wilk@oracle.com> <1458064616-23101-2-git-send-email-konrad.wilk@oracle.com> <56E94CBE02000078000DD0F7@prv-mh.provo.novell.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <56E94CBE02000078000DD0F7@prv-mh.provo.novell.com> User-Agent: Mutt/1.5.24 (2015-08-30) Cc: Keir Fraser , andrew.cooper3@citrix.com, Ian Jackson , Tim Deegan , mpohlack@amazon.de, ross.lagerwall@citrix.com, sasha.levin@oracle.com, xen-devel@lists.xenproject.org Subject: Re: [Xen-devel] [PATCH v4 01/34] compat/x86: Remove unncessary #define. X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, Mar 16, 2016 at 05:08:30AM -0600, Jan Beulich wrote: > >>> On 15.03.16 at 18:56, wrote: > > It is not used. > > Consistently please - either keep them all (just to cover the case > that they might get used) or remove them all: xen_compile_info, > xen_changeset_info, etc are all unused too. Otoh > xennmi_callback is used, but xennmi_callback_t isn't. Which to me > suggests that we should leave this alone. Oddly enough taking an cleaver to it was OK. From 7e3ed6faed6e083f27ad6be947ac528c3eaba9a1 Mon Sep 17 00:00:00 2001 From: Konrad Rzeszutek Wilk Date: Wed, 2 Mar 2016 12:50:32 -0500 Subject: [PATCH v4 02/35] compat/x86: Remove unncessary #defines. They are not used. Signed-off-by: Konrad Rzeszutek Wilk Reviewed-by: Andrew Cooper --- Cc: Ian Jackson Cc: Jan Beulich Cc: Keir Fraser Cc: Tim Deegan v2: Remove a lot more of them. --- --- xen/common/compat/kernel.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/xen/common/compat/kernel.c b/xen/common/compat/kernel.c index df93fdd..dc898ae 100644 --- a/xen/common/compat/kernel.c +++ b/xen/common/compat/kernel.c @@ -18,30 +18,22 @@ asm(".file \"" __FILE__ "\""); extern xen_commandline_t saved_cmdline; -#define xen_extraversion compat_extraversion #define xen_extraversion_t compat_extraversion_t -#define xen_compile_info compat_compile_info #define xen_compile_info_t compat_compile_info_t CHECK_TYPE(capabilities_info); -#define xen_platform_parameters compat_platform_parameters #define xen_platform_parameters_t compat_platform_parameters_t #undef HYPERVISOR_VIRT_START #define HYPERVISOR_VIRT_START HYPERVISOR_COMPAT_VIRT_START(current->domain) -#define xen_changeset_info compat_changeset_info #define xen_changeset_info_t compat_changeset_info_t -#define xen_feature_info compat_feature_info #define xen_feature_info_t compat_feature_info_t CHECK_TYPE(domain_handle); -#define xennmi_callback compat_nmi_callback -#define xennmi_callback_t compat_nmi_callback_t - #ifdef COMPAT_VM_ASSIST_VALID #undef VM_ASSIST_VALID #define VM_ASSIST_VALID COMPAT_VM_ASSIST_VALID