| Message ID | 20160318190513.8117.45583.stgit@Solace.station (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 18/03/16 20:05, Dario Faggioli wrote: > From: Uma Sharma <uma.sharma523@gmail.com> > > and, while we are adjusting signedness of opt_load_window_shift, > make also prv->load_window_shift unsigned, as approapriate. > > Signed-off-by: Uma Sharma <uma.sharma523@gmail.com> > Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com> > --- > Cc: George Dunlap <george.dunlap@eu.citrix.com> > Cc: Juergen Gross <jgross@suse.com> > Cc: Jan Beulich <JBeulich@suse.com> > --- > Patch has changed, so I'm not sticking any tag v1 received > (namely, Juergen's Reviewed-by:). Adding it again: Reviewed-by: Juergen Gross <jgross@suse.com> > --- > Changes from v1: > * improve signedness as well, as requested during review. > --- > xen/common/sched_credit2.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c > index 64fb028..2fd4175 100644 > --- a/xen/common/sched_credit2.c > +++ b/xen/common/sched_credit2.c > @@ -162,7 +162,7 @@ > #define CSFLAG_runq_migrate_request (1<<__CSFLAG_runq_migrate_request) > > > -int opt_migrate_resist=500; > +static unsigned int __read_mostly opt_migrate_resist = 500; > integer_param("sched_credit2_migrate_resist", opt_migrate_resist); > > /* > @@ -185,12 +185,12 @@ integer_param("sched_credit2_migrate_resist", opt_migrate_resist); > * to a load of 1. > */ > #define LOADAVG_GRANULARITY_SHIFT (10) > -int opt_load_window_shift=18; > +static unsigned int __read_mostly opt_load_window_shift = 18; > #define LOADAVG_WINDOW_SHIFT_MIN 4 > integer_param("credit2_load_window_shift", opt_load_window_shift); > -int opt_underload_balance_tolerance=0; > +static int __read_mostly opt_underload_balance_tolerance = 0; > integer_param("credit2_balance_under", opt_underload_balance_tolerance); > -int opt_overload_balance_tolerance=-3; > +static int __read_mostly opt_overload_balance_tolerance = -3; > integer_param("credit2_balance_over", opt_overload_balance_tolerance); > > /* > @@ -227,7 +227,7 @@ struct csched2_private { > cpumask_t active_queues; /* Queues which may have active cpus */ > struct csched2_runqueue_data rqd[NR_CPUS]; > > - int load_window_shift; > + unsigned int load_window_shift; > }; > > /* > >
On 18/03/16 19:05, Dario Faggioli wrote: > From: Uma Sharma <uma.sharma523@gmail.com> > > and, while we are adjusting signedness of opt_load_window_shift, > make also prv->load_window_shift unsigned, as approapriate. > > Signed-off-by: Uma Sharma <uma.sharma523@gmail.com> > Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com> Acked-by: George Dunlap <george.dunlap@citrix.com> > --- > Cc: George Dunlap <george.dunlap@eu.citrix.com> > Cc: Juergen Gross <jgross@suse.com> > Cc: Jan Beulich <JBeulich@suse.com> > --- > Patch has changed, so I'm not sticking any tag v1 received > (namely, Juergen's Reviewed-by:). > --- > Changes from v1: > * improve signedness as well, as requested during review. > --- > xen/common/sched_credit2.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c > index 64fb028..2fd4175 100644 > --- a/xen/common/sched_credit2.c > +++ b/xen/common/sched_credit2.c > @@ -162,7 +162,7 @@ > #define CSFLAG_runq_migrate_request (1<<__CSFLAG_runq_migrate_request) > > > -int opt_migrate_resist=500; > +static unsigned int __read_mostly opt_migrate_resist = 500; > integer_param("sched_credit2_migrate_resist", opt_migrate_resist); > > /* > @@ -185,12 +185,12 @@ integer_param("sched_credit2_migrate_resist", opt_migrate_resist); > * to a load of 1. > */ > #define LOADAVG_GRANULARITY_SHIFT (10) > -int opt_load_window_shift=18; > +static unsigned int __read_mostly opt_load_window_shift = 18; > #define LOADAVG_WINDOW_SHIFT_MIN 4 > integer_param("credit2_load_window_shift", opt_load_window_shift); > -int opt_underload_balance_tolerance=0; > +static int __read_mostly opt_underload_balance_tolerance = 0; > integer_param("credit2_balance_under", opt_underload_balance_tolerance); > -int opt_overload_balance_tolerance=-3; > +static int __read_mostly opt_overload_balance_tolerance = -3; > integer_param("credit2_balance_over", opt_overload_balance_tolerance); > > /* > @@ -227,7 +227,7 @@ struct csched2_private { > cpumask_t active_queues; /* Queues which may have active cpus */ > struct csched2_runqueue_data rqd[NR_CPUS]; > > - int load_window_shift; > + unsigned int load_window_shift; > }; > > /* >
diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c index 64fb028..2fd4175 100644 --- a/xen/common/sched_credit2.c +++ b/xen/common/sched_credit2.c @@ -162,7 +162,7 @@ #define CSFLAG_runq_migrate_request (1<<__CSFLAG_runq_migrate_request) -int opt_migrate_resist=500; +static unsigned int __read_mostly opt_migrate_resist = 500; integer_param("sched_credit2_migrate_resist", opt_migrate_resist); /* @@ -185,12 +185,12 @@ integer_param("sched_credit2_migrate_resist", opt_migrate_resist); * to a load of 1. */ #define LOADAVG_GRANULARITY_SHIFT (10) -int opt_load_window_shift=18; +static unsigned int __read_mostly opt_load_window_shift = 18; #define LOADAVG_WINDOW_SHIFT_MIN 4 integer_param("credit2_load_window_shift", opt_load_window_shift); -int opt_underload_balance_tolerance=0; +static int __read_mostly opt_underload_balance_tolerance = 0; integer_param("credit2_balance_under", opt_underload_balance_tolerance); -int opt_overload_balance_tolerance=-3; +static int __read_mostly opt_overload_balance_tolerance = -3; integer_param("credit2_balance_over", opt_overload_balance_tolerance); /* @@ -227,7 +227,7 @@ struct csched2_private { cpumask_t active_queues; /* Queues which may have active cpus */ struct csched2_runqueue_data rqd[NR_CPUS]; - int load_window_shift; + unsigned int load_window_shift; }; /*