From patchwork Wed Apr 6 17:23:18 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Faggioli X-Patchwork-Id: 8764001 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id A2F5CC0553 for ; Wed, 6 Apr 2016 17:25:57 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A32382020F for ; Wed, 6 Apr 2016 17:25:56 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C4B59201ED for ; Wed, 6 Apr 2016 17:25:55 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1anrBa-0001UU-F4; Wed, 06 Apr 2016 17:24:10 +0000 Received: from mail6.bemta6.messagelabs.com ([85.158.143.247]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1anrBZ-0001Th-AV for xen-devel@lists.xenproject.org; Wed, 06 Apr 2016 17:24:09 +0000 Received: from [85.158.143.35] by server-1.bemta-6.messagelabs.com id 04/4F-18833-83645075; Wed, 06 Apr 2016 17:24:08 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrHIsWRWlGSWpSXmKPExsXiVRvkomvhxhp ucG4fv8X3LZOZHBg9Dn+4whLAGMWamZeUX5HAmjHrzzbmgud8FT27L7A1ME7g7WLk4hASmMEo cf3TezYQh0VgDavEhWOXWUEcCYFLrBKPXsxl6WLkBHJiJKY2drNB2FUSh06eYgKxhQRUJG5uX 8UEMWoJk8TWK2eYQRLCAnoSR47+YIewkyQu/PgH1swmYCDxZsdeVhBbREBJ4t6qyWDNzAJTGS XWP9gIto1FQFVizoxnYEW8AvYSR96fABrEwcEp4CCxZ7I7xGJ7iatfToDtEhWQk1h5uQWqXFD i5MwnLCDlzAKaEut36YOEmQXkJba/ncM8gVFkFpKqWQhVs5BULWBkXsWoXpxaVJZapGusl1SU mZ5RkpuYmaNraGCml5taXJyYnpqTmFSsl5yfu4kRGP4MQLCDseOf0yFGSQ4mJVFeTwnWcCG+p PyUyozE4oz4otKc1OJDjBocHAITzs6dziTFkpefl6okwRvsClQnWJSanlqRlpkDjFCYUgkOHi URXleQNG9xQWJucWY6ROoUoy7Hlqn31jIJgc2QEucNBSkSACnKKM2DGwFLFpcYZaWEeRmBDhT iKUgtys0sQZV/xSjOwagkzJsLMoUnM68EbtMroCOYgI6oF2YCOaIkESEl1cDIksNRocu+8P3v 2/1Sh1dt+7D2nRmL5Psz07u4vrWVPwl38fn0TsT2VOE88/QbTO6n301eL+XDt3T6RS+vkws/T Xpmb1BqZe5zt/mn1Rz7a5tjpdt7VPra2Harb5rxefK/5d4Xa9pqnzH2v/ubHrwnMjz23X4uJw 6hWyHn73GFGT3J+GcesXmaEktxRqKhFnNRcSIA03GkehEDAAA= X-Env-Sender: raistlin.df@gmail.com X-Msg-Ref: server-10.tower-21.messagelabs.com!1459963448!7788857!1 X-Originating-IP: [74.125.82.68] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 8.28; banners=-,-,- X-VirusChecked: Checked Received: (qmail 31077 invoked from network); 6 Apr 2016 17:24:08 -0000 Received: from mail-wm0-f68.google.com (HELO mail-wm0-f68.google.com) (74.125.82.68) by server-10.tower-21.messagelabs.com with AES128-GCM-SHA256 encrypted SMTP; 6 Apr 2016 17:24:08 -0000 Received: by mail-wm0-f68.google.com with SMTP id o129so5675830wmo.3 for ; Wed, 06 Apr 2016 10:24:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:from:to:cc:date:message-id:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=hSWiCSqfO6rwwkaDLT8kfByK1XhNA4ih8vMk78ng5rw=; b=jT44+Bzx7ZWMbX/p7iqn7fIdbJWxAy0f+O7qze/Yd0rXm02plDfTtvgombPy8AezbR GhvEY4G5z0GW45wn3AhtTWVrEqKVSavxNsT/RKg2SSCk491eRM+RW6K8oaL48Q51p+P6 FsGadn96jYjCn9bDMA+KJsaqNN8fD//EB9eHQH+K65rmCECuq5XB6osWoaFMG9EzonHG O1LAifraOdot0q6VxkJEaGE6o/oZm2mSJVH/3QRLB8Q4aglR+V94qws9bWrT6v/XVc/b CPRPmOktp3Yukgp0yU4jHDjo+fujib352kEZj5M9DdM2Fx2KxJbGXfauUxLKp3ZJg/5j mUSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:from:to:cc:date:message-id :in-reply-to:references:user-agent:mime-version :content-transfer-encoding; bh=hSWiCSqfO6rwwkaDLT8kfByK1XhNA4ih8vMk78ng5rw=; b=Mby/oN0fNwFFg33s8r2ZZUkWhVtMVjP8Hij7Wdi9yC9z4sFeh944KDC51T7ljRued4 CQV7vCwTRILFjmAxjmGYHKAh95GAaARDNV+UaLP1STGqPKUSwz5eYT220MNQrgUFeXvL oPYjvELaKK4QrWGxGhi7JFjkgEQnryFySx/X8J88Pmec6qtBC6YXGoKbM7kDHtgEuB8i Ij7crV4jV3H+gykv+6/gure6fs5+MF0iadSCyKbVbEueb1S8S0yrkOyem64ld4zwxd+N xM6c7LXDf/LEMEvfWfh9fmjN9X1gc5kgGLB+P+ri9H32fRIi88LNyjLCK3kXv5nA1A8w Pb8g== X-Gm-Message-State: AD7BkJIBp58QFkanvjgsEBwdOmkBy3tpw0vGL+m3wne/0ijblXIP0pg1pnbTijXlwhmbNA== X-Received: by 10.28.55.139 with SMTP id e133mr25312805wma.98.1459963401504; Wed, 06 Apr 2016 10:23:21 -0700 (PDT) Received: from Solace.fritz.box (net-37-116-155-252.cust.vodafonedsl.it. [37.116.155.252]) by smtp.gmail.com with ESMTPSA id i206sm25834041wmf.1.2016.04.06.10.23.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Apr 2016 10:23:20 -0700 (PDT) From: Dario Faggioli To: xen-devel@lists.xenproject.org Date: Wed, 06 Apr 2016 19:23:18 +0200 Message-ID: <20160406172318.25877.52092.stgit@Solace.fritz.box> In-Reply-To: <20160406170023.25877.15622.stgit@Solace.fritz.box> References: <20160406170023.25877.15622.stgit@Solace.fritz.box> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Cc: Juergen Gross , George Dunlap , Jan Beulich , Uma Sharma Subject: [Xen-devel] [PATCH v2 05/11] xen: sched: improve credit2 bootparams' scope, placement and signedness X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Uma Sharma and, while we are adjusting signedness of opt_load_window_shift, make also prv->load_window_shift unsigned, as approapriate. Signed-off-by: Uma Sharma Signed-off-by: Dario Faggioli Reviewed-by: Juergen Gross Acked-by: George Dunlap --- Cc: Jan Beulich --- xen/common/sched_credit2.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c index 60c6f5b..7286e50 100644 --- a/xen/common/sched_credit2.c +++ b/xen/common/sched_credit2.c @@ -162,7 +162,7 @@ #define CSFLAG_runq_migrate_request (1<<__CSFLAG_runq_migrate_request) -int opt_migrate_resist=500; +static unsigned int __read_mostly opt_migrate_resist = 500; integer_param("sched_credit2_migrate_resist", opt_migrate_resist); /* @@ -185,12 +185,12 @@ integer_param("sched_credit2_migrate_resist", opt_migrate_resist); * to a load of 1. */ #define LOADAVG_GRANULARITY_SHIFT (10) -int opt_load_window_shift=18; +static unsigned int __read_mostly opt_load_window_shift = 18; #define LOADAVG_WINDOW_SHIFT_MIN 4 integer_param("credit2_load_window_shift", opt_load_window_shift); -int opt_underload_balance_tolerance=0; +static int __read_mostly opt_underload_balance_tolerance = 0; integer_param("credit2_balance_under", opt_underload_balance_tolerance); -int opt_overload_balance_tolerance=-3; +static int __read_mostly opt_overload_balance_tolerance = -3; integer_param("credit2_balance_over", opt_overload_balance_tolerance); /* @@ -227,7 +227,7 @@ struct csched2_private { cpumask_t active_queues; /* Queues which may have active cpus */ struct csched2_runqueue_data rqd[NR_CPUS]; - int load_window_shift; + unsigned int load_window_shift; }; /*