| Message ID | 20160526075843.25236-5-Wei.Chen@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Wei, On 26/05/16 08:58, Wei Chen wrote: > In AArch32, MPIDR bit31 is defined as multiprocessing extensions bit. NIT: s/bit31/bit 31/ > But in AArch64, this bit is always RES1. So the value check for this > bit is no longer necessary in AArch64. > > Signed-off-by: Wei Chen <Wei.Chen@linaro.org> With the change above: Reviewed-by: Julien Grall <julien.grall@arm.com> Regards,
diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S index 3090beb..91e2817 100644 --- a/xen/arch/arm/arm64/head.S +++ b/xen/arch/arm/arm64/head.S @@ -267,7 +267,6 @@ common_start: * find that multiprocessor extensions are * present and the system is SMP */ mrs x0, mpidr_el1 - tbz x0, _MPIDR_SMP, 1f /* Multiprocessor extension not supported? */ tbnz x0, _MPIDR_UP, 1f /* Uniprocessor system? */ ldr x13, =(~MPIDR_HWID_MASK)
In AArch32, MPIDR bit31 is defined as multiprocessing extensions bit. But in AArch64, this bit is always RES1. So the value check for this bit is no longer necessary in AArch64. Signed-off-by: Wei Chen <Wei.Chen@linaro.org> --- v2: Make clear the status of MPIDR.SMP bit in AArch32 and AArch64. --- xen/arch/arm/arm64/head.S | 1 - 1 file changed, 1 deletion(-)