From patchwork Fri Aug 12 17:04:52 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 9277509 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EA3F960780 for ; Fri, 12 Aug 2016 17:07:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D6B2828AA5 for ; Fri, 12 Aug 2016 17:07:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CAC4A28ABE; Fri, 12 Aug 2016 17:07:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 225E128AA5 for ; Fri, 12 Aug 2016 17:07:49 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bYFtD-0004cZ-Rk; Fri, 12 Aug 2016 17:04:59 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bYFtC-0004cT-AX for xen-devel@lists.xensource.com; Fri, 12 Aug 2016 17:04:58 +0000 Received: from [85.158.137.68] by server-4.bemta-3.messagelabs.com id 0F/8C-15788-9B10EA75; Fri, 12 Aug 2016 17:04:57 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprLIsWRWlGSWpSXmKPExsVyuP0Ov+5OxnX hBvN6WCzuTXnP7sDosb1vF3sAYxRrZl5SfkUCa8ap5xvZCraKVTyatpe1gfGdYBcjJ4eEgJHE 24n/mLoYuTiEBBYySjzsXsEOkmARUJXo+nOVuYuRg4NNQFfi5m0JkLCIgJLE10VzweqZBZZwS 5y/fogFJCEsYCex5sh3MJtXwFCia14rO8TQWcwSi+e0QyUEJU7OfAJmMwtoSdz495IJZAGzgL TE8n8cIGFOoN4nFyBKRAVUJKac3MY2gZFvFpLuWUi6ZyF0L2BkXsWoUZxaVJZapGtkppdUlJm eUZKbmJmja2hgrJebWlycmJ6ak5hUrJecn7uJERhs9QwMjDsYG/b6HWKU5GBSEuV9dmFtuBBf Un5KZUZicUZ8UWlOavEhRhkODiUJXk6GdeFCgkWp6akVaZk5wLCHSUtw8CiJ8FaDpHmLCxJzi zPTIVKnGBWlxHmlQRICIImM0jy4NlisXWKUlRLmZWRgYBDiKUgtys0sQZV/xSjOwagkzNsGMo UnM68EbvoroMVMQItPmK0BWVySiJCSamDcZnRM8XHEyer/HVtb0lYFhTze7REj/YDn4qTpUm/ vR7XlVVoeF1+l155/6ZpHOmt/zJxTOlF1eqv2nlErfVJxK/iyxcK+LwmL3j9VKo7uvs0Zc9Mn /k5k6ZTVD9KurLzq/2r64zOWfldOGc9z2Haz7lqMmkpKsE+jNJ+rY0PMupBiCYHZJheVWIozE g21mIuKEwGNJY8osAIAAA== X-Env-Sender: lurodriguez@suse.de X-Msg-Ref: server-13.tower-31.messagelabs.com!1471021496!54737082!1 X-Originating-IP: [195.135.220.15] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 8.84; banners=-,-,- X-VirusChecked: Checked Received: (qmail 53995 invoked from network); 12 Aug 2016 17:04:57 -0000 Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by server-13.tower-31.messagelabs.com with DHE-RSA-CAMELLIA256-SHA encrypted SMTP; 12 Aug 2016 17:04:57 -0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 12B53AD2C; Fri, 12 Aug 2016 17:04:54 +0000 (UTC) Date: Fri, 12 Aug 2016 19:04:52 +0200 From: "Luis R. Rodriguez" To: Borislav Petkov Message-ID: <20160812170451.GE3296@wotan.suse.de> References: <1469222687-1600-8-git-send-email-mcgrof@kernel.org> <20160729100630.GA27271@nazgul.tnic> <20160808150539.GG3296@wotan.suse.de> <20160809035508.GC11445@nazgul.tnic> <20160812035129.GA3296@wotan.suse.de> <20160812052303.GB12013@nazgul.tnic> <20160812065011.GB3296@wotan.suse.de> <20160812072507.GC12013@nazgul.tnic> <20160812152805.GD3296@wotan.suse.de> <20160812155121.GB13315@nazgul.tnic> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160812155121.GB13315@nazgul.tnic> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: gnomes@lxorguk.ukuu.org.uk, linux-ia64@vger.kernel.org, jkosina@suse.cz, benh@kernel.crashing.org, ming.lei@canonical.com, heiko.carstens@de.ibm.com, platform-driver-x86@vger.kernel.org, paul.gortmaker@windriver.com, hpa@zytor.com, masami.hiramatsu.pt@hitachi.com, linux-arch@vger.kernel.org, sparclinux@vger.kernel.org, xen-devel@lists.xensource.com, linux@arm.linux.org.uk, linux-sh@vger.kernel.org, will.deacon@arm.com, korea.drzix@gmail.com, x86@kernel.org, anil.s.keshavamurthy@intel.com, fontana@sharpeleven.org, torvalds@linux-foundation.org, mingo@redhat.com, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, dvhart@infradead.org, david.vrabel@citrix.com, pali.rohar@gmail.com, keescook@chromium.org, arnd@arndb.de, realmz6@gmail.com, linux@rasmusvillemoes.dk, rusty@rustcorp.com.au, rostedt@goodmis.org, christopher.denicolo@suse.com, jbaron@akamai.com, ananth@linux.vnet.ibm.com, ciaran.farrell@suse.com, jpoimboe@redhat.com, tglx@linutronix.de, andriy.shevchenko@linux.intel.com, mcb30@ipxe.org, linux-kbuild@vger.kernel.org, alan@linux.intel.com, jgross@suse.com, pebolle@tiscali.nl, tony.luck@intel.com, ananth@in.ibm.com, gregkh@linuxfoundation.org, luto@amacapital.net, ak@linux.intel.com, "Luis R. Rodriguez" , mmarek@suse.com, mhiramat@kernel.org, andrew.cooper3@citrix.com, akpm@linux-foundation.org, dwmw2@infradead.org, davem@davemloft.net Subject: Re: [Xen-devel] [RFC v3 07/13] tables.h: add linker table support X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP On Fri, Aug 12, 2016 at 05:51:21PM +0200, Borislav Petkov wrote: > On Fri, Aug 12, 2016 at 05:28:05PM +0200, Luis R. Rodriguez wrote: > > Even so, you don't link the compiled extra code so the only penalty > > here is when compiling, nothing more. And if you are compiling typically > > the cost here is just a few seconds. > > Yeah, so let's make it clear that this is similar to COMPILE_TEST and > people with fast machines and who don't mind building a couple more > seconds longer, should enable it. Sure, I'll also move it under COMPILE_TEST, and default it to n. > You don't want to be doing bit-rotting tests on small, weak machines, > which barely get done with the build as it is. I have a 32-bit atom > which takes hours to build a kernel. Enabling that there is not making > the kernel build any more fun. > > > > ... or you simply don't want to have stuff which is forcibly enabled on you even > > > if you're never going to need it > > > ... > > > > Which seems to be the same as the reason I noted ? > > No, the reason is we don't force stuff down people's throats just > because we think we know better. Other people do that. > > Instead, we help them make an informed decision by describing the > feature as precisely as possible. > > > I can remove the grumpy maintainer description :) > > Yap :-) Alright, how's this new description: diff --git a/init/Kconfig b/init/Kconfig index cac3f096050d..73e4890c24c4 100644 --- a/init/Kconfig +++ b/init/Kconfig @@ -53,6 +53,34 @@ config CROSS_COMPILE need to set this unless you want the configured kernel build directory to select the cross-compiler automatically. +config BUILD_AVOID_BITROT + bool "Always force building specially annotated targets" + default n + help + If enabled then the the special table-* Makefile targets will always + be forced to be compiled even if their respective CONFIG_ option has + been disabled, but its objects will only be linked in if the same + respective CONFIG_ option has been enabled. This helps avoid code + bit rot issues, use for these targets should be carefully considred + by maintainers. You can safely enable this option at the expense of + increasing compile time. Enabling this option helps avoid code bit + rot by taking advantage of the facilities provided and enabled by + using linker tables documented under: + + include/linux/tables.h + + The special targets supported are: + + o table-obj-y + o table-lib-y + + Say Y if you have a decent build machine and would like to help test + building code for more subsystems. Say N if you do you not have a + good build machine or only want to compile what you've enabled for + your kernel. + + Enabling this option never increases the size of your kernel. + config COMPILE_TEST bool "Compile also drivers which will not load" depends on !UML