From patchwork Sat Oct 22 11:23:03 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "lan,Tianyu" X-Patchwork-Id: 9390355 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 06A4360762 for ; Sat, 22 Oct 2016 03:34:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EEE2A2A058 for ; Sat, 22 Oct 2016 03:34:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E33612A064; Sat, 22 Oct 2016 03:34:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=2.0 tests=BAYES_00, DATE_IN_FUTURE_06_12, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 5E5BA2A058 for ; Sat, 22 Oct 2016 03:34:48 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bxn2N-0005Jh-Td; Sat, 22 Oct 2016 03:31:59 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bxn2M-0005Jb-Ck for xen-devel@lists.xenproject.org; Sat, 22 Oct 2016 03:31:58 +0000 Received: from [193.109.254.147] by server-9.bemta-6.messagelabs.com id B3/C3-28857-DADDA085; Sat, 22 Oct 2016 03:31:57 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrILMWRWlGSWpSXmKPExsVywNykQnfNXa4 Ig2mPzC2+b5nM5MDocfjDFZYAxijWzLyk/IoE1owXfxqYCxrZK/Z9XMvcwPiGtYuRk0NIoFJi 8ZODbCC2hACvxJFlM1ghbD+J1asuM0HU1EgsnHoXzGYTUJc4sXgiI4gtIqAkcW/VZKA4Fwezw HVGiaZrp8EGCQvkSHy5cpQZxGYRUJV49KkbqIiDg1fAUqKpWw9ivpzEpW1fmCcwci9gZFjFqF GcWlSWWqRrbKCXVJSZnlGSm5iZo2toYKaXm1pcnJiempOYVKyXnJ+7iRHoXQYg2MH4d23gIUZ JDiYlUd5FEzkjhPiS8lMqMxKLM+KLSnNSiw8xynBwKEnwlt/hihASLEpNT61Iy8wBhhlMWoKD R0mE9wdImre4IDG3ODMdInWKUZdjwY/ba5mEWPLy81KlxHnfgBQJgBRllObBjYCF/CVGWSlhX kago4R4ClKLcjNLUOVfMYpzMCoJ87qBTOHJzCuB2/QK6AgmoCNq0jhAjihJREhJNTCazWrK/J +kK3DY8tN+g9sPp9bduz9HZ7voF5OpOprdTAfObHzjzCO1TtTh2PGESf9m7Xu9KSN/nti635+ KmZNM9NdaLfRYM+fUtm+yld83SM7NzAputBCVcrizi1O5eZt8zJ2VFrcmBR/c0L0x63RF1ZKP z7vWPOhuWPhgYd+Toz0uZXqrXgQlK7EUZyQaajEXFScCAKAKNW10AgAA X-Env-Sender: tianyu.lan@intel.com X-Msg-Ref: server-7.tower-27.messagelabs.com!1477107114!62266560!1 X-Originating-IP: [192.55.52.120] X-SpamReason: No, hits=1.7 required=7.0 tests=DATE_IN_FUTURE_06_12 X-StarScan-Received: X-StarScan-Version: 9.0.13; banners=-,-,- X-VirusChecked: Checked Received: (qmail 35131 invoked from network); 22 Oct 2016 03:31:56 -0000 Received: from mga04.intel.com (HELO mga04.intel.com) (192.55.52.120) by server-7.tower-27.messagelabs.com with DHE-RSA-CAMELLIA256-SHA encrypted SMTP; 22 Oct 2016 03:31:56 -0000 Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP; 21 Oct 2016 20:31:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,527,1473145200"; d="scan'208";a="22371430" Received: from unknown (HELO localhost) ([10.239.48.115]) by fmsmga005.fm.intel.com with ESMTP; 21 Oct 2016 20:31:52 -0700 From: Lan Tianyu To: xen-devel@lists.xenproject.org Date: Sat, 22 Oct 2016 19:23:03 +0800 Message-Id: <20161022112303.11451-1-tianyu.lan@intel.com> X-Mailer: git-send-email 2.9.3 Cc: Lan Tianyu , sstabellini@kernel.org, wei.liu2@citrix.com, George.Dunlap@eu.citrix.com, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, jbeulich@suse.com Subject: [Xen-devel] [PATCH] Xen: Force non-irq keyhandler to be run in tasklet when receive a debugkey from serial port X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP __serial_rx() runs in either irq handler or timer handler and non-irq keyhandler should not run in these contexts. So always force non-irq keyhandler to run in tasklet when receive a debugkey from serial port Signed-off-by: Lan Tianyu --- xen/drivers/char/console.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c index b0f74ce..184b523 100644 --- a/xen/drivers/char/console.c +++ b/xen/drivers/char/console.c @@ -347,7 +347,7 @@ static void switch_serial_input(void) static void __serial_rx(char c, struct cpu_user_regs *regs) { if ( xen_rx ) - return handle_keypress(c, regs, !in_irq()); + return handle_keypress(c, regs, true); /* Deliver input to guest buffer, unless it is already full. */ if ( (serial_rx_prod-serial_rx_cons) != SERIAL_RX_SIZE )