OSSTest, standalone, weird end of invocation.

Commit Message

Anthony PERARD Nov. 16, 2016, 12:25 p.m. UTC

On Tue, Nov 15, 2016 at 04:07:03PM -0500, Konrad Rzeszutek Wilk wrote:
> Hey Ian,
> 
> I've my test machine, and I can run some of the standalone
> tests. But everytime I run any of the jobs I get:
> 
> .. snip..
> 2016-11-16 00:07:55 Z setting xtfbuildjob=build-amd64-xtf
> 2016-11-16 00:07:55 Z log capturing not enabled
> + rc=0
> + date -u +%Y-%m-%d %H:%M:%S Z exit status 0
> 2016-11-16 00:07:55 Z exit status 0
> + exit 0
> 2016-11-16 00:07:55 Z standalone.test-xtf-amd64-amd64-1 13 status status pass
> 2016-11-16 00:07:55 Z finished standalone.test-xtf-amd64-amd64-1 ts-logs-capture host pass
> expected boolean value but got ""
>     while executing
> "if {[jobdb::job-check-escaped-steps $flight $job]} {
>             set ok 0
>         }"
>     (procedure "run-job" line 54)
>     invoked from within
> "run-job $job"
>     (file "./sg-run-job" line 537)
> konrad@osstest:~/osstest$ echo $?
> 1
> 
> Any clue what I amissing? I have been ignoring it and been focusing on
> other things.
> 

Nothing. It's a missing implementation of job-check-escaped-steps for
standalone.

I have this patch/hack:

Patch

diff --git a/tcl/JobDB-Standalone.tcl b/tcl/JobDB-Standalone.tcl
index 375e6ba..09eac6e 100644
--- a/tcl/JobDB-Standalone.tcl
+++ b/tcl/JobDB-Standalone.tcl
@@ -57,7 +57,7 @@  proc read-runvar {flight job name {val {}}} {
     return $val
 }
 
-proc job-check-escaped-steps {flight job} { }
+proc job-check-escaped-steps {flight job} { return 0 }
 
 proc ensure-db-open {} {
     global c