From patchwork Wed Nov 16 12:25:25 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anthony PERARD X-Patchwork-Id: 9431397 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0D7376047D for ; Wed, 16 Nov 2016 12:27:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F32F328E15 for ; Wed, 16 Nov 2016 12:27:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E81E728E24; Wed, 16 Nov 2016 12:27:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 32F6228E15 for ; Wed, 16 Nov 2016 12:27:35 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c6zHP-0002Oc-RH; Wed, 16 Nov 2016 12:25:31 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c6zHO-0002OO-1M for xen-devel@lists.xensource.com; Wed, 16 Nov 2016 12:25:30 +0000 Received: from [193.109.254.147] by server-8.bemta-6.messagelabs.com id F4/B4-20944-9305C285; Wed, 16 Nov 2016 12:25:29 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrKIsWRWlGSWpSXmKPExsXitHSDva5FgE6 EwdYjShb3prxnd2D02N63iz2AMYo1My8pvyKBNaPl3mfGgg/cFTf/NTE2MJ7j7GLk5JAQ8JfY N/MBM4jNIqAq8XXuY1YQm03AQGLF9KuMILaIgJFE553LLF2MHBzMAgUSLS2WIGFhATeJza3H2 UBsXgFriV0728FsIQEzid4fMxkh4oISJ2c+YQGxmQV0JBbs/sQGMUZaYvk/DpAwp4C5xJE/N8 BKRAWUJf4evscCMUZN4sbCZWBbJQS4Jf52209g5J+FZOgsJENnIQxdwMi8ilGjOLWoLLVI18h SL6koMz2jJDcxM0fX0MBMLze1uDgxPTUnMalYLzk/dxMjMPgYgGAH44FFgYcYJTmYlER5eVh1 IoT4kvJTKjMSizPii0pzUosPMcpwcChJ8HL5A+UEi1LTUyvSMnOAcQCTluDgURLh3e4HlOYtL kjMLc5Mh0idYlSUEuc9ApIQAElklObBtcFi7xKjrJQwLyPQIUI8BalFuZklqPKvGMU5GJWEef +BTOHJzCuBm/4KaDET0OI9AmCLSxIRUlINjOqxTPs3rIv+EaPtfn6v6seqIjaDxW7RXLEtepY WgmnPm72NrCSd3hi9v6nyNN6T+a7u1Z3yM3fHbmn36pwkoLpKrst2t0dyp0OXofzPZqW7B5qT shWuGJRvllaJttha/OigbWjM9AfajnPuMDNNP+N3aU3x/dush25t9XfhEfqw5ZzIw4TvSizFG YmGWsxFxYkAt7Uo+7gCAAA= X-Env-Sender: prvs=12141282b=anthony.perard@citrix.com X-Msg-Ref: server-14.tower-27.messagelabs.com!1479299126!59672780!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 9.0.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 47102 invoked from network); 16 Nov 2016 12:25:28 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-14.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 16 Nov 2016 12:25:28 -0000 X-IronPort-AV: E=Sophos;i="5.31,500,1473120000"; d="scan'208";a="398510453" Date: Wed, 16 Nov 2016 12:25:25 +0000 From: Anthony PERARD To: Konrad Rzeszutek Wilk Message-ID: <20161116122525.GA1717@perard.uk.xensource.com> References: <20161115210703.GM9147@char.us.oracle.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20161115210703.GM9147@char.us.oracle.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-DLP: MIA1 Cc: ian.jackson@citrix.com, Marcos Matsunaga , xen-devel@lists.xensource.com Subject: Re: [Xen-devel] OSSTest, standalone, weird end of invocation. X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP On Tue, Nov 15, 2016 at 04:07:03PM -0500, Konrad Rzeszutek Wilk wrote: > Hey Ian, > > I've my test machine, and I can run some of the standalone > tests. But everytime I run any of the jobs I get: > > .. snip.. > 2016-11-16 00:07:55 Z setting xtfbuildjob=build-amd64-xtf > 2016-11-16 00:07:55 Z log capturing not enabled > + rc=0 > + date -u +%Y-%m-%d %H:%M:%S Z exit status 0 > 2016-11-16 00:07:55 Z exit status 0 > + exit 0 > 2016-11-16 00:07:55 Z standalone.test-xtf-amd64-amd64-1 13 status status pass > 2016-11-16 00:07:55 Z finished standalone.test-xtf-amd64-amd64-1 ts-logs-capture host pass > expected boolean value but got "" > while executing > "if {[jobdb::job-check-escaped-steps $flight $job]} { > set ok 0 > }" > (procedure "run-job" line 54) > invoked from within > "run-job $job" > (file "./sg-run-job" line 537) > konrad@osstest:~/osstest$ echo $? > 1 > > Any clue what I amissing? I have been ignoring it and been focusing on > other things. > Nothing. It's a missing implementation of job-check-escaped-steps for standalone. I have this patch/hack: diff --git a/tcl/JobDB-Standalone.tcl b/tcl/JobDB-Standalone.tcl index 375e6ba..09eac6e 100644 --- a/tcl/JobDB-Standalone.tcl +++ b/tcl/JobDB-Standalone.tcl @@ -57,7 +57,7 @@ proc read-runvar {flight job name {val {}}} { return $val } -proc job-check-escaped-steps {flight job} { } +proc job-check-escaped-steps {flight job} { return 0 } proc ensure-db-open {} { global c