From patchwork Mon Nov 21 21:28:48 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Rzeszutek Wilk X-Patchwork-Id: 9439921 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3FC3C60469 for ; Mon, 21 Nov 2016 18:22:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2859B28755 for ; Mon, 21 Nov 2016 18:22:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1B3852876F; Mon, 21 Nov 2016 18:22:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=2.0 tests=BAYES_00, DATE_IN_FUTURE_03_06, DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=no version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7980A28755 for ; Mon, 21 Nov 2016 18:22:10 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c8tBs-0001Ef-QZ; Mon, 21 Nov 2016 18:19:40 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c8tBr-0001EZ-GJ for xen-devel@lists.xenproject.org; Mon, 21 Nov 2016 18:19:39 +0000 Received: from [85.158.137.68] by server-4.bemta-3.messagelabs.com id CF/6B-20885-ABA33385; Mon, 21 Nov 2016 18:19:38 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrFIsWRWlGSWpSXmKPExsVyMfTGYd2dVsY RBs/uWVp83zKZyYHR4/CHKywBjFGsmXlJ+RUJrBlzfjxmLDgmUXFo4Uq2Bsbzwl2MnBxCAjMZ JZZt4AWxWQSWsUq8m53UxcjFISFwiFViwe75TCAJCYEYifdXHjJD2NUSy2ceZoFoVpLYMvkxI 0iDkMBmJonLp/+wgiSEBfQkJn+7DZTgAJqqKtFxKwgkzCagL/F07TWwOSIC2hIvVq1jAylhFi iQOPJDCcQUFiiU+NjEDlLBK2Al8fnpUqjp3xgltk26B5UQlDg58wnYCcwCWhI3/r1kghgjLbH 8HwdImFPAQeLchrWMILaogIrElQlv2ScwisxC0j0LSfcshO4FjMyrGNWLU4vKUot0DfWSijLT M0pyEzNzdA0NjPVyU4uLE9NTcxKTivWS83M3MQLDngEIdjAu/+h0iFGSg0lJlPfwUqMIIb6k/ JTKjMTijPii0pzU4kOMMhwcShK8eyyNI4QEi1LTUyvSMnOAEQiTluDgURLhbQJJ8xYXJOYWZ6 ZDpE4xWnK8+vDiARPHm10vgWTHhw8PmIRY8vLzUqXEeS1AGgRAGjJK8+DGwZLEJUZZKWFeRqA DhXgKUotyM0tQ5V8xinMwKgnzNoJM4cnMK4Hb+groICagg5RYDUAOKklESEk1MGbeTEiOreVv na8QLpeRm3bh6i2LxIjLfNemqP874frp36efP153n9EVyLBKnTWlVUszMHNdxfe1T87l/5/8o 6JOSbLI31mq9jqzrQ//udMutm8es13pqxafa3u99IrbTn7OfB7dlx039rScXt93X/F+cdIHq9 81Mbx3Qhjnubx/0aV0Jcz+mBJLcUaioRZzUXEiAAryUncNAwAA X-Env-Sender: ketuzsezr@gmail.com X-Msg-Ref: server-2.tower-31.messagelabs.com!1479752376!60450423!1 X-Originating-IP: [209.85.216.195] X-SpamReason: No, hits=2.1 required=7.0 tests=DATE_IN_FUTURE_03_06 X-StarScan-Received: X-StarScan-Version: 9.0.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 14901 invoked from network); 21 Nov 2016 18:19:37 -0000 Received: from mail-qt0-f195.google.com (HELO mail-qt0-f195.google.com) (209.85.216.195) by server-2.tower-31.messagelabs.com with AES128-GCM-SHA256 encrypted SMTP; 21 Nov 2016 18:19:37 -0000 Received: by mail-qt0-f195.google.com with SMTP id n34so26495794qtb.3 for ; Mon, 21 Nov 2016 10:19:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=cZNO99Pjl+mU8lXcB57G6RtkO78jeggJ5dloaRCBiFE=; b=RNPdhSqpqRpcGDj2b+I0ErYU3yWBevhHJ0ywEJrI3qdJgCMn1yeoCmBpQPTIYeE0Hr IcWtpHFaPr82C/lbd6YXWbPdZHWn7GpFknlHK+qrJiLTqkap6ePedbNjxr9zvP4H/W/O bULm9UV6zOfNIr9+KaLUH7UvWNvjvsGic/hpR1gPOsdn4lgzb3Ft/Z8XowRdKNdWeM5W Ib4wUTmoqFUtgmtBQtfW3tX6vYoQ2OA3Zd2kgFg3aQfr4UvNjug9qe/7JieamybaG2Zc r9sfMoVUvIYZVMHx5Byc0G4BpuFGSw/iffwugF4bsTfbMGkHlTHNK6uMNpDnr2bwXn8e R8mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=cZNO99Pjl+mU8lXcB57G6RtkO78jeggJ5dloaRCBiFE=; b=FvTcll+9UhTBUYZ/Vxo1u8YM7gyWR7BIjPHqmAoFmFhso2ggjxtYI1CS/83QsQ2IWP b3ItjFe+zqZarQkqN4n34Utz1tI7UKDYbOw7CHq5fW6SMlzU16M1ih5K7cRBY1g9Wq65 yYG8ugyPsNchsiVdp4+9oWCIaqu3kOFnc6fFjCs2JCO0Z/QZ0uQ8Ik4M0357EsVNiQ+/ YRYcLYlYqQox6pM6vAj5l2bt7/aS75N5dU6pH/X+AG3TPu9kLgYxrWuM6NFPA6WFm5ih ndTa+UJJal3M7WjezBVrXKCtY4+zZXUJii3XmbsmBYA/0Va/R/9YpdjZFtDbropifS4a rBLQ== X-Gm-Message-State: AKaTC02Tssa9z5HSY7rITdRrjrvdpAVHAd5QJDFVDbJEK2X71SacKRuWIC/p75Gsv+0bPQ== X-Received: by 10.237.36.114 with SMTP id s47mr10028650qtc.221.1479752376602; Mon, 21 Nov 2016 10:19:36 -0800 (PST) Received: from osstest.dumpdata.com (209-6-196-81.c3-0.smr-ubr2.sbo-smr.ma.cable.rcn.com. [209.6.196.81]) by smtp.gmail.com with ESMTPSA id h47sm11818448qtc.27.2016.11.21.10.19.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Nov 2016 10:19:36 -0800 (PST) Date: Mon, 21 Nov 2016 16:28:48 -0500 From: Konrad Rzeszutek Wilk To: Ian Jackson Message-ID: <20161121212846.GA126025@osstest.dumpdata.com> References: <1479346630-122644-1-git-send-email-konrad.wilk@oracle.com> <1479346630-122644-3-git-send-email-konrad.wilk@oracle.com> <1479346630-122644-4-git-send-email-konrad.wilk@oracle.com> <22573.39231.91977.537159@mariner.uk.xensource.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <22573.39231.91977.537159@mariner.uk.xensource.com> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: xen-devel@lists.xenproject.org, Marcos.Matsunaga@oracle.com Subject: Re: [Xen-devel] [PATCH v1 3/7] ts-xen-build: Install livepatch regressions tests. [and 1 more messages] X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP On Thu, Nov 17, 2016 at 11:49:19AM +0000, Ian Jackson wrote: > Konrad Rzeszutek Wilk writes ("[PATCH v1 3/7] ts-xen-build: Install livepatch regressions tests."): > > That come with the Xen git tree (see xen/test/). > > I think this and the "build them" patch should be combined. > > > + buildcmd_stamped_logged(600, 'xen', 'tests-install', '',< > Can you keep the lines down to 75 characters or less please ? > > > + if test -d xen/test; then > > + mkdir -p dist/install/usr/lib/debug > > + livepatch_files=`find xen/test/livepatch -name '*.livepatch' -print` > > + cp \$livepatch_files dist/install/usr/lib/debug > > Should this not be in the xen.git Makefiles ? Jan didn't like it (as part of the normal 'install' stanza). I could add it in xen/test/Makefile, but I had a hard time executing anything inside 'xen' sub-directories by themselves, aka: make -C xen/test install As the 'xen/test/livepatch/Makefile' does: include $(XEN_ROOT)/Config.mk (and other) and the XEN_ROOT is not available unless you run it from within 'xen' directory. Which means I would have to add a new top-level target, such as: make -C xen test_install or such. But then it is not exactly sure where one would install the "tests"? /usr/lib/debug? /usr/lib/xen/debug/ ? I figured it would be easier if it was left unimplemented and folks just copied the files out of there. > > Also, the result of this is that the tests end up in the tools output > because you haven't fixed `divide'. Background: each osstest > invocation of ts-xen-build produces two primary deliverables: `' and > `xen' aka `dist' and `xendist'. > > I think, but I'm not sure, that these patches contain hypervisor code > and should be in `xendist'. In the cover letter you mentioned that it may be good to have an xenlptdist.tar.gz which would only contain the livepatch test-cases. And then we could use the existence of that file as a check for the hypervisor having the support? If I squash this patch in this one: It should in theory (testing it now) do the right thing. Now just need to figure out how to gate the execution of ts-livepatch on the existence of that file (in a non-hackish way). > > Thanks, > Ian. > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > https://lists.xen.org/xen-devel diff --git a/ts-xen-build b/ts-xen-build index 1b36b9c..1137947 100755 --- a/ts-xen-build +++ b/ts-xen-build @@ -170,11 +170,11 @@ END $make_prefix make -C xen tests fi END - buildcmd_stamped_logged(600, 'xen', 'tests-install', '',<