From patchwork Wed Nov 23 02:36:43 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Rzeszutek Wilk X-Patchwork-Id: 9442495 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EED6260237 for ; Wed, 23 Nov 2016 02:39:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E23632074F for ; Wed, 23 Nov 2016 02:39:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D72D924560; Wed, 23 Nov 2016 02:39:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RCVD_IN_SORBS_SPAM,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 767062074F for ; Wed, 23 Nov 2016 02:39:18 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c9NQf-00067f-Gm; Wed, 23 Nov 2016 02:36:57 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c9NQe-00067H-II for xen-devel@lists.xenproject.org; Wed, 23 Nov 2016 02:36:56 +0000 Received: from [85.158.137.68] by server-8.bemta-3.messagelabs.com id AF/DB-26755-7C005385; Wed, 23 Nov 2016 02:36:55 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrAIsWRWlGSWpSXmKPExsVyMfTOId3jDKY RBpeXcFt83zKZyYHR4/CHKywBjFGsmXlJ+RUJrBm/P19gK9jJVdH1exJTA+MT9i5GLg4hgemM EnfO/gRzWAQ+sEgc3/yQsYuRk0NCYBqrRNuEdAg7RuLF/ZdMEHaVxPT7P1lAbCEBJYktkx8zQ ky6wSRx+vVcVpCEsICexORvt8EGsQnoSzxde40ZxBYBine//gpWwyzgJzHl+EZ2iPo4iUVHZr F1MXIAXaEqcfiZG0iYV8BUYveFk+wQe+UkLm37AjaGU8BMYvXvFywg5UICGRJTb6RPYBRcwMi wilGjOLWoLLVI19hAL6koMz2jJDcxM0fX0MBYLze1uDgxPTUnMalYLzk/dxMjMNzqGRgYdzB2 nvA7xCjJwaQkynt4qVGEEF9SfkplRmJxRnxRaU5q8SFGGQ4OJQnehv8mEUKCRanpqRVpmTnAw IdJS3DwKInwBoCkeYsLEnOLM9MhUqcYjTlefXjxgImj48OHB0xCLHn5ealS4rzmIKUCIKUZpX lwg2AReYlRVkqYl5GBgUGIpyC1KDezBFX+FaM4B6OSMK8fyBSezLwSuH2vgE5hAjpF8psxyCk liQgpqQZGfcG3UTJC4RahRqYT/DW+F2XeP52veiPr4N3AGUs5d01vmOl0wsVxsYhQ3aaZ0pY3 Dm1bsnpZJnOLQM8El/dzpy66Oadn0qKtxYEfNu+7YOvJuczpTtysyiWh5uFmlkd/7NS/6rDZS OqDw1uOvIyzt48f8t//cTq/2VZhBu1cvm88h38m9vf+VGIpzkg01GIuKk4EABmABTHDAgAA X-Env-Sender: ketuzsezr@gmail.com X-Msg-Ref: server-16.tower-31.messagelabs.com!1479868614!64783372!1 X-Originating-IP: [209.85.220.194] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.0.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 43176 invoked from network); 23 Nov 2016 02:36:55 -0000 Received: from mail-qk0-f194.google.com (HELO mail-qk0-f194.google.com) (209.85.220.194) by server-16.tower-31.messagelabs.com with AES128-GCM-SHA256 encrypted SMTP; 23 Nov 2016 02:36:55 -0000 Received: by mail-qk0-f194.google.com with SMTP id y205so14553qkb.1 for ; Tue, 22 Nov 2016 18:36:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=SsGIRsX+NlZKF8ZrFd4q7dP3bO+vvYs7IaEhGLs9gTA=; b=p94Wl17B5iI1+mNwjxrAq/nW6VBRJS6XO28OLsrRJKkNW5FlrJPuVH08a4YfHISZF2 fua3hBLstR91KjF+/s6pGoNHQZhf4lFwSeZblsTrDsyLdQNfQVbi2IuG064d7MjvhmCs 6VRw2WQbYUDjE1rZ6XnJliPaImDkHwmHmC1F9+HimbIGfrJpkDuLUFBP9QsMmp153c6R 6kGHCCs+NVvtstU2DGch0BbA/tWQqn3XcM6jLWGoGkUW5fyMOxystUqLGcufUdBLl8RK knC/IBs/vxEheis2FmxUuSr3IPcgcgqt599sNrTrSAEPqkwlPaYy4WkvKZaTT9CBAGLR D3iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=SsGIRsX+NlZKF8ZrFd4q7dP3bO+vvYs7IaEhGLs9gTA=; b=lY1KApJO/cej/Nl2qlM6DAmKhpnXHrdyjJHhuCXjHFPEAZcMdAWmbsSJbf+xyXeE0V UEp5n0jtdoihyOAQ25zgWAVIz+vI2OpcjLWoDR9EnfwZLkj2SH1i/d5UaWDiqDYbUIhx kIXqX0VloWXLwoWbvKZ2nLyb3CCQ2yFTXmfIYADtbraoUa+sqHqrfYNkUVtrNVRLRmmg 697vPGVCPsTaH94XrOs4hEMHeqCVxYT2R2twUvlR3vyOawEh+gSV5TjVQBd4vwq/gdVG JEfu+GvxUqPMYA9jTKZEK7MD13TsH3eMdsc896i/1O7bHWr43+J+z+Xq0npTtYObehsE QH/A== X-Gm-Message-State: AKaTC02VIqzHE28NZCB9agzpeJcQB85HO3W8OjYrwWgM+FMS/A4GNPau/xuEKS/wD+l4sg== X-Received: by 10.55.176.131 with SMTP id z125mr668113qke.286.1479868613930; Tue, 22 Nov 2016 18:36:53 -0800 (PST) Received: from dhcp-adc-twvpn-3-vpnpool-10-154-104-253.vpn.oracle.com.com (209-6-196-81.c3-0.smr-ubr2.sbo-smr.ma.cable.rcn.com. [209.6.196.81]) by smtp.gmail.com with ESMTPSA id 14sm15258473qtp.19.2016.11.22.18.36.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Nov 2016 18:36:53 -0800 (PST) From: Konrad Rzeszutek Wilk To: lersek@redhat.com, edk2-devel@ml01.01.org Date: Tue, 22 Nov 2016 21:36:43 -0500 Message-Id: <20161123023643.7106-2-konrad@kernel.org> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20161123023643.7106-1-konrad@kernel.org> References: <9faa1698-7471-3f47-e552-8da23c0f0195@redhat.com> <20161123023643.7106-1-konrad@kernel.org> Cc: xen-devel@lists.xenproject.org, Konrad Rzeszutek Wilk Subject: [Xen-devel] [PATCH v2] OvmfPkg/build.sh: Make GCC5 the default toolchain, catch GCC43 and earlier X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP From Laszlo: " change the catch-all (*) to GCC5, from GCC44 - remove the (5.*.*) pattern from GCC49 - add a branch (with multiple patterns if necessary) for gcc-4.3 and earlier to exit with an error message / failure (those compiler versions are unsupported)" Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=62 Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Konrad Rzeszutek Wilk Reviewed-by: Laszlo Ersek --- v1: First submission v2: Redo it per Laszlo suggestion. OvmfPkg/build.sh | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh index eb5eb73..cab7c70 100755 --- a/OvmfPkg/build.sh +++ b/OvmfPkg/build.sh @@ -83,6 +83,13 @@ case `uname` in Linux*) gcc_version=$(gcc -v 2>&1 | tail -1 | awk '{print $3}') case $gcc_version in + 4.1.[0-0].*|4.2.*|4.3.*) + echo OvmfPkg requires GCC4.4 or later + exit 1 + ;; + 4.4.*) + TARGET_TOOLS=GCC44 + ;; 4.5.*) TARGET_TOOLS=GCC45 ;; @@ -95,11 +102,11 @@ case `uname` in 4.8.*) TARGET_TOOLS=GCC48 ;; - 4.9.*|4.1[0-9].*|5.*.*) + 4.9.*) TARGET_TOOLS=GCC49 ;; *) - TARGET_TOOLS=GCC44 + TARGET_TOOLS=GCC5 ;; esac esac