From patchwork Thu Dec 15 17:17:55 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Borislav Petkov X-Patchwork-Id: 9476575 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 50A9760571 for ; Thu, 15 Dec 2016 17:20:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4159E287E3 for ; Thu, 15 Dec 2016 17:20:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3622B287E7; Thu, 15 Dec 2016 17:20:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B437C287E3 for ; Thu, 15 Dec 2016 17:20:43 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cHZfh-0004b8-15; Thu, 15 Dec 2016 17:18:21 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cHZfg-0004b2-Kf for xen-devel@lists.xenproject.org; Thu, 15 Dec 2016 17:18:20 +0000 Received: from [85.158.143.35] by server-5.bemta-6.messagelabs.com id B4/11-11476-B50D2585; Thu, 15 Dec 2016 17:18:19 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrFIsWRWlGSWpSXmKPExsVyuP0Ov270haA Ig9dPpS2+b5nM5MDocfjDFZYAxijWzLyk/IoE1ozVX3vZC16yV0xbspapgXEnWxcjJ4eEgJHE 24n/mLoYuTiEBBYySsy59Jili5EDyEmX2NmiBGKyCKhK7PknClLOJqAk8fvTOnYQW0TAQOL99 UlsIK3MAt2MEq0HLrOC1AsLWElsfp0GUsMrYCrx8es2RojxMxkltrT9YYFICEqcnPkEzGYWUJ f4M+8SM0gvs4C0xPJ/HBBheYnmrbOZQWxOATuJ79e3MYHYogIqErMuz2GZwCgwC8mkWUgmzUK YNAvJpAWMLKsY1YtTi8pSi3SN9ZKKMtMzSnITM3N0DQ3M9HJTi4sT01NzEpOK9ZLzczcxAsOV AQh2MHb8czrEKMnBpCTKm708KEKILyk/pTIjsTgjvqg0J7X4EKMGB4fA5rWrLzBKseTl56UqS fAKnweqEyxKTU+tSMvMAUYUTKkEB4+SCK8QSJq3uCAxtzgzHSJ1ilFRSpxXDyQhAJLIKM2Da4 NF8SVGWSlhXkago4R4ClKLcjNLUOVfMYpzMCoJ8345BzSFJzOvBG76K6DFTECLRZf4gywuSUR ISTUwWjovj166MVU2brd6+LmZTT9e1Tn0SnufvvVNQerK/pn/mzvc5uvGaNqw77IpuWfJfvXY PpPpJQpqG479yORocn3AL7lk1expQbs0KmLa5jse/7A1vXFb9pc11vsNJx5L6vPOFGTqfuSpK 8UmZTTx4Dz5g4lm7rM/yjwQXOpVOfORj3O4MNsCJZbijERDLeai4kQAZHovht0CAAA= X-Env-Sender: bp@suse.de X-Msg-Ref: server-15.tower-21.messagelabs.com!1481822298!48373558!1 X-Originating-IP: [195.135.220.15] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.1.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 2509 invoked from network); 15 Dec 2016 17:18:19 -0000 Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by server-15.tower-21.messagelabs.com with DHE-RSA-CAMELLIA256-SHA encrypted SMTP; 15 Dec 2016 17:18:19 -0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 6B19FAE08; Thu, 15 Dec 2016 17:17:57 +0000 (UTC) Received: by pd.tnic (Postfix, from userid 1000) id C645B160EE6; Thu, 15 Dec 2016 18:17:55 +0100 (CET) Date: Thu, 15 Dec 2016 18:17:55 +0100 From: Borislav Petkov To: Boris Ostrovsky Message-ID: <20161215171755.xpfuax7a6q3jofet@pd.tnic> References: <73a4d64b-b139-6579-a560-92311641d6c7@suse.com> <20161215164635.thm7ruio2ddnxszw@pd.tnic> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20161014 (1.7.1) Cc: Juergen Gross , xen-devel , Linux Kernel Mailing List Subject: Re: [Xen-devel] Can't boot as Xen dom0 due to commit fe055896 X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP On Thu, Dec 15, 2016 at 12:00:22PM -0500, Boris Ostrovsky wrote: > There is an error on AMD as well. We end up being called at > load_microcode_amd() with size=0 and crash soon after. Does that fix it? > (As a side note, I think verify_and_add_patch() should return error > codes and not crnt_size, which may be a positive number. Which it was in > my case.) It does return negative values when there's some failure. It returns crnt_size which can be a positive number so that we can advance to the next patch in the blob. diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index dd47e60aabf5..e238119b5dff 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -1202,6 +1202,7 @@ config X86_REBOOTFIXUPS config MICROCODE bool "CPU microcode loading support" default y + depends on !XEN depends on CPU_SUP_AMD || CPU_SUP_INTEL select FW_LOADER ---help---