From patchwork Tue Dec 20 16:05:42 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Rzeszutek Wilk X-Patchwork-Id: 9481741 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B16C7606DB for ; Tue, 20 Dec 2016 16:08:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A13A12841B for ; Tue, 20 Dec 2016 16:08:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 947B628486; Tue, 20 Dec 2016 16:08:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 178AF2841B for ; Tue, 20 Dec 2016 16:08:48 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cJMvQ-0005Im-RK; Tue, 20 Dec 2016 16:06:00 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cJMvP-0005If-Ny for xen-devel@lists.xenproject.org; Tue, 20 Dec 2016 16:05:59 +0000 Received: from [193.109.254.147] by server-10.bemta-6.messagelabs.com id 0D/E8-13192-7E659585; Tue, 20 Dec 2016 16:05:59 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrNIsWRWlGSWpSXmKPExsUyZ7p8oO6zsMg Ig1m/NSy+b5nM5MDocfjDFZYAxijWzLyk/IoE1oyJvV+ZCz6xV/ScWsPcwLibrYuRi0NIYDKT xJSGZnYI5zejxL9z35kgnI2MEk/nNbBCON2MEjMOLQXKcAI5RRL3Hr9iBbFZBFQlHs1ZwdzFy MHBJmAi8WaVI0hYREBNYvHCLywgvcwCFxklLjy8zgiSEBbwlViy/jaYzStgLrHr3USoBW8YJe b92c8EkRCUODnzCQuIzSygJXHj30smkAXMAtISy/9xgIQ5Bewk+rsvMoPYogLKEn8P3wMrlxA wlmh/e5FtAqPQLCSTZiGZNAth0gJG5lWM6sWpRWWpRbpGeklFmekZJbmJmTm6hgZmermpxcWJ 6ak5iUnFesn5uZsYgQHNAAQ7GJf9dTrEKMnBpCTKeyA4MkKILyk/pTIjsTgjvqg0J7X4EKMMB 4eSBO+eUKCcYFFqempFWmYOMLZg0hIcPEoivN9A0rzFBYm5xZnpEKlTjLoc054tfsokxJKXn5 cqJc7bCVIkAFKUUZoHNwIW55cYZaWEeRmBjhLiKUgtys0sQZV/xSjOwagkzHsCZApPZl4J3KZ XQEcwAR2xsDsc5IiSRISUVAOjs8F35ag0mZDS54c3Xgj9kpdW95T53CTuq7UbZa9zmORt8zpR UH9cP8Lm+hKF+tgctY1+c06pRpj8jl6YffVajvTTd9+m1RndNt1+XG/lyZ6A836bvvpKJof8X Hoh3cbVbXGBr/9am5M8e2f8ONInuuzlIyPf5VGPDR61+cdP33fo6Oe+PQeklFiKMxINtZiLih MBKvDK1+4CAAA= X-Env-Sender: konrad.wilk@oracle.com X-Msg-Ref: server-11.tower-27.messagelabs.com!1482249956!47900368!1 X-Originating-IP: [156.151.31.81] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogMTU2LjE1MS4zMS44MSA9PiAyODgzMzk=\n X-StarScan-Received: X-StarScan-Version: 9.1.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 37404 invoked from network); 20 Dec 2016 16:05:58 -0000 Received: from userp1040.oracle.com (HELO userp1040.oracle.com) (156.151.31.81) by server-11.tower-27.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 20 Dec 2016 16:05:58 -0000 Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id uBKG5lQK021594 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 20 Dec 2016 16:05:48 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id uBKG5kjq008799 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 20 Dec 2016 16:05:47 GMT Received: from abhmp0015.oracle.com (abhmp0015.oracle.com [141.146.116.21]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id uBKG5hEi013131; Tue, 20 Dec 2016 16:05:43 GMT Received: from char.us.oracle.com (/10.137.176.158) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 20 Dec 2016 08:05:43 -0800 Received: by char.us.oracle.com (Postfix, from userid 1000) id 73E1E6A00EB; Tue, 20 Dec 2016 11:05:42 -0500 (EST) Date: Tue, 20 Dec 2016 11:05:42 -0500 From: Konrad Rzeszutek Wilk To: Doug Goldstein Message-ID: <20161220160542.GI10069@char.us.oracle.com> References: <1481928967-4130-1-git-send-email-alistair.francis@xilinx.com> <1481928967-4130-2-git-send-email-alistair.francis@xilinx.com> <20161217155135.GC2267@localhost.localdomain> <6bd7ad0b-f835-e2d8-a459-8ded9cb1c54f@cardoe.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6bd7ad0b-f835-e2d8-a459-8ded9cb1c54f@cardoe.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Cc: wei.liu2@citrix.com, ian.jackson@eu.citrix.com, Alistair Francis , imhy.yang@gmail.com, xen-devel@lists.xenproject.org, rshriram@cs.ubc.ca, alistair23@gmail.com Subject: Re: [Xen-devel] [PATCH 1/7] Remove hardcoded strict -Werror checking X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP On Mon, Dec 19, 2016 at 09:53:02PM -0600, Doug Goldstein wrote: > On 12/17/16 9:51 AM, Konrad Rzeszutek Wilk wrote: > > On Fri, Dec 16, 2016 at 02:56:01PM -0800, Alistair Francis wrote: > >> Signed-off-by: Alistair Francis > > > > > > Why? > > *adjusts his distro maintainer hat* It's considered really bad form for > upstreams to push -Werror in their projects. However I know there's > upstream interest to keep it. The compromise would probably be to get my > rear in gear and get a wider range of distros testing with Travis CI / > GitLab CI. So.. why not do something like this: And have the BuildRoot script do something like: EXTRA_CFLAGS=$(CFLAGS) unset CFLAGS make -C xen ? > > -- > Doug Goldstein > diff --git a/config/StdGNU.mk b/config/StdGNU.mk index 6be8233..fd2d5b9 100644 --- a/config/StdGNU.mk +++ b/config/StdGNU.mk @@ -39,3 +39,5 @@ ifeq ($(lto),y) CFLAGS += -flto LDFLAGS-$(clang) += -plugin LLVMgold.so endif + +CFLAGS += $(EXTRA_CFLAGS)