From patchwork Tue Apr 4 19:10:16 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Rzeszutek Wilk X-Patchwork-Id: 9662455 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3F0C76032D for ; Tue, 4 Apr 2017 19:12:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 32AFA26B39 for ; Tue, 4 Apr 2017 19:12:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 27A3028549; Tue, 4 Apr 2017 19:12:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 5E6E426B39 for ; Tue, 4 Apr 2017 19:12:54 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cvTqj-0007mi-VY; Tue, 04 Apr 2017 19:10:41 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cvTqi-0007mN-Mf for xen-devel@lists.xenproject.org; Tue, 04 Apr 2017 19:10:40 +0000 Received: from [85.158.137.68] by server-8.bemta-3.messagelabs.com id 2C/DC-00609-FAFE3E85; Tue, 04 Apr 2017 19:10:39 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpnkeJIrShJLcpLzFFi42KZM10+UHf9+8c RBhs+KVl83zKZyYHR4/CHKywBjFGsmXlJ+RUJrBnPFt1gLPjMUTHjwm/2BsbtbF2MXBxCApOY JJ70XWOBcL4ySiy/eIMRwtnAKHGu9wAzhNPHKNG77ihrFyMHB5uAicSbVY5djJwcIgJKEvdWT WYCsZkFJjNKvFshBGILCzhIbLx2HCzOIqAqcXJCHyuIzStgLXHo3k+wuISAnMSlbV+YQUZyCt hI/F9SBhIWAirZPnUPK0SJsUT724tsExj5FjAyrGLUKE4tKkst0jUy1EsqykzPKMlNzMzRNTQ w1stNLS5OTE/NSUwq1kvOz93ECAyUegYGxh2MPXv9DjFKcjApifIy3nwcIcSXlJ9SmZFYnBFf VJqTWnyIUYaDQ0mC9+g7oJxgUWp6akVaZg4wZGHSEhw8SiK8d0DSvMUFibnFmekQqVOMuhxzZ u9+wyTEkpeflyolznsKpEgApCijNA9uBCx+LjHKSgnzMjIwMAjxFKQW5WaWoMq/YhTnYFQS5v 0JMoUnM68EbtMroCOYgI54cuchyBEliQgpqQbGTeFeTm4bnwnuFQnT/R29ffnf5nfbXyjUhie Xqp5z6EzoPJnu9ej/5vdzV956sjrdYaLdlnB2/76Ghy/zGAtWZgUnn9ZNvLLs6DLp6NcF92Yd kt83IZ81XtyZ913nmb9WN/IF1zZmnLy3aF100uM1P5n6Tqc2c0l2C6sXZtq8/mTx/Wf8opsXl FiKMxINtZiLihMBvKIQS5oCAAA= X-Env-Sender: konrad.wilk@oracle.com X-Msg-Ref: server-14.tower-31.messagelabs.com!1491333037!94124649!1 X-Originating-IP: [156.151.31.81] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogMTU2LjE1MS4zMS44MSA9PiAyODgzMzk=\n X-StarScan-Received: X-StarScan-Version: 9.2.3; banners=-,-,- X-VirusChecked: Checked Received: (qmail 58240 invoked from network); 4 Apr 2017 19:10:39 -0000 Received: from userp1040.oracle.com (HELO userp1040.oracle.com) (156.151.31.81) by server-14.tower-31.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 4 Apr 2017 19:10:39 -0000 Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id v34JAXeI021331 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 4 Apr 2017 19:10:33 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id v34JAWFE008147 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 4 Apr 2017 19:10:33 GMT Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id v34JAUwE014234; Tue, 4 Apr 2017 19:10:31 GMT Received: from x230.dumpdata.com.com (/10.154.163.250) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 04 Apr 2017 12:10:30 -0700 From: Konrad Rzeszutek Wilk To: xen-devel@lists.xenproject.org Date: Tue, 4 Apr 2017 15:10:16 -0400 Message-Id: <20170404191017.19584-5-konrad.wilk@oracle.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170404191017.19584-1-konrad.wilk@oracle.com> References: <20170404191017.19584-1-konrad.wilk@oracle.com> X-Source-IP: aserv0022.oracle.com [141.146.126.234] Cc: Ian Jackson , wei.liu2@citrix.com, jbeulich@suse.com, Konrad Rzeszutek Wilk Subject: [Xen-devel] [PATCH v2 4/5] tmem: Fix tmem-shared-auth 'auth' values X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP The hypervisor code (tmemc_shared_pool_auth) since the inception would consider auth values of: 0 - to disable authentication! 1 - to enable authentication for the given UUID. The docs have it the other way around, so lets fix it. Acked-by: Wei Liu Signed-off-by: Konrad Rzeszutek Wilk --- Cc: Ian Jackson Cc: Wei Liu -- v2: Added Wei's Ack. --- tools/xl/xl_cmdtable.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/xl/xl_cmdtable.c b/tools/xl/xl_cmdtable.c index 7d97811..30eb93c 100644 --- a/tools/xl/xl_cmdtable.c +++ b/tools/xl/xl_cmdtable.c @@ -416,7 +416,7 @@ struct cmd_spec cmd_table[] = { " -a Authenticate for all tmem pools\n" " -u UUID Specify uuid\n" " (abcdef01-2345-6789-1234-567890abcdef)\n" - " -A AUTH 0=auth,1=deauth", + " -A AUTH 0=deauth,1=auth", }, { "tmem-freeable", &main_tmem_freeable, 0, 0,