From patchwork Wed Apr 5 13:38:04 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adrian Pop X-Patchwork-Id: 9664123 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2FD79602B5 for ; Wed, 5 Apr 2017 13:40:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1A478284DB for ; Wed, 5 Apr 2017 13:40:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0F2992852E; Wed, 5 Apr 2017 13:40:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9C0C9284DB for ; Wed, 5 Apr 2017 13:40:26 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cvl8l-0004Dg-N4; Wed, 05 Apr 2017 13:38:27 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cvl8j-0004CV-Gb for xen-devel@lists.xenproject.org; Wed, 05 Apr 2017 13:38:25 +0000 Received: from [193.109.254.147] by server-7.bemta-6.messagelabs.com id 61/CF-04817-053F4E85; Wed, 05 Apr 2017 13:38:24 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrOIsWRWlGSWpSXmKPExsUSfTxjoW7A5yc RBvveill83zKZyYHR4/CHKywBjFGsmXlJ+RUJrBn/TyxjK2jkrPi/6SpbA+Nm9i5GTg4hAXeJ U4+agWwuIHsNo8TmbR9ZIJy7jBKd56YxdzFyADluEkfvRUHEdzFKPLx+hA2km01AXWLz3i2sI LaIgJLEvVWTmUCKmAVOMEl0dmwBKxIWCJHYe+UfmM0ioCrxYm4nE4jNK2Ap0Xz1JNgZEgLyEo 82PQKr4RSwkpjQfoYZ4jxLifabc1kganIktna8YQM5SEJASuJ/qxJEuJdForMzB8KWkXg08Sb bBEahBYwMqxg1ilOLylKLdI3M9JKKMtMzSnITM3N0DQ3M9HJTi4sT01NzEpOK9ZLzczcxAgOR AQh2MJ5ZEHiIUZKDSUmUV8HnSYQQX1J+SmVGYnFGfFFpTmrxIUYZDg4lCV6Lj0A5waLU9NSKt MwcYEzApCU4eJREeBU/AaV5iwsSc4sz0yFSpxh1OXr+7X7DJMSSl5+XKiXOqwNSJABSlFGaBz cCFp+XGGWlhHkZgY4S4ilILcrNLEGVf8UozsGoJMw7E2QKT2ZeCdymV0BHMAEd8eTOQ5AjShI RUlINjMf6F+sF3Xj4W+Ppyn5+poILR3Xn707b4vzeMyXwVN6MWw1dFnN1oxrmZLf+sfxoUXHz 8tVVMbofA9da3p1lPmtLVLPFEqecb8L79Z3qz03wLMgoWyn0XGA9183JBmp3DRdebXqjeDA2R Xamzonrqrv5RXhSXuZHBRULKeq0/OAp7Kju+LGxR4mlOCPRUIu5qDgRABTjsg/KAgAA X-Env-Sender: apop@bitdefender.com X-Msg-Ref: server-16.tower-27.messagelabs.com!1491399503!95481597!1 X-Originating-IP: [91.199.104.161] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.4.12; banners=-,-,- X-VirusChecked: Checked Received: (qmail 14514 invoked from network); 5 Apr 2017 13:38:24 -0000 Received: from mx01.bbu.dsd.mx.bitdefender.com (HELO mx01.bbu.dsd.mx.bitdefender.com) (91.199.104.161) by server-16.tower-27.messagelabs.com with DHE-RSA-AES128-GCM-SHA256 encrypted SMTP; 5 Apr 2017 13:38:24 -0000 Received: (qmail 23693 invoked from network); 5 Apr 2017 16:38:23 +0300 Received: from unknown (HELO mx-sr.buh.bitdefender.com) (10.17.80.103) by mx01.bbu.dsd.mx.bitdefender.com with AES256-GCM-SHA384 encrypted SMTP; 5 Apr 2017 16:38:23 +0300 Received: from smtp02.buh.bitdefender.net (smtp.bitdefender.biz [10.17.80.76]) by mx-sr.buh.bitdefender.com (Postfix) with ESMTP id 236417FC40 for ; Wed, 5 Apr 2017 16:38:23 +0300 (EEST) Received: (qmail 3378 invoked from network); 5 Apr 2017 16:38:23 +0300 Received: from unknown (HELO hel.clj.bitdefender.biz) (apop@bitdefender.com@10.220.12.75) by smtp02.buh.bitdefender.net with AES128-GCM-SHA256 encrypted SMTP; 5 Apr 2017 16:38:23 +0300 From: Adrian Pop To: xen-devel@lists.xenproject.org Date: Wed, 5 Apr 2017 16:38:04 +0300 Message-Id: <20170405133806.11022-2-apop@bitdefender.com> X-Mailer: git-send-email 2.12.1 In-Reply-To: <20170405133806.11022-1-apop@bitdefender.com> References: <20170405133806.11022-1-apop@bitdefender.com> X-BitDefender-Scanner: Clean, Agent: BitDefender qmail 3.1.6 on smtp02.buh.bitdefender.net, sigver: 7.70632 X-BitDefender-Spam: No (0) X-BitDefender-SpamStamp: Build: [Engines: 2.15.8.1074, Dats: 445324, Stamp: 3], Multi: [Enabled, t: (0.000008, 0.003957)], BW: [Enabled, t: (0.000007)], RBL DNSBL: [Disabled], APM: [Enabled, Score: 500, t: (0.002240), Flags: 85D2ED72; NN_NO_CONTENT_TYPE; NN_NO_LINK_NMD; NN_LEGIT_BITDEFENDER; NN_LEGIT_S_SQARE_BRACKETS; NN_LEGIT_MAILING_LIST_TO], SGN: [Enabled, t: (0.008658,0.000044)], URL: [Enabled, t: (0.000005)], RTDA: [Enabled, t: (0.056570), Hit: No, Details: v2.4.6; Id: 11.5eu282.1bcsfmvr0.sfi5], total: 0(775) X-BitDefender-CF-Stamp: none Cc: Tamas K Lengyel , Wei Liu , Razvan Cojocaru , George Dunlap , Andrew Cooper , Ian Jackson , Jan Beulich , Vlad Ioan Topan Subject: [Xen-devel] [RFC 1/3] x86/mm: Change default value for suppress #VE in set_mem_access() X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Vlad Ioan Topan The default value for the "suppress #VE" bit set by set_mem_access() currently depends on whether the call is made from the same domain (the bit is set when called from another domain and cleared if called from the same domain). This patch changes that behavior to inherit the old suppress #VE bit value if it is already set and to set it to 1 otherwise, which is safer and more reliable. Signed-off-by: Vlad Ioan Topan --- xen/arch/x86/mm/mem_access.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/xen/arch/x86/mm/mem_access.c b/xen/arch/x86/mm/mem_access.c index 5adaf6df90..d0b0767855 100644 --- a/xen/arch/x86/mm/mem_access.c +++ b/xen/arch/x86/mm/mem_access.c @@ -273,8 +273,7 @@ int p2m_set_altp2m_mem_access(struct domain *d, struct p2m_domain *hp2m, } } - return ap2m->set_entry(ap2m, gfn_l, mfn, PAGE_ORDER_4K, t, a, - (current->domain != d)); + return ap2m->set_entry(ap2m, gfn_l, mfn, PAGE_ORDER_4K, t, a, -1); } static int set_mem_access(struct domain *d, struct p2m_domain *p2m,