From patchwork Wed May 3 16:48:38 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anthony PERARD X-Patchwork-Id: 9710187 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DD5D660351 for ; Wed, 3 May 2017 16:52:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CCA8928452 for ; Wed, 3 May 2017 16:52:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BFD2028608; Wed, 3 May 2017 16:52:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2169C28452 for ; Wed, 3 May 2017 16:52:40 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d5xSH-00014a-BC; Wed, 03 May 2017 16:48:45 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d5xSG-00014U-57 for xen-devel@lists.xenproject.org; Wed, 03 May 2017 16:48:44 +0000 Received: from [85.158.137.68] by server-9.bemta-3.messagelabs.com id C3/6E-01997-BE90A095; Wed, 03 May 2017 16:48:43 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprFIsWRWlGSWpSXmKPExsXitHSDve4rTq5 Ig4l9phbft0xmcmD0OPzhCksAYxRrZl5SfkUCa8ajeVkFa0Qqvkx7wNrA+E+gi5GTQ0LAX+LF 56tMIDaLgIrE0XlL2UBsNgEDiRXTrzKC2CIC+hKbbjeyg9jMAvsZJW62VoPYwgIhEh+/PwSL8 wpYS1w5cIYVxBYSaGORmPTdBSIuKHFy5hMWiF4diQW7PwHN5wCypSWW/+MACXMK+Eh8v3QYbI yogLLEktNbWCDGqEncWLiMZQIj3ywkk2YhmTQLYdICRuZVjBrFqUVlqUW6RmZ6SUWZ6RkluYm ZObqGBsZ6uanFxYnpqTmJScV6yfm5mxiBYVbPwMC4g7Fhr98hRkkOJiVRXvVX7JFCfEn5KZUZ icUZ8UWlOanFhxhlODiUJHhncHBFCgkWpaanVqRl5gADHiYtwcGjJMK7CCTNW1yQmFucmQ6RO sWoKCXOexQkIQCSyCjNg2uDRdklRlkpYV5GBgYGIZ6C1KLczBJU+VeM4hyMSsK8bSBTeDLzSu CmvwJazAS0uFmWA2RxSSJCSqqBsWK/epVKbtSrB9qC1Vujfm6OvXliS970g+qvpkvuSfw7o95 h4rvsS2lZnxKWXNk2QVx18jn2CRMv8nMw37qV33X6ivGfMMmU70uZ84IXBic5f3fnymPPX5kk oX/fPJCZxzvCM3b6n+AdJ9U3vnnEzDotls1ngkaJmDLDswkp7e+Uttoun2EoocRSnJFoqMVcV JwIAOXhbOGtAgAA X-Env-Sender: prvs=2890391ed=anthony.perard@citrix.com X-Msg-Ref: server-14.tower-31.messagelabs.com!1493830121!98589075!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 9.4.12; banners=-,-,- X-VirusChecked: Checked Received: (qmail 7739 invoked from network); 3 May 2017 16:48:42 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-14.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 3 May 2017 16:48:42 -0000 X-IronPort-AV: E=Sophos;i="5.38,284,1491264000"; d="scan'208";a="430768438" Date: Wed, 3 May 2017 17:48:38 +0100 From: Anthony PERARD To: Stefano Stabellini Message-ID: <20170503164838.GB1553@perard.uk.xensource.com> References: <03cfd81856554ecd91c0c317353e819b@AMSPEX02CL03.citrite.net> <51ac3ff38f464abfb98928e6fb959bf7@AMSPEX02CL03.citrite.net> <6738c7d96a1c476187f69616f25b28d1@AMSPEX02CL03.citrite.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.2 (2017-04-18) Cc: "xen-devel@lists.xenproject.org" , Paul Durrant , Wei Liu , "qemu-devel@nongnu.org" Subject: Re: [Xen-devel] QEMU build breakage on ARM against Xen 4.9 caused by libxendevicemodel X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP On Thu, Apr 20, 2017 at 11:05:33AM -0700, Stefano Stabellini wrote: > On Thu, 20 Apr 2017, Paul Durrant wrote: > > I think xencall should be part of the base xen_stable_libs anyway. > > Yes, you are right. However I noticed that -lxencall needs to come after > -lxendevicemodel. So, I'll have to move -lxendevicemodel before > $xen_stable_libs, see below. I'll merge this patch into "configure: > detect presence of libxendevicemodel", if that's OK. > > diff --git a/configure b/configure > index 99d6cbc..3133ef8 100755 > --- a/configure > +++ b/configure > @@ -1992,7 +1992,7 @@ if test "$xen" != "no" ; then > else > > xen_libs="-lxenstore -lxenctrl -lxenguest" > - xen_stable_libs="-lxenforeignmemory -lxengnttab -lxenevtchn" > + xen_stable_libs="-lxencall -lxenforeignmemory -lxengnttab -lxenevtchn" > > # First we test whether Xen headers and libraries are available. > # If no, we are done and there is no Xen support. > @@ -2027,9 +2027,9 @@ int main(void) { > return 0; > } > EOF > - compile_prog "" "$xen_libs $xen_stable_libs -lxendevicemodel" > + compile_prog "" "$xen_libs -lxendevicemodel $xen_stable_libs" > then > - xen_stable_libs="$xen_stable_libs -lxendevicemodel" > + xen_stable_libs="-lxendevicemodel $xen_stable_libs" > xen_ctrl_version=40900 > xen=yes > elif Hey, now that this patch is merged, xen.git fail to build QEMU. (osstest qemu-mainline branch fail.) That's because -lxencall is not found because -L$path_to_libxencall is missing in xen.git. But I've notice something else, libxendevicemodel.so is not linked against libxencall, that might be the root of the issues on arm. (libxenctrl.so is linked against libxencall.) Thought? We probably need this patch in xen: diff --git a/tools/libs/devicemodel/Makefile b/tools/libs/devicemodel/Makefile index 55626a5049..81fa5a4ac4 100644 --- a/tools/libs/devicemodel/Makefile +++ b/tools/libs/devicemodel/Makefile @@ -63,7 +63,7 @@ libxendevicemodel.so.$(MAJOR): libxendevicemodel.so.$(MAJOR).$(MINOR) $(SYMLINK_SHLIB) $< $@ libxendevicemodel.so.$(MAJOR).$(MINOR): $(PIC_OBJS) libxendevicemodel.map - $(CC) $(LDFLAGS) $(PTHREAD_LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,libxendevicemodel.so.$(MAJOR) $(SHLIB_LDFLAGS) -o $@ $(PIC_OBJS) $(LDLIBS_libxentoollog) $(APPEND_LDFLAGS) + $(CC) $(LDFLAGS) $(PTHREAD_LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,libxendevicemodel.so.$(MAJOR) $(SHLIB_LDFLAGS) -o $@ $(PIC_OBJS) $(LDLIBS_libxentoollog) $(LDLIBS_libxencall) $(APPEND_LDFLAGS) .PHONY: install install: build