From patchwork Thu May 18 15:07:56 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adrian Pop X-Patchwork-Id: 9734645 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 612D6600CC for ; Thu, 18 May 2017 15:10:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5042428833 for ; Thu, 18 May 2017 15:10:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 44EFA2884E; Thu, 18 May 2017 15:10:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C0CEC28851 for ; Thu, 18 May 2017 15:10:32 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBN2W-0008G9-DZ; Thu, 18 May 2017 15:08:32 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBN2U-0008Fp-UL for xen-devel@lists.xenproject.org; Thu, 18 May 2017 15:08:31 +0000 Received: from [193.109.254.147] by server-3.bemta-6.messagelabs.com id 77/A7-03058-EE8BD195; Thu, 18 May 2017 15:08:30 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrOIsWRWlGSWpSXmKPExsUSfTxjoe7bHbK RBlvmGlh83zKZyYHR4/CHKywBjFGsmXlJ+RUJrBl3NpxhK9jEWXF1/iyWBsYH7F2MnBxCAm4S jZ3/mSDstYwSpzsCuhi5gOwLjBL31zZDJTwkLt/8xAqR2M0o8fzCFrAEm4C6xOa9W1hBbBEBJ Yl7qyYzgRQxC7xhkrj/6gJYkbBAmMTHKbPAilgEVCVu/1sIFucVsJA49b2TBcSWEJCXOLtlJz OIzSlgKbFk3zVGiM0WEjvf9AHVcwDV5Eic36QOYUpJ/G9VAlklIdDHIvFu/WxmiDEyEo8m3mS bwCi0gJFhFaNGcWpRWWqRrpG5XlJRZnpGSW5iZo6uoYGZXm5qcXFiempOYlKxXnJ+7iZGYCAy AMEOxsVrAw8xSnIwKYnyHi6QjRTiS8pPqcxILM6ILyrNSS0+xCjDwaEkwft7O1BOsCg1PbUiL TMHGBMwaQkOHiUR3jcgad7igsTc4sx0iNQpRl2Ofa0f3zMJseTl56VKifM+ACkSACnKKM2DGw GLz0uMslLCvIxARwnxFKQW5WaWoMq/YhTnYFQShljFk5lXArfpFdARTEBHND+QBjmiJBEhJdX AuMgl4e6imBddIu+67ya+vR0ptLRaU9bBXS5Hvbz5194rNzlMTYMqG3gcMxRmVM2/FnhkjT7n 5Gi7DtYVU+2+pExpc9x1oYI9UPhGYJP+X5PpOxmjPhnOnv5aLpkp7okS33FV/RWXQ4U27Xzlk L4hhSluUmcE56d3t6bK8V9apr0xb8kc1uvMSizFGYmGWsxFxYkAeuT3q8oCAAA= X-Env-Sender: apop@bitdefender.com X-Msg-Ref: server-6.tower-27.messagelabs.com!1495120109!103266843!1 X-Originating-IP: [91.199.104.161] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.4.12; banners=-,-,- X-VirusChecked: Checked Received: (qmail 42738 invoked from network); 18 May 2017 15:08:29 -0000 Received: from mx01.bbu.dsd.mx.bitdefender.com (HELO mx01.bbu.dsd.mx.bitdefender.com) (91.199.104.161) by server-6.tower-27.messagelabs.com with DHE-RSA-AES128-GCM-SHA256 encrypted SMTP; 18 May 2017 15:08:29 -0000 Received: (qmail 432 invoked from network); 18 May 2017 18:08:27 +0300 Received: from unknown (HELO mx-sr.buh.bitdefender.com) (10.17.80.103) by mx01.bbu.dsd.mx.bitdefender.com with AES256-GCM-SHA384 encrypted SMTP; 18 May 2017 18:08:27 +0300 Received: from smtp03.buh.bitdefender.org (unknown [10.17.80.77]) by mx-sr.buh.bitdefender.com (Postfix) with ESMTP id D1CA880F48 for ; Thu, 18 May 2017 18:08:27 +0300 (EEST) Received: (qmail 25424 invoked from network); 18 May 2017 18:08:09 +0300 Received: from unknown (HELO hel.clj.bitdefender.biz) (apop@bitdefender.com@10.220.12.75) by smtp03.buh.bitdefender.org with AES128-GCM-SHA256 encrypted SMTP; 18 May 2017 18:08:09 +0300 From: Adrian Pop To: xen-devel@lists.xenproject.org Date: Thu, 18 May 2017 18:07:56 +0300 Message-Id: <20170518150758.9414-2-apop@bitdefender.com> X-Mailer: git-send-email 2.12.2 In-Reply-To: <20170518150758.9414-1-apop@bitdefender.com> References: <20170518150758.9414-1-apop@bitdefender.com> X-BitDefender-Scanner: Clean, Agent: BitDefender qmail 3.1.6 on smtp03.buh.bitdefender.org, sigver: 7.71440 X-BitDefender-Spam: No (0) X-BitDefender-SpamStamp: Build: [Engines: 2.15.8.1074, Dats: 449447, Stamp: 3], Multi: [Enabled, t: (0.000009, 0.007374)], BW: [Enabled, t: (0.000010)], RBL DNSBL: [Disabled], APM: [Enabled, Score: 500, t: (0.003357), Flags: 85D2ED72; NN_NO_CONTENT_TYPE; NN_NO_LINK_NMD; NN_LEGIT_BITDEFENDER; NN_LEGIT_S_SQARE_BRACKETS; NN_LEGIT_MAILING_LIST_TO], SGN: [Enabled, t: (0.008149,0.000079)], URL: [Enabled, t: (0.000006)], RTDA: [Enabled, t: (0.120446), Hit: No, Details: v2.4.9; Id: 15.5f4go2.1bfn775vc.as2jt], total: 0(775) X-BitDefender-CF-Stamp: none Cc: Tamas K Lengyel , Wei Liu , Razvan Cojocaru , Adrian Pop , George Dunlap , Andrew Cooper , Ian Jackson , Jan Beulich , Vlad Ioan Topan Subject: [Xen-devel] [PATCH 1/3] x86/mm: Change default value for suppress #VE in set_mem_access() X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Vlad Ioan Topan The default value for the "suppress #VE" bit set by set_mem_access() currently depends on whether the call is made from the same domain (the bit is set when called from another domain and cleared if called from the same domain). This patch changes that behavior to inherit the old suppress #VE bit value if it is already set and to set it to 1 otherwise, which is safer and more reliable. Signed-off-by: Vlad Ioan Topan Signed-off-by: Adrian Pop --- xen/arch/x86/mm/mem_access.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/xen/arch/x86/mm/mem_access.c b/xen/arch/x86/mm/mem_access.c index 5adaf6df90..d0b0767855 100644 --- a/xen/arch/x86/mm/mem_access.c +++ b/xen/arch/x86/mm/mem_access.c @@ -273,8 +273,7 @@ int p2m_set_altp2m_mem_access(struct domain *d, struct p2m_domain *hp2m, } } - return ap2m->set_entry(ap2m, gfn_l, mfn, PAGE_ORDER_4K, t, a, - (current->domain != d)); + return ap2m->set_entry(ap2m, gfn_l, mfn, PAGE_ORDER_4K, t, a, -1); } static int set_mem_access(struct domain *d, struct p2m_domain *p2m,