From patchwork Thu Jun 8 13:25:51 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 9774863 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6735E603F1 for ; Thu, 8 Jun 2017 13:30:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 589F727165 for ; Thu, 8 Jun 2017 13:30:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4CDB2269A3; Thu, 8 Jun 2017 13:30:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id AD1CA269A3 for ; Thu, 8 Jun 2017 13:30:07 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dIxTr-0004fN-Qt; Thu, 08 Jun 2017 13:28:07 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dIxTq-0004cX-CU for xen-devel@lists.xenproject.org; Thu, 08 Jun 2017 13:28:06 +0000 Received: from [85.158.137.68] by server-13.bemta-3.messagelabs.com id BF/97-17076-5E059395; Thu, 08 Jun 2017 13:28:05 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrCLMWRWlGSWpSXmKPExsXiaHS5VfdJgGW kwfftOhbft0xmcmD0OPzhCksAYxRrZl5SfkUCa0b3ksvsBcdEK/ovPGVsYDwq1MXIxcEicIJN 4v//TiYQR0jgBKPEqe7VjF2MnBxsAioSb573sIMkRAQOsUicfHOUCSTBLKAg8eveJlYQW1jAU qJv3TV2EJtFQFXixZPJzF2MHBy8AgYSM68Ig4QlBOQldrVdBCvnBAq3nN4FNkZIQF/i0IJpzC DzJQRaGCXaLq5gmcDIs4CRYRWjRnFqUVlqka6hiV5SUWZ6RkluYmaOrqGBsV5uanFxYnpqTmJ SsV5yfu4mRqDvGYBgB+OK7Z6HGCU5mJREeRUFLCOF+JLyUyozEosz4otKc1KLDzHKcHAoSfAm +APlBItS01Mr0jJzgEEIk5bg4FES4f3vA5TmLS5IzC3OTIdInWJUlBLnvQvSJwCSyCjNg2uDB f4lRlkpYV5GoEOEeApSi3IzS1DlXzGKczAqCfO6+QJN4cnMK4Gb/gpoMRPQ4iXvLEAWlyQipK QaGLU2fL606fxuw6Se5iS++Uv6DS0+9a6eJB3474zW5+9fj+7d92p76YSs5x3Se02FeG5LezB eKU1leXts5Y94QW8HoQkfOu06LZgOup33/upxI1Gwoz/oucVCLjZWJqPfQf2uNjsOfZA8OJm/ PWoWZ9CSUu/W91bvVTa8uuC3WaT2xOlW7aWRrkosxRmJhlrMRcWJANGvQwV3AgAA X-Env-Sender: BATV+eb06f239ea6f59aeb59b+5037+infradead.org+hch@bombadil.s rs.infradead.org X-Msg-Ref: server-3.tower-31.messagelabs.com!1496928483!104704593!1 X-Originating-IP: [65.50.211.133] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.4.19; banners=-,-,- X-VirusChecked: Checked Received: (qmail 64843 invoked from network); 8 Jun 2017 13:28:04 -0000 Received: from bombadil.infradead.org (HELO bombadil.infradead.org) (65.50.211.133) by server-3.tower-31.messagelabs.com with AES256-GCM-SHA384 encrypted SMTP; 8 Jun 2017 13:28:04 -0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Er/PBxW/tOtoCNR0FHj1VvmeiHjF/tVFU+Dqgf9uoBM=; b=DuQWAeDsdmuE2TG+u3hI7Bt0v NaPkHxkVot5MDGxHwXkca1kuAwmt/IiJzIhVcT+Iocc9fae9anvVEU4nitUGMUC6qDw8Cl3B5jxHs gdkt+0pFn7AgHV+r9SHnqmfG2MXWgEIS+tvaOB4EngemWtjYyX88hizeS/FF7AX0E9AymIqA/CiW4 99Ozwe7xu65TRPfeeVYXYb8DbLQ1oK7gcXlOrsbv2F8+zGWr0LQ2UrilO8HFVOCpxSPIAKmkABv/L To43nH3uLe5rMQ4pRR6OV/SZJJpc4Yap1EBZKH+JOq7wZULj+/qF/CIvOCfzWidxiZ8ThubyqB32V N5tDkI4oA==; Received: from clnet-p099-196.ikbnet.co.at ([83.175.99.196] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.87 #1 (Red Hat Linux)) id 1dIxTg-00070Z-Ve; Thu, 08 Jun 2017 13:27:57 +0000 From: Christoph Hellwig To: x86@kernel.org, linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org, linux-c6x-dev@linux-c6x.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-mips@linux-mips.org, openrisc@lists.librecores.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org, dmaengine@vger.kernel.org, linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, iommu@lists.linux-foundation.org, netdev@vger.kernel.org Date: Thu, 8 Jun 2017 15:25:51 +0200 Message-Id: <20170608132609.32662-27-hch@lst.de> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170608132609.32662-1-hch@lst.de> References: <20170608132609.32662-1-hch@lst.de> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Cc: linux-kernel@vger.kernel.org Subject: [Xen-devel] [PATCH 26/44] dma-mapping: remove DMA_ERROR_CODE X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP And update the documentation - dma_mapping_error has been supported everywhere for a long time. Signed-off-by: Christoph Hellwig --- Documentation/DMA-API-HOWTO.txt | 31 +++++-------------------------- include/linux/dma-mapping.h | 5 ----- 2 files changed, 5 insertions(+), 31 deletions(-) diff --git a/Documentation/DMA-API-HOWTO.txt b/Documentation/DMA-API-HOWTO.txt index 979228bc9035..4ed388356898 100644 --- a/Documentation/DMA-API-HOWTO.txt +++ b/Documentation/DMA-API-HOWTO.txt @@ -550,32 +550,11 @@ and to unmap it: dma_unmap_single(dev, dma_handle, size, direction); You should call dma_mapping_error() as dma_map_single() could fail and return -error. Not all DMA implementations support the dma_mapping_error() interface. -However, it is a good practice to call dma_mapping_error() interface, which -will invoke the generic mapping error check interface. Doing so will ensure -that the mapping code will work correctly on all DMA implementations without -any dependency on the specifics of the underlying implementation. Using the -returned address without checking for errors could result in failures ranging -from panics to silent data corruption. A couple of examples of incorrect ways -to check for errors that make assumptions about the underlying DMA -implementation are as follows and these are applicable to dma_map_page() as -well. - -Incorrect example 1: - dma_addr_t dma_handle; - - dma_handle = dma_map_single(dev, addr, size, direction); - if ((dma_handle & 0xffff != 0) || (dma_handle >= 0x1000000)) { - goto map_error; - } - -Incorrect example 2: - dma_addr_t dma_handle; - - dma_handle = dma_map_single(dev, addr, size, direction); - if (dma_handle == DMA_ERROR_CODE) { - goto map_error; - } +error. Doing so will ensure that the mapping code will work correctly on all +DMA implementations without any dependency on the specifics of the underlying +implementation. Using the returned address without checking for errors could +result in failures ranging from panics to silent data corruption. The same +applies to dma_map_page() as well. You should call dma_unmap_single() when the DMA activity is finished, e.g., from the interrupt which told you that the DMA transfer is done. diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h index 4f3eecedca2d..a57875309bfd 100644 --- a/include/linux/dma-mapping.h +++ b/include/linux/dma-mapping.h @@ -546,12 +546,7 @@ static inline int dma_mapping_error(struct device *dev, dma_addr_t dma_addr) if (get_dma_ops(dev)->mapping_error) return get_dma_ops(dev)->mapping_error(dev, dma_addr); - -#ifdef DMA_ERROR_CODE - return dma_addr == DMA_ERROR_CODE; -#else return 0; -#endif } #ifndef HAVE_ARCH_DMA_SUPPORTED