From patchwork Thu Jun 8 13:25:29 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 9774763 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8865A60393 for ; Thu, 8 Jun 2017 13:28:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7A56928451 for ; Thu, 8 Jun 2017 13:28:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6EF4D28520; Thu, 8 Jun 2017 13:28:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 0283728451 for ; Thu, 8 Jun 2017 13:28:37 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dIxSP-00035K-2e; Thu, 08 Jun 2017 13:26:37 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dIxSN-00033D-Td for xen-devel@lists.xenproject.org; Thu, 08 Jun 2017 13:26:36 +0000 Received: from [85.158.143.35] by server-8.bemta-6.messagelabs.com id 42/41-03696-B8059395; Thu, 08 Jun 2017 13:26:35 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrGLMWRWlGSWpSXmKPExsXiaHS5VbcrwDL SYNZFG4vvWyYzOTB6HP5whSWAMYo1My8pvyKBNWPlylcsBY/ZKz5Od21gvMXWxcjFwSJwgk3i 44q1jCCOkMAJRomnz/ewdzFycrAJqEi8ed7DDpIQETjEInHyzVEmkASzgILEr3ubWEFsYQFri Ukz9oI1sAioSixbcBEsziugL7Hq6EuwegkBeYldbRBxTgEDiZbTu8DiQkA1hxZMYwZZICHQwi jRdnEFywRGngWMDKsYNYpTi8pSi3QNzfSSijLTM0pyEzNzdA0NzPRyU4uLE9NTcxKTivWS83M 3MQJ9zwAEOxjvbww4xCjJwaQkyqsoYBkpxJeUn1KZkVicEV9UmpNafIhRhoNDSYL3nR9QTrAo NT21Ii0zBxiEMGkJDh4lEd7/PkBp3uKCxNzizHSI1ClGY45LfRu+MHE0fdjyhUmIJS8/L1VKn PcXyCQBkNKM0jy4QbDouMQoKyXMywh0mhBPQWpRbmYJqvwrRnEORiVhXjdfoCk8mXklcPteAZ 3CBHTKkncWIKeUJCKkpBoYJ6xYkvZrphrv5FdFRhGHfO8UivaLGeyxrGHjyhZY/sBpdr5H+7r u17onFj80nGIwrd2c719s/2s/pho78Rc7s+7dOyzL5nqTjZel2LUkf62lBKN/5c7meewX01s8 VTb8vlZlxSDQ+OVCwXWVC2/3uPy+v6VbarOMSPjnNt9bOj45X46IWvxUYinOSDTUYi4qTgQAo xoClokCAAA= X-Env-Sender: BATV+eb06f239ea6f59aeb59b+5037+infradead.org+hch@bombadil.s rs.infradead.org X-Msg-Ref: server-2.tower-21.messagelabs.com!1496928393!59001991!1 X-Originating-IP: [65.50.211.133] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.4.19; banners=-,-,- X-VirusChecked: Checked Received: (qmail 3056 invoked from network); 8 Jun 2017 13:26:34 -0000 Received: from bombadil.infradead.org (HELO bombadil.infradead.org) (65.50.211.133) by server-2.tower-21.messagelabs.com with AES256-GCM-SHA384 encrypted SMTP; 8 Jun 2017 13:26:34 -0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=VolBZDxS9ZQrQoHzmubjiZ2v8Rk+FgSixd/DX4o9p2E=; b=gF+6aDODIb7xcHBd7xdo+sHop 1Bh4UuYpu1Mt5Zc9LJ8djA0u+qYbfjcRYBu4PgpcovWdfLQm5pSH+ik9urNqGCEWSDi90KUEDViK7 z8/HkDLChErmKMHxPDVsohs4XTYF4id0ezPjvvBExGPcnSTPr8igshrAvzNnY3GMfw05ZJWzzUN0N Z8oB7GyXuCvPufd6GNByT/f7+3sAkQ8KBbP8qdBQkNUFtl+HR7pKHBvOxNjOo+8lqAL48nU/8boOd LEp/A5jpWQxpGvfUxQ8l5+0KIH+cOuxOrwzQUCVTFf4DT0FgelbP3BwTQYP+o+NYV2T+uQupQN8qz 8lchzhB5A==; Received: from clnet-p099-196.ikbnet.co.at ([83.175.99.196] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.87 #1 (Red Hat Linux)) id 1dIxSJ-00052V-9j; Thu, 08 Jun 2017 13:26:32 +0000 From: Christoph Hellwig To: x86@kernel.org, linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org, linux-c6x-dev@linux-c6x.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-mips@linux-mips.org, openrisc@lists.librecores.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org, dmaengine@vger.kernel.org, linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, iommu@lists.linux-foundation.org, netdev@vger.kernel.org Date: Thu, 8 Jun 2017 15:25:29 +0200 Message-Id: <20170608132609.32662-5-hch@lst.de> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170608132609.32662-1-hch@lst.de> References: <20170608132609.32662-1-hch@lst.de> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Cc: linux-kernel@vger.kernel.org Subject: [Xen-devel] [PATCH 04/44] drm/exynos: don't use DMA_ERROR_CODE X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP DMA_ERROR_CODE already isn't a valid API to user for drivers and will go away soon. exynos_drm_fb_dma_addr uses it a an error return when the passed in index is invalid, but the callers never check for it but instead pass the address straight to the hardware. Add a WARN_ON instead and just return 0. Signed-off-by: Christoph Hellwig --- drivers/gpu/drm/exynos/exynos_drm_fb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fb.c b/drivers/gpu/drm/exynos/exynos_drm_fb.c index c77a5aced81a..d48fd7c918f8 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fb.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fb.c @@ -181,8 +181,8 @@ dma_addr_t exynos_drm_fb_dma_addr(struct drm_framebuffer *fb, int index) { struct exynos_drm_fb *exynos_fb = to_exynos_fb(fb); - if (index >= MAX_FB_BUFFER) - return DMA_ERROR_CODE; + if (WARN_ON_ONCE(index >= MAX_FB_BUFFER)) + return 0; return exynos_fb->dma_addr[index]; }