From patchwork Fri Jun 16 18:10:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 9792645 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 27E0560326 for ; Fri, 16 Jun 2017 18:13:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 236E72625B for ; Fri, 16 Jun 2017 18:13:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 167732866B; Fri, 16 Jun 2017 18:13:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 908992625B for ; Fri, 16 Jun 2017 18:13:49 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dLviR-0007b9-8w; Fri, 16 Jun 2017 18:11:27 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dLviQ-0007af-Tr for xen-devel@lists.xenproject.org; Fri, 16 Jun 2017 18:11:27 +0000 Received: from [85.158.143.35] by server-5.bemta-6.messagelabs.com id A6/9D-03371-E4F14495; Fri, 16 Jun 2017 18:11:26 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrCLMWRWlGSWpSXmKPExsXiaHS5VddX3iX SYM4zdYvvWyYzOTB6HP5whSWAMYo1My8pvyKBNWPlylcsBY/ZKz5Od21gvMXWxcjFwSJwgk2i ZfMRVhBHSOAEo0Tr2oWMXYycHGwCKhJvnvewgyREBA6xSJx8c5QJJMEsoCDx694mVhBbWMBaY tKMvUBFHECjVCUO75QFCfMK6Ev8mdvPBmJLCMhL7Gq7CFbOKWAg8fPINrD5QkA1U27eZQSZLy HQwijRdnEFywRGngWMDKsY1YtTi8pSi3RN9ZKKMtMzSnITM3N0DQ3M9HJTi4sT01NzEpOK9ZL zczcxAv3OAAQ7GKdf9j/EKMnBpCTK+/6Jc6QQX1J+SmVGYnFGfFFpTmrxIUYZDg4lCd5Vsi6R QoJFqempFWmZOcAAhElLcPAoifDu5wNK8xYXJOYWZ6ZDpE4xGnNc6tvwhYmj6cOWL0xCLHn5e alS4rxHQSYJgJRmlObBDYJFxiVGWSlhXkag04R4ClKLcjNLUOVfMYpzMCoJ83bLAE3hycwrgd v3CugUJqBTgi44gJxSkoiQkmpgZLq3tJ9vQukWzZ9Plp3V9LZnXGPEuKxKavHigLBFM43mWS2 6d2KGV8O9+wfv3Hsg9SxVgbFJPHSR3lmDzbJHVkh8zbZaXX/q9SvdoM55kw0v7InI+2Fb9CDl 0c17G5e67GI9cuDTuoZDcpd2P4qP3sadX3drdR3vzYOvndjrXop9FdKe+eJh4UolluKMREMt5 qLiRAA7CqEmhwIAAA== X-Env-Sender: BATV+48ca1ab4adaecdf09dc3+5045+infradead.org+hch@bombadil.s rs.infradead.org X-Msg-Ref: server-10.tower-21.messagelabs.com!1497636683!67651156!1 X-Originating-IP: [65.50.211.133] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.4.19; banners=-,-,- X-VirusChecked: Checked Received: (qmail 60624 invoked from network); 16 Jun 2017 18:11:25 -0000 Received: from bombadil.infradead.org (HELO bombadil.infradead.org) (65.50.211.133) by server-10.tower-21.messagelabs.com with AES256-GCM-SHA384 encrypted SMTP; 16 Jun 2017 18:11:25 -0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=VolBZDxS9ZQrQoHzmubjiZ2v8Rk+FgSixd/DX4o9p2E=; b=THVPuyuHTKM8ALqXwsIZqKBJZ SK3+dGgdzbAXPQeRkU6eFYuLB2ODWl9twiGUVkGVau4AyN1LdNLSJVhfMKYIyFA3r9yBqyAknCEO6 n9YFfIM2GQJXnm/5VpIyRJXXOoYKhpLPv1PJfdLZU7lI0b9XYaxxmIl/Sc5tqTVfINjx5r/vBPwLE hf2G4UP+ZPYIndT+Ad+Xw42tQl724CLBzEcyMVg4dpuEIVmDadecp7yA4G1m+zUIGe1Q6HJi0RSMe 9kpTabDT4+AJiaJcXcIfn8/s8oMbjIo88GmY42gJLQF2mpA9Im6RwC84Naq1m8py5sIwUU0cdZKH3 5ORGslnRQ==; Received: from clnet-p099-196.ikbnet.co.at ([83.175.99.196] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.87 #1 (Red Hat Linux)) id 1dLviM-0004MA-4P; Fri, 16 Jun 2017 18:11:22 +0000 From: Christoph Hellwig To: x86@kernel.org, linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org, linux-c6x-dev@linux-c6x.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-mips@linux-mips.org, openrisc@lists.librecores.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org, dmaengine@vger.kernel.org, linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, iommu@lists.linux-foundation.org, netdev@vger.kernel.org Date: Fri, 16 Jun 2017 20:10:19 +0200 Message-Id: <20170616181059.19206-5-hch@lst.de> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170616181059.19206-1-hch@lst.de> References: <20170616181059.19206-1-hch@lst.de> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Cc: linux-kernel@vger.kernel.org Subject: [Xen-devel] [PATCH 04/44] drm/exynos: don't use DMA_ERROR_CODE X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP DMA_ERROR_CODE already isn't a valid API to user for drivers and will go away soon. exynos_drm_fb_dma_addr uses it a an error return when the passed in index is invalid, but the callers never check for it but instead pass the address straight to the hardware. Add a WARN_ON instead and just return 0. Signed-off-by: Christoph Hellwig --- drivers/gpu/drm/exynos/exynos_drm_fb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fb.c b/drivers/gpu/drm/exynos/exynos_drm_fb.c index c77a5aced81a..d48fd7c918f8 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fb.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fb.c @@ -181,8 +181,8 @@ dma_addr_t exynos_drm_fb_dma_addr(struct drm_framebuffer *fb, int index) { struct exynos_drm_fb *exynos_fb = to_exynos_fb(fb); - if (index >= MAX_FB_BUFFER) - return DMA_ERROR_CODE; + if (WARN_ON_ONCE(index >= MAX_FB_BUFFER)) + return 0; return exynos_fb->dma_addr[index]; }