| Message ID | 20170626091625.19655-2-haozhong.zhang@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
>>> Haozhong Zhang <haozhong.zhang@intel.com> 06/26/17 11:16 AM >>> >struct mc_telem_cpu_ctl is now used as the type of per-cpu variables, >rather than a globla variable shared by all CPUs, so some of its >comment do not apply any more. > >Signed-off-by: Haozhong Zhang <haozhong.zhang@intel.com> Acked-by: Jan Beulich <jbeulich@suse.com> There's no need to re-send, but for the future in any such cases where you're adjusting for an earlier oversight it would be nice to make the connection by naming the earlier commit. Jan
On 06/27/17 00:28 -0600, Jan Beulich wrote: > >>> Haozhong Zhang <haozhong.zhang@intel.com> 06/26/17 11:16 AM >>> > >struct mc_telem_cpu_ctl is now used as the type of per-cpu variables, > >rather than a globla variable shared by all CPUs, so some of its > >comment do not apply any more. > > > >Signed-off-by: Haozhong Zhang <haozhong.zhang@intel.com> > > Acked-by: Jan Beulich <jbeulich@suse.com> > > There's no need to re-send, but for the future in any such cases where you're > adjusting for an earlier oversight it would be nice to make the connection by > naming the earlier commit. > c/s cbc585158f ("x86/mce: eliminate unnecessary NR_CPUS-sized arrays") introduced struct mc_telem_cpu_ctl and used it in the per-cpu way. Haozhong
diff --git a/xen/arch/x86/cpu/mcheck/mctelem.c b/xen/arch/x86/cpu/mcheck/mctelem.c index 96048ebcc0..57abeab357 100644 --- a/xen/arch/x86/cpu/mcheck/mctelem.c +++ b/xen/arch/x86/cpu/mcheck/mctelem.c @@ -108,9 +108,7 @@ static struct mc_telem_ctl { struct mc_telem_cpu_ctl { /* * Per-CPU processing lists, used for deferred (softirq) - * processing of telemetry. @pending is indexed by the - * CPU that the telemetry belongs to. @processing is indexed - * by the CPU that is processing the telemetry. + * processing of telemetry. */ struct mctelem_ent *pending; struct mctelem_ent *processing;
struct mc_telem_cpu_ctl is now used as the type of per-cpu variables, rather than a globla variable shared by all CPUs, so some of its comment do not apply any more. Signed-off-by: Haozhong Zhang <haozhong.zhang@intel.com> --- Cc: Jan Beulich <jbeulich@suse.com> Cc: Andrew Cooper <andrew.cooper3@citrix.com> --- xen/arch/x86/cpu/mcheck/mctelem.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)