[3/8] x86/domain.c: use plain bool

Commit Message

Wei Liu June 28, 2017, 2:18 p.m. UTC

Signed-off-by: Wei Liu <[e-mail]>
---
 xen/arch/x86/domain.c        | 16 ++++++++--------
 xen/include/asm-x86/domain.h |  2 +-
 2 files changed, 9 insertions(+), 9 deletions(-)

Comments

Andrew Cooper June 28, 2017, 2:22 p.m. UTC | #1

On 28/06/17 15:18, Wei Liu wrote:
> Signed-off-by: Wei Liu <[e-mail]>

Reviewed-by: Andrew Cooper <[e-mail]>

Jan Beulich June 29, 2017, 6:55 a.m. UTC | #2

>>> Wei Liu <[e-mail]> 06/28/17 4:18 PM >>>
>@@ -1993,7 +1993,7 @@ void vcpu_kick(struct vcpu *v)
      >* NB2. We save the running flag across the unblock to avoid a needless
      >* IPI for domains that we IPI'd to unblock.
      >*/
>-    bool_t running = v->is_running;
>+    bool running = v->is_running;
     >vcpu_unblock(v);

Please take the opportunity and also add the missing blank line here.

Jan

Patch

diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
index f7873da323..4e176e4d56 100644
--- a/xen/arch/x86/domain.c
+++ b/xen/arch/x86/domain.c
@@ -872,7 +872,7 @@  int arch_set_info_guest(
     else
     {
         unsigned long pfn = pagetable_get_pfn(v->arch.guest_table);
-        bool_t fail;
+        bool fail;
 
         if ( !compat )
         {
@@ -950,7 +950,7 @@  int arch_set_info_guest(
              test_bit(VMASST_TYPE_m2p_strict, &c.nat->vm_assist) &&
              atomic_read(&d->arch.pv_domain.nr_l4_pages) )
         {
-            bool_t done = 0;
+            bool done = false;
 
             spin_lock_recursive(&d->page_alloc_lock);
 
@@ -1472,15 +1472,15 @@  void paravirt_ctxt_switch_to(struct vcpu *v)
 }
 
 /* Update per-VCPU guest runstate shared memory area (if registered). */
-bool_t update_runstate_area(struct vcpu *v)
+bool update_runstate_area(struct vcpu *v)
 {
-    bool_t rc;
+    bool rc;
     struct guest_memory_policy policy =
         { .smap_policy = SMAP_CHECK_ENABLED, .nested_guest_mode = false };
     void __user *guest_handle = NULL;
 
     if ( guest_handle_is_null(runstate_guest(v)) )
-        return 1;
+        return true;
 
     update_guest_memory_policy(v, &policy);
 
@@ -1502,7 +1502,7 @@  bool_t update_runstate_area(struct vcpu *v)
 
         XLAT_vcpu_runstate_info(&info, &v->runstate);
         __copy_to_guest(v->runstate_guest.compat, &info, 1);
-        rc = 1;
+        rc = true;
     }
     else
         rc = __copy_to_guest(runstate_guest(v), &v->runstate, 1) !=
@@ -1528,7 +1528,7 @@  static void _update_runstate_area(struct vcpu *v)
         v->arch.pv_vcpu.need_update_runstate_area = 1;
 }
 
-static inline bool_t need_full_gdt(const struct domain *d)
+static inline bool need_full_gdt(const struct domain *d)
 {
     return is_pv_domain(d) && !is_idle_domain(d);
 }
@@ -1993,7 +1993,7 @@  void vcpu_kick(struct vcpu *v)
      * NB2. We save the running flag across the unblock to avoid a needless
      * IPI for domains that we IPI'd to unblock.
      */
-    bool_t running = v->is_running;
+    bool running = v->is_running;
     vcpu_unblock(v);
     if ( running && (in_irq() || (v != current)) )
         cpu_raise_softirq(v->processor, VCPU_KICK_SOFTIRQ);
diff --git a/xen/include/asm-x86/domain.h b/xen/include/asm-x86/domain.h
index 27d80eeff4..398193eefb 100644
--- a/xen/include/asm-x86/domain.h
+++ b/xen/include/asm-x86/domain.h
@@ -592,7 +592,7 @@  void update_guest_memory_policy(struct vcpu *v,
 #define hvm_vmx         hvm_vcpu.u.vmx
 #define hvm_svm         hvm_vcpu.u.svm
 
-bool_t update_runstate_area(struct vcpu *);
+bool update_runstate_area(struct vcpu *);
 bool_t update_secondary_system_time(struct vcpu *,
                                     struct vcpu_time_info *);