| Message ID | 20170630155431.23824-17-julien.grall@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, 30 Jun 2017, Julien Grall wrote: > We are phasing out the use of bool_t in the hypervisor code. This is missing your signed-off-by. Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> > --- > Changes in v3: > - Patch added > --- > xen/include/asm-arm/lpae.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/xen/include/asm-arm/lpae.h b/xen/include/asm-arm/lpae.h > index 6fbf7c606c..a62b118630 100644 > --- a/xen/include/asm-arm/lpae.h > +++ b/xen/include/asm-arm/lpae.h > @@ -126,7 +126,7 @@ typedef union { > lpae_walk_t walk; > } lpae_t; > > -static inline bool_t lpae_valid(lpae_t pte) > +static inline bool lpae_valid(lpae_t pte) > { > return pte.walk.valid; > } > @@ -136,12 +136,12 @@ static inline bool_t lpae_valid(lpae_t pte) > * the table bit and therefore these would return the opposite to what > * you would expect. > */ > -static inline bool_t lpae_table(lpae_t pte) > +static inline bool lpae_table(lpae_t pte) > { > return lpae_valid(pte) && pte.walk.table; > } > > -static inline bool_t lpae_mapping(lpae_t pte) > +static inline bool lpae_mapping(lpae_t pte) > { > return lpae_valid(pte) && !pte.walk.table; > } > -- > 2.11.0 >
On Fri, 30 Jun 2017, 21:12 Stefano Stabellini, <sstabellini@kernel.org> wrote: > On Fri, 30 Jun 2017, Julien Grall wrote: > > We are phasing out the use of bool_t in the hypervisor code. > > This is missing your signed-off-by. > > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> > Doh. Signed-off-by: Julien Grall <julien.grall@arm.com> Shall I resend the patch? Cheers, > > --- > > Changes in v3: > > - Patch added > > --- > > xen/include/asm-arm/lpae.h | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/xen/include/asm-arm/lpae.h b/xen/include/asm-arm/lpae.h > > index 6fbf7c606c..a62b118630 100644 > > --- a/xen/include/asm-arm/lpae.h > > +++ b/xen/include/asm-arm/lpae.h > > @@ -126,7 +126,7 @@ typedef union { > > lpae_walk_t walk; > > } lpae_t; > > > > -static inline bool_t lpae_valid(lpae_t pte) > > +static inline bool lpae_valid(lpae_t pte) > > { > > return pte.walk.valid; > > } > > @@ -136,12 +136,12 @@ static inline bool_t lpae_valid(lpae_t pte) > > * the table bit and therefore these would return the opposite to what > > * you would expect. > > */ > > -static inline bool_t lpae_table(lpae_t pte) > > +static inline bool lpae_table(lpae_t pte) > > { > > return lpae_valid(pte) && pte.walk.table; > > } > > > > -static inline bool_t lpae_mapping(lpae_t pte) > > +static inline bool lpae_mapping(lpae_t pte) > > { > > return lpae_valid(pte) && !pte.walk.table; > > } > > -- > > 2.11.0 > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > https://lists.xen.org/xen-devel >
On Fri, 30 Jun 2017, Julien Grall wrote: > On Fri, 30 Jun 2017, 21:12 Stefano Stabellini, <sstabellini@kernel.org> wrote: > On Fri, 30 Jun 2017, Julien Grall wrote: > > We are phasing out the use of bool_t in the hypervisor code. > > This is missing your signed-off-by. > > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> > > > Doh. > > Signed-off-by: Julien Grall <julien.grall@arm.com> > > Shall I resend the patch? No, I can fix this. > > > --- > > Changes in v3: > > - Patch added > > --- > > xen/include/asm-arm/lpae.h | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/xen/include/asm-arm/lpae.h b/xen/include/asm-arm/lpae.h > > index 6fbf7c606c..a62b118630 100644 > > --- a/xen/include/asm-arm/lpae.h > > +++ b/xen/include/asm-arm/lpae.h > > @@ -126,7 +126,7 @@ typedef union { > > lpae_walk_t walk; > > } lpae_t; > > > > -static inline bool_t lpae_valid(lpae_t pte) > > +static inline bool lpae_valid(lpae_t pte) > > { > > return pte.walk.valid; > > } > > @@ -136,12 +136,12 @@ static inline bool_t lpae_valid(lpae_t pte) > > * the table bit and therefore these would return the opposite to what > > * you would expect. > > */ > > -static inline bool_t lpae_table(lpae_t pte) > > +static inline bool lpae_table(lpae_t pte) > > { > > return lpae_valid(pte) && pte.walk.table; > > } > > > > -static inline bool_t lpae_mapping(lpae_t pte) > > +static inline bool lpae_mapping(lpae_t pte) > > { > > return lpae_valid(pte) && !pte.walk.table; > > } > > -- > > 2.11.0 > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > https://lists.xen.org/xen-devel > > >
diff --git a/xen/include/asm-arm/lpae.h b/xen/include/asm-arm/lpae.h index 6fbf7c606c..a62b118630 100644 --- a/xen/include/asm-arm/lpae.h +++ b/xen/include/asm-arm/lpae.h @@ -126,7 +126,7 @@ typedef union { lpae_walk_t walk; } lpae_t; -static inline bool_t lpae_valid(lpae_t pte) +static inline bool lpae_valid(lpae_t pte) { return pte.walk.valid; } @@ -136,12 +136,12 @@ static inline bool_t lpae_valid(lpae_t pte) * the table bit and therefore these would return the opposite to what * you would expect. */ -static inline bool_t lpae_table(lpae_t pte) +static inline bool lpae_table(lpae_t pte) { return lpae_valid(pte) && pte.walk.table; } -static inline bool_t lpae_mapping(lpae_t pte) +static inline bool lpae_mapping(lpae_t pte) { return lpae_valid(pte) && !pte.walk.table; }
We are phasing out the use of bool_t in the hypervisor code. --- Changes in v3: - Patch added --- xen/include/asm-arm/lpae.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)