From patchwork Fri Jul 28 15:26:27 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Roger_Pau_Monn=C3=A9?= X-Patchwork-Id: 9869067 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 554566037D for ; Fri, 28 Jul 2017 15:30:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3FE79288B2 for ; Fri, 28 Jul 2017 15:30:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2ECC6288F1; Fri, 28 Jul 2017 15:30:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 0990D288EA for ; Fri, 28 Jul 2017 15:30:50 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1db7Be-0004yr-Bw; Fri, 28 Jul 2017 15:28:22 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1db7Bd-0004yd-Ib for xen-devel@lists.xenproject.org; Fri, 28 Jul 2017 15:28:21 +0000 Received: from [85.158.139.211] by server-5.bemta-5.messagelabs.com id AF/82-02177-4185B795; Fri, 28 Jul 2017 15:28:20 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrOIsWRWlGSWpSXmKPExsXitHSDva5IRHW kwcTT4hbft0xmcmD0OPzhCksAYxRrZl5SfkUCa8blPd2sBZt4Kibs+sLWwPiZs4uRk0NCwF/i 1sYTrCA2m4COxMW5O9m6GDk4RARUJG7vNQAJMwuESLQe+8IOEhYWiJdonsICEmYRUJW4/P81I 4jNK2ApMbNtDSPERD2JtxNfgNmcAlYSjS/ngU0XAqrZN62HCaJeUOLkzCcsEOM1JVq3/2aHsO UlmrfOZoaoV5Ton/eAbQIj3ywkLbOQtMxC0rKAkXkVo0ZxalFZapGusYFeUlFmekZJbmJmjq6 hgalebmpxcWJ6ak5iUrFecn7uJkZgoNUzMDDuYJywyu8QoyQHk5Io702z6kghvqT8lMqMxOKM +KLSnNTiQ4wyHBxKErxi4UA5waLU9NSKtMwcYMjDpCU4eJREeKXDgNK8xQWJucWZ6RCpU4y6H K8m/P/GJMSSl5+XKiXOawQyQwCkKKM0D24ELP4uMcpKCfMyMjAwCPEUpBblZpagyr9iFOdgVB LmjQeZwpOZVwK36RXQEUxAR0xsqgQ5oiQRISXVwOiy0erZ8jvXGVYKeOV+2C8puEbDdUeDWlh C9HbmX/EflzvaHr/p9yPu3FPDj/+c/u18V3dMmdNiBWub97U2PV+uHRWzThy7Gqmc82qWfGZL 67ab2Q/3OTUnq4h19Fw2tNLYI9puIX3kaPwey/OGi6ujMgxum2jd/uuSErq58+geXh+OnfYdK 5RYijMSDbWYi4oTAQZwvCa6AgAA X-Env-Sender: prvs=375b3df75=roger.pau@citrix.com X-Msg-Ref: server-6.tower-206.messagelabs.com!1501255698!102057352!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 9.4.25; banners=-,-,- X-VirusChecked: Checked Received: (qmail 42103 invoked from network); 28 Jul 2017 15:28:20 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-6.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 28 Jul 2017 15:28:20 -0000 X-IronPort-AV: E=Sophos;i="5.40,425,1496102400"; d="scan'208";a="441766826" From: Roger Pau Monne To: Date: Fri, 28 Jul 2017 16:26:27 +0100 Message-ID: <20170728152637.20301-2-roger.pau@citrix.com> X-Mailer: git-send-email 2.11.0 (Apple Git-81) In-Reply-To: <20170728152637.20301-1-roger.pau@citrix.com> References: <20170728152637.20301-1-roger.pau@citrix.com> MIME-Version: 1.0 Cc: Ian Jackson , Roger Pau Monne Subject: [Xen-devel] [PATCH OSSTEST 01/11] netboot_memdisk: allow each host to have different append values X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Some hosts require "append raw" [0] when booting with memdisk, while others don't. This is based on the hardware/BIOS, and needs to be set on a per-host basis. In order to do this, add a new "MemdiskAppend" host property and make use of it in the setup_netboot_memdisk helper. [0] http://www.syslinux.org/wiki/index.php?title=MEMDISK#Memory_access_method Signed-off-by: Roger Pau Monné --- Changes since v1: - Allow to manually pass append parameters. --- Osstest/TestSupport.pm | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm index b858ac82..c24146c0 100644 --- a/Osstest/TestSupport.pm +++ b/Osstest/TestSupport.pm @@ -2672,8 +2672,11 @@ default local END } -sub setup_netboot_memdisk ($$) { - my ($ho, $img) = @_; +sub setup_netboot_memdisk ($$;$) { + my ($ho, $img, $append) = @_; + + $append //= get_host_property($ho, "MemdiskAppend", ""); + $append = $append ? "append $append" : ""; setup_netboot_bootcfg($ho, <