From patchwork Thu Aug 10 16:45:12 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anthony PERARD X-Patchwork-Id: 9894229 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1F0AF60236 for ; Thu, 10 Aug 2017 16:47:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 10C9F28B53 for ; Thu, 10 Aug 2017 16:47:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0526A28B5A; Thu, 10 Aug 2017 16:47:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7A29B28B59 for ; Thu, 10 Aug 2017 16:47:31 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dfqaF-0004XA-JE; Thu, 10 Aug 2017 16:45:19 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dfqaE-0004Wz-LO for xen-devel@lists.xen.org; Thu, 10 Aug 2017 16:45:18 +0000 Received: from [85.158.139.211] by server-7.bemta-5.messagelabs.com id 82/9B-02176-D9D8C895; Thu, 10 Aug 2017 16:45:17 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprBIsWRWlGSWpSXmKPExsXitHSDve7s3p5 Igyu9IhZLPi5mcWD0OLr7N1MAYxRrZl5SfkUCa8aX9s9MBev4Kn5MqGpg/M3dxcjJISHgL9E2 6S0biM0ioCoxYcVmMJtNwEBixfSrjF2MHBwiAroS364WgISZBdQlJl/5zNzFyMUhLNDCKLHs5 kMWkASvgLXEvLlTmEDqhQSKJJ6eKoIIC0qcnPmEBaJXR2LB7k9sICXMAtISy/9xgIQ5BWwkbh 1pYgKxRQWUJebtWwV2gZCAmsSNhctYJjDyzUIyaRaSSbMQJi1gZF7FqF6cWlSWWqRrqZdUlJm eUZKbmJmja2hgqpebWlycmJ6ak5hUrJecn7uJERhiDECwg3Ftq/MhRkkOJiVR3uJP3ZFCfEn5 KZUZicUZ8UWlOanFhxhlODiUJHjzenoihQSLUtNTK9Iyc4DBDpOW4OBREuENAUnzFhck5hZnp kOkTjEqSonzZoMkBEASGaV5cG2wCLvEKCslzMsIdIgQT0FqUW5mCar8K0ZxDkYlYV4VkCk8mX klcNNfAS1mAloc4dsJsrgkESEl1cAoUXrusO4Ru615P7maK7xN6jRkJgc0WXr+1zI7qObXcCJ XSuzNkq692xMELmbOeazx8HGbxLrHD26YuBy+3y5bXbLa+cQC3l+HZ5+5uMgmT2vKt5SPNROv 1JrnqEe/ZlwYxc8TymS0KGHO7Z5iwxALjvte7zOOTfd8XOr+KvVKpwxb5LNb+p1KLMUZiYZaz EXFiQBP4ENKqwIAAA== X-Env-Sender: prvs=3885c6c1c=anthony.perard@citrix.com X-Msg-Ref: server-13.tower-206.messagelabs.com!1502383513!91242249!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 39259 invoked from network); 10 Aug 2017 16:45:15 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-13.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 10 Aug 2017 16:45:15 -0000 X-IronPort-AV: E=Sophos;i="5.41,353,1498521600"; d="scan'208";a="443358146" Date: Thu, 10 Aug 2017 17:45:12 +0100 From: Anthony PERARD To: Sander Eikelenboom Message-ID: <20170810164512.GH1519@perard.uk.xensource.com> References: <0a5d7da1-7653-a6ab-99be-4e58f1e73f33@eikelenboom.it> <20170810140056.GG1519@perard.uk.xensource.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20170810140056.GG1519@perard.uk.xensource.com> User-Agent: Mutt/1.8.3 (2017-05-23) Cc: xen-devel Subject: Re: [Xen-devel] Xen-unstable / Qemu-upstream: QMP server: Unsupported bus. Bus doesn't have property 'acpi-pcihp-bsel' set X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP On Thu, Aug 10, 2017 at 03:00:56PM +0100, Anthony PERARD wrote: > On Wed, Aug 09, 2017 at 06:34:43PM +0200, Sander Eikelenboom wrote: > > L.S., > > > > It seems the xen qemu-upstream tree got updated from qemu upstream last week. > > Unfortunately a change breaks pci-passthrough for HVM's: > > libxl: error: libxl_qmp.c:287:qmp_handle_error_response: Domain 20:received an error message from QMP server: Unsupported bus. Bus doesn't have property 'acpi-pcihp-bsel' set > > libxl: error: libxl_pci.c:1293:libxl__add_pcidevs: Domain 20:libxl_device_pci_add failed: -3 > > libxl: error: libxl_create.c:1458:domcreate_attach_devices: Domain 20:unable to add pci devices > > libxl: error: libxl_domain.c:1003:libxl__destroy_domid: Domain 20:Non-existant domain > > libxl: error: libxl_domain.c:962:domain_destroy_callback: Domain 20:Unable to destroy guest > > libxl: error: libxl_domain.c:889:domain_destroy_cb: Domain 20:Destruction of domain failed > > > > The culprit is commit: "pc: pcihp: avoid adding ACPI_PCIHP_PROP_BSEL twice" (f0c9d64a68b776374ec4732424a3e27753ce37b6). > > I verified that reverting this commit fixes the issue. > > Thanks, I'll look into this. Can you try with this patch? diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 6b7bade183..8cac3b3de3 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -2857,6 +2857,8 @@ void acpi_setup(void) AcpiBuildState *build_state; Object *vmgenid_dev; + acpi_set_pci_info(); + if (!pcms->fw_cfg) { ACPI_BUILD_DPRINTF("No fw cfg. Bailing out.\n"); return; @@ -2874,8 +2876,6 @@ void acpi_setup(void) build_state = g_malloc0(sizeof *build_state); - acpi_set_pci_info(); - acpi_build_tables_init(&tables); acpi_build(&tables, MACHINE(pcms));