From patchwork Mon Aug 14 07:08:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?SsO8cmdlbiBHcm/Dnw==?= X-Patchwork-Id: 9898233 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B80EE6038C for ; Mon, 14 Aug 2017 07:12:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A7DD028066 for ; Mon, 14 Aug 2017 07:12:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9CC3A28382; Mon, 14 Aug 2017 07:12:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B048F285DA for ; Mon, 14 Aug 2017 07:12:15 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dh9Ul-0003dq-1n; Mon, 14 Aug 2017 07:09:03 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dh9Uj-0003b0-3L for xen-devel@lists.xenproject.org; Mon, 14 Aug 2017 07:09:01 +0000 Received: from [85.158.137.68] by server-2.bemta-3.messagelabs.com id 1C/A2-22472-C8C41995; Mon, 14 Aug 2017 07:09:00 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrELMWRWlGSWpSXmKPExsVyuP0Ov26Pz8R Ig4bJQhbft0xmcmD0OPzhCksAYxRrZl5SfkUCa8avbReZCl5xVEz7e461gXE+excjJ4eEgJHE 24n/mLoYuTiEBBYySix62ckKkmATUJXYcP0UmC0ioCRxb9VkJhCbWaBQ4mR3H1hcWCBFYt3ad WCDWIDqr3x/wwJi8wqYSjze2cIIsUBeouPAZLA4J1D80r6lYLaQgIlE39YulgmM3AsYGVYxah SnFpWlFukameglFWWmZ5TkJmbm6BoaGOvlphYXJ6an5iQmFesl5+duYgT6t56BgXEH46vjfoc YJTmYlER5E3x6I4X4kvJTKjMSizPii0pzUosPMcpwcChJ8M7wnhgpJFiUmp5akZaZAww0mLQE B4+SCO8KkDRvcUFibnFmOkTqFKMux6sJ/78xCbHk5eelSonzPgUpEgApyijNgxsBC/pLjLJSw ryMDAwMQjwFqUW5mSWo8q8YxTkYlYR5P4NM4cnMK4Hb9AroCCagI/pA7uctLklESEk1MPocvu japrpx/YmiD6vml9me9OcvT/zhMC/q8IWcZLawOsMFqpmLhDI5v8VV164tXZSQyXFt9f11s29 Zr05b0HNocuCetJjF51rupfhflddIE7oSpTj1i5SMt2rS2etyiydfSfWKqlP8wrfWqaHunX7f wrlC2vezLSp/pZ30C3DSnbpRreBzqRJLcUaioRZzUXEiAIphnJJ1AgAA X-Env-Sender: jgross@suse.com X-Msg-Ref: server-10.tower-31.messagelabs.com!1502694540!109167085!1 X-Originating-IP: [195.135.220.15] X-SpamReason: No, hits=0.5 required=7.0 tests=BODY_RANDOM_LONG X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 23102 invoked from network); 14 Aug 2017 07:09:00 -0000 Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by server-10.tower-31.messagelabs.com with DHE-RSA-CAMELLIA256-SHA encrypted SMTP; 14 Aug 2017 07:09:00 -0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 07306AD11; Mon, 14 Aug 2017 07:09:00 +0000 (UTC) From: Juergen Gross To: xen-devel@lists.xenproject.org Date: Mon, 14 Aug 2017 09:08:08 +0200 Message-Id: <20170814070849.20986-12-jgross@suse.com> X-Mailer: git-send-email 2.12.3 In-Reply-To: <20170814070849.20986-1-jgross@suse.com> References: <20170814070849.20986-1-jgross@suse.com> Cc: Juergen Gross , Andrew Cooper , Jan Beulich Subject: [Xen-devel] [PATCH v2 11/52] xen/arch/x86/io_apic.c: let custom parameter parsing routines return errno X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Modify the custom parameter parsing routines in: xen/arch/x86/io_apic.c to indicate whether the parameter value was parsed successfully. Cc: Jan Beulich Cc: Andrew Cooper Signed-off-by: Juergen Gross Acked-by: Wei Liu --- xen/arch/x86/io_apic.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/io_apic.c b/xen/arch/x86/io_apic.c index 2838f6bd99..f790579dbd 100644 --- a/xen/arch/x86/io_apic.c +++ b/xen/arch/x86/io_apic.c @@ -1581,7 +1581,7 @@ static unsigned int startup_level_ioapic_irq(struct irq_desc *desc) return 0; /* don't check for pending */ } -static void __init setup_ioapic_ack(char *s) +static int __init setup_ioapic_ack(char *s) { if ( !strcmp(s, "old") ) { @@ -1594,7 +1594,12 @@ static void __init setup_ioapic_ack(char *s) ioapic_ack_forced = true; } else + { printk("Unknown ioapic_ack value specified: '%s'\n", s); + return -EINVAL; + } + + return 0; } custom_param("ioapic_ack", setup_ioapic_ack);