From patchwork Mon Aug 14 07:08:10 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?SsO8cmdlbiBHcm/Dnw==?= X-Patchwork-Id: 9898213 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8B5E460230 for ; Mon, 14 Aug 2017 07:12:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7C0BC28604 for ; Mon, 14 Aug 2017 07:12:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 692E8285CA; Mon, 14 Aug 2017 07:12:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 3B46226E74 for ; Mon, 14 Aug 2017 07:12:15 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dh9Ul-0003es-Pg; Mon, 14 Aug 2017 07:09:03 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dh9Uk-0003bo-3g for xen-devel@lists.xenproject.org; Mon, 14 Aug 2017 07:09:02 +0000 Received: from [193.109.254.147] by server-4.bemta-6.messagelabs.com id 41/AB-02962-D8C41995; Mon, 14 Aug 2017 07:09:01 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrELMWRWlGSWpSXmKPExsVyuP0Ov26Pz8R Ig/0d5hbft0xmcmD0OPzhCksAYxRrZl5SfkUCa8aJ93NYCw5wVkz+94e5gfE6excjJ4eEgJHE 24n/mLoYuTiEBBYySiw795oFJMEmoCqx4fopVhBbREBJ4t6qyUwgNrNAocTJ7j6wuLBAmsT+o 6sYQWwWoPorndvAbF4BU4lZJ99CLZCX6DgwGWwmJ1D80r6lYLaQgIlE39YulgmM3AsYGVYxah SnFpWlFukaGuslFWWmZ5TkJmbm6BoamOnlphYXJ6an5iQmFesl5+duYgT6lwEIdjB+WRZwiFG Sg0lJlDfBpzdSiC8pP6UyI7E4I76oNCe1+BCjDAeHkgSvlPfESCHBotT01Iq0zBxgoMGkJTh4 lER480DSvMUFibnFmekQqVOMuhyvJvz/xiTEkpeflyolzvvMC6hIAKQoozQPbgQs6C8xykoJ8 zICHSXEU5BalJtZgir/ilGcg1FJmJcJZBVPZl4J3KZXQEcwAR3RB3I/b3FJIkJKqoEx46qZy5 PJbavK7x/afGP/U67pvX9nfSjPOHMmbklw+s/7z3iPL53cuvhUbu3PpYpx0+Sy67e3BX7Jy1C fonePeeOmiS9FMk5Muz/zrb7nYqaV3EKvJ0mHGh2YnPV4TucS/b3Mit0/fC6Wrq5W/PghxkCn /4VnmKLyz7Taq2uyk6+HTZiSlf5CQYmlOCPRUIu5qDgRAMb9UcF1AgAA X-Env-Sender: jgross@suse.com X-Msg-Ref: server-5.tower-27.messagelabs.com!1502694540!106165297!1 X-Originating-IP: [195.135.220.15] X-SpamReason: No, hits=0.5 required=7.0 tests=BODY_RANDOM_LONG X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 33382 invoked from network); 14 Aug 2017 07:09:00 -0000 Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by server-5.tower-27.messagelabs.com with DHE-RSA-CAMELLIA256-SHA encrypted SMTP; 14 Aug 2017 07:09:00 -0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 7DB78ABB1; Mon, 14 Aug 2017 07:09:00 +0000 (UTC) From: Juergen Gross To: xen-devel@lists.xenproject.org Date: Mon, 14 Aug 2017 09:08:10 +0200 Message-Id: <20170814070849.20986-14-jgross@suse.com> X-Mailer: git-send-email 2.12.3 In-Reply-To: <20170814070849.20986-1-jgross@suse.com> References: <20170814070849.20986-1-jgross@suse.com> Cc: Juergen Gross , Andrew Cooper , Jan Beulich Subject: [Xen-devel] [PATCH v2 13/52] xen/arch/x86/microcode.c: let custom parameter parsing routines return errno X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Modify the custom parameter parsing routines in: xen/arch/x86/microcode.c to indicate whether the parameter value was parsed successfully. Cc: Jan Beulich Cc: Andrew Cooper Signed-off-by: Juergen Gross Acked-by: Wei Liu --- xen/arch/x86/microcode.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/microcode.c b/xen/arch/x86/microcode.c index 7558202efa..78ea6b53bd 100644 --- a/xen/arch/x86/microcode.c +++ b/xen/arch/x86/microcode.c @@ -73,15 +73,19 @@ void __init microcode_set_module(unsigned int idx) * If the EFI has forced which of the multiboot payloads is to be used, * no parsing will be attempted. */ -static void __init parse_ucode(char *s) +static int __init parse_ucode(char *s) { + const char *q = NULL; + if ( ucode_mod_forced ) /* Forced by EFI */ - return; + return 0; if ( !strncmp(s, "scan", 4) ) ucode_scan = 1; else - ucode_mod_idx = simple_strtol(s, NULL, 0); + ucode_mod_idx = simple_strtol(s, &q, 0); + + return (q && *q) ? -EINVAL : 0; } custom_param("ucode", parse_ucode);