From patchwork Mon Aug 14 07:08:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?SsO8cmdlbiBHcm/Dnw==?= X-Patchwork-Id: 9898263 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0D2DE603B5 for ; Mon, 14 Aug 2017 07:12:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EF5F5274D0 for ; Mon, 14 Aug 2017 07:12:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E3DE22855A; Mon, 14 Aug 2017 07:12:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A44CA285CB for ; Mon, 14 Aug 2017 07:12:15 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dh9Vk-0005w6-3m; Mon, 14 Aug 2017 07:10:04 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dh9Vi-0005hc-RL for xen-devel@lists.xenproject.org; Mon, 14 Aug 2017 07:10:02 +0000 Received: from [85.158.139.211] by server-6.bemta-5.messagelabs.com id E2/E5-02175-ACC41995; Mon, 14 Aug 2017 07:10:02 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrILMWRWlGSWpSXmKPExsVyuP0Ov+5Jn4m RBpMuqlt83zKZyYHR4/CHKywBjFGsmXlJ+RUJrBnvZ59hLpjEVXH5RhdbA+Nb9i5GTg4JASOJ txP/MXUxcnEICSxklPix4B8rSIJNQFViw/VTYLaIgJLEvVWTmUBsZoFCiZPdfWBxYYFEibkbG tlAbBag+h+bHgDVcHDwCphKnJzlDTFfXqLjwGQWEJsTKHxp31IwW0jARKJvaxfLBEbuBYwMqx g1ilOLylKLdI3M9JKKMtMzSnITM3N0DQ1M9XJTi4sT01NzEpOK9ZLzczcxAr1bz8DAuIPx9mS /Q4ySHExKorwJPr2RQnxJ+SmVGYnFGfFFpTmpxYcYZTg4lCR4pbwnRgoJFqWmp1akZeYAwwwm LcHBoyTCmweS5i0uSMwtzkyHSJ1i1OV4NeH/NyYhlrz8vFQpcd4YkCIBkKKM0jy4EbCQv8QoK yXMy8jAwCDEU5BalJtZgir/ilGcg1FJmNcOZApPZl4J3KZXQEcwAR3RB3I/b3FJIkJKqoFx6u /YThfXdqH/z2ZVpDvmTraa+Clmo8vRjUY270QN7C/PS7qcuNv7kIbR9+ccSfXGpk2pvfz31N7 1P/abdmrSsRPRqZfuV9yeOWH3EZcbkkdKDog8va5xKEV9s2P0XaErzsy7rz1ZMKXP8kOIbOCu MM2muFwfGV+j7dsOMhvKP4qc0OJ3Qt5MiaU4I9FQi7moOBEAuyVYYHQCAAA= X-Env-Sender: jgross@suse.com X-Msg-Ref: server-16.tower-206.messagelabs.com!1502694601!91236102!1 X-Originating-IP: [195.135.220.15] X-SpamReason: No, hits=0.5 required=7.0 tests=BODY_RANDOM_LONG X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 5665 invoked from network); 14 Aug 2017 07:10:01 -0000 Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by server-16.tower-206.messagelabs.com with DHE-RSA-CAMELLIA256-SHA encrypted SMTP; 14 Aug 2017 07:10:01 -0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 44F72AD1F; Mon, 14 Aug 2017 07:09:01 +0000 (UTC) From: Juergen Gross To: xen-devel@lists.xenproject.org Date: Mon, 14 Aug 2017 09:08:13 +0200 Message-Id: <20170814070849.20986-17-jgross@suse.com> X-Mailer: git-send-email 2.12.3 In-Reply-To: <20170814070849.20986-1-jgross@suse.com> References: <20170814070849.20986-1-jgross@suse.com> Cc: Juergen Gross , Andrew Cooper , Jan Beulich Subject: [Xen-devel] [PATCH v2 16/52] xen/arch/x86/numa.c: let custom parameter parsing routines return errno X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Modify the custom parameter parsing routines in: xen/arch/x86/numa.c to indicate whether the parameter value was parsed successfully. Cc: Jan Beulich Cc: Andrew Cooper Signed-off-by: Juergen Gross Acked-by: Wei Liu --- xen/arch/x86/numa.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c index d45196fafc..9454f5f9f4 100644 --- a/xen/arch/x86/numa.c +++ b/xen/arch/x86/numa.c @@ -303,10 +303,10 @@ static __init int numa_setup(char *opt) { if ( !strncmp(opt,"off",3) ) numa_off = true; - if ( !strncmp(opt,"on",2) ) + else if ( !strncmp(opt,"on",2) ) numa_off = false; #ifdef CONFIG_NUMA_EMU - if ( !strncmp(opt, "fake=", 5) ) + else if ( !strncmp(opt, "fake=", 5) ) { numa_off = false; numa_fake = simple_strtoul(opt+5,NULL,0); @@ -315,14 +315,16 @@ static __init int numa_setup(char *opt) } #endif #ifdef CONFIG_ACPI_NUMA - if ( !strncmp(opt,"noacpi",6) ) + else if ( !strncmp(opt,"noacpi",6) ) { numa_off = false; acpi_numa = -1; } #endif + else + return -EINVAL; - return 1; + return 0; } /*