From patchwork Mon Aug 14 07:08:17 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?SsO8cmdlbiBHcm/Dnw==?= X-Patchwork-Id: 9898247 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 900B2603B5 for ; Mon, 14 Aug 2017 07:12:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8086826E1A for ; Mon, 14 Aug 2017 07:12:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 75A45285B0; Mon, 14 Aug 2017 07:12:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A0BCD285C6 for ; Mon, 14 Aug 2017 07:12:15 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dh9Vl-00069I-Bi; Mon, 14 Aug 2017 07:10:05 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dh9Vk-0005rb-25 for xen-devel@lists.xenproject.org; Mon, 14 Aug 2017 07:10:04 +0000 Received: from [85.158.139.211] by server-5.bemta-5.messagelabs.com id AF/B2-02177-BCC41995; Mon, 14 Aug 2017 07:10:03 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrELMWRWlGSWpSXmKPExsVyuP0Ov+4pn4m RBlsajS2+b5nM5MDocfjDFZYAxijWzLyk/IoE1oyNz+8zFmzlqrh29TlzA+Mkji5GTg4JASOJ txP/MXUxcnEICSxklDh+u4URJMEmoCqx4fopVhBbREBJ4t6qyUwgNrNAocTJ7j6wuLBAqsTqt mawehag+pu/HrKA2LwCphIHl89jhlggL9FxYDJYnBMofmnfUjBbSMBEom9rF8sERu4FjAyrGD WKU4vKUot0jUz1kooy0zNKchMzc3QNDUz1clOLixPTU3MSk4r1kvNzNzEC/VvPwMC4g3FXu98 hRkkOJiVR3gSf3kghvqT8lMqMxOKM+KLSnNTiQ4wyHBxKErxS3hMjhQSLUtNTK9Iyc4CBBpOW 4OBREuEt9wJK8xYXJOYWZ6ZDpE4x6nK8mvD/G5MQS15+XqqUOO8zkCIBkKKM0jy4EbCgv8QoK yXMy8jAwCDEU5BalJtZgir/ilGcg1FJmLcG5BKezLwSuE2vgI5gAjqiD+R+3uKSRISUVAPjsl c1xbY6OtfWzKjYMqPinWgS21/NqVcat3dynQo8vKJcYX943MtrZp6TdaLWXv977by13NLbQRH xRmej7ifs2Hrn1euoMzYLr72blpThoTZ3zv+9gdorvyureE166CW66TDv9KzoBVcCWbx2yn2W nmCj6Xw69KnLopriqEPH/Ro0Mq9PXWk4Q4mlOCPRUIu5qDgRABc9ko91AgAA X-Env-Sender: jgross@suse.com X-Msg-Ref: server-3.tower-206.messagelabs.com!1502694602!103534765!1 X-Originating-IP: [195.135.220.15] X-SpamReason: No, hits=0.5 required=7.0 tests=BODY_RANDOM_LONG X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 45152 invoked from network); 14 Aug 2017 07:10:02 -0000 Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by server-3.tower-206.messagelabs.com with DHE-RSA-CAMELLIA256-SHA encrypted SMTP; 14 Aug 2017 07:10:02 -0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 69EBCAD11; Mon, 14 Aug 2017 07:09:02 +0000 (UTC) From: Juergen Gross To: xen-devel@lists.xenproject.org Date: Mon, 14 Aug 2017 09:08:17 +0200 Message-Id: <20170814070849.20986-21-jgross@suse.com> X-Mailer: git-send-email 2.12.3 In-Reply-To: <20170814070849.20986-1-jgross@suse.com> References: <20170814070849.20986-1-jgross@suse.com> Cc: Juergen Gross , Andrew Cooper , Jan Beulich Subject: [Xen-devel] [PATCH v2 20/52] xen/arch/x86/shutdown.c: let custom parameter parsing routines return errno X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Modify the custom parameter parsing routines in: xen/arch/x86/shutdown.c to indicate whether the parameter value was parsed successfully. Cc: Jan Beulich Cc: Andrew Cooper Signed-off-by: Juergen Gross Acked-by: Wei Liu --- xen/arch/x86/shutdown.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/shutdown.c b/xen/arch/x86/shutdown.c index f63b8a668f..db9060e5e2 100644 --- a/xen/arch/x86/shutdown.c +++ b/xen/arch/x86/shutdown.c @@ -51,7 +51,7 @@ static int reboot_mode; * efi Use the EFI reboot (if running under EFI) */ static enum reboot_type reboot_type = BOOT_INVALID; -static void __init set_reboot_type(char *str) +static int __init set_reboot_type(char *str) { for ( ; ; ) { @@ -74,6 +74,8 @@ static void __init set_reboot_type(char *str) case 't': reboot_type = *str; break; + default: + return -EINVAL; } if ( (str = strchr(str, ',')) == NULL ) break; @@ -82,6 +84,8 @@ static void __init set_reboot_type(char *str) if ( reboot_type == BOOT_EFI && !efi_enabled(EFI_RS) ) reboot_type = BOOT_INVALID; + + return 0; } custom_param("reboot", set_reboot_type);