From patchwork Mon Aug 14 07:08:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?SsO8cmdlbiBHcm/Dnw==?= X-Patchwork-Id: 9898235 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CB096603B5 for ; Mon, 14 Aug 2017 07:12:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BDC8527D16 for ; Mon, 14 Aug 2017 07:12:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B3596285B0; Mon, 14 Aug 2017 07:12:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B5288285E3 for ; Mon, 14 Aug 2017 07:12:15 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dh9Vp-0006N5-Oi; Mon, 14 Aug 2017 07:10:09 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dh9Vn-0006BI-Vy for xen-devel@lists.xenproject.org; Mon, 14 Aug 2017 07:10:08 +0000 Received: from [193.109.254.147] by server-6.bemta-6.messagelabs.com id 7B/5B-03937-FCC41995; Mon, 14 Aug 2017 07:10:07 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrELMWRWlGSWpSXmKPExsVyuP0Ov+55n4m RBqfeC1p83zKZyYHR4/CHKywBjFGsmXlJ+RUJrBl//q9mL1jHVbHsyHLWBsZpHF2MnBwSAkYS byf+Y+pi5OIQEljIKPH483t2kASbgKrEhuunWEFsEQEliXurJjOB2MwC7hIb3zWxgNjCAkUS9 1fNZgSxWYDqj7xtAqvnFTCVeLr8IQvEAnmJjgOTwWxOoPilfUvBbCEBE4m+rV0sExi5FzAyrG LUKE4tKkst0jU20ksqykzPKMlNzMzRNTQw08tNLS5OTE/NSUwq1kvOz93ECPQvAxDsYDy9LvA QoyQHk5Iob4JPb6QQX1J+SmVGYnFGfFFpTmrxIUYZDg4lCV4p74mRQoJFqempFWmZOcBAg0lL cPAoifCWewGleYsLEnOLM9MhUqcYdTleTfj/jUmIJS8/L1VKnDcGZIYASFFGaR7cCFjQX2KUl RLmZQQ6SoinILUoN7MEVf4VozgHo5IwLxPIFJ7MvBK4Ta+AjmACOqIP5H7e4pJEhJRUA6P189 g2cT/3bcJ+i/N3rrm281Xj69Q39zhnHFu3ZV/TmcR5afKmh9rKXupdyG06e0SEx/6a/tPtMxS WvPc+/STbMFxcVn9K4lRPTe/LdzvnLnhyJUi4MT5QJK1tqfbO3C8HZgYX3c+1t25b8ol/vsyh T+qh8f7xx6SiN96r+PVcKketLdLhxgclluKMREMt5qLiRABMgBrHdQIAAA== X-Env-Sender: jgross@suse.com X-Msg-Ref: server-3.tower-27.messagelabs.com!1502694607!111358470!1 X-Originating-IP: [195.135.220.15] X-SpamReason: No, hits=0.5 required=7.0 tests=BODY_RANDOM_LONG X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 44462 invoked from network); 14 Aug 2017 07:10:07 -0000 Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by server-3.tower-27.messagelabs.com with DHE-RSA-CAMELLIA256-SHA encrypted SMTP; 14 Aug 2017 07:10:07 -0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id D3CEBAD4B; Mon, 14 Aug 2017 07:09:06 +0000 (UTC) From: Juergen Gross To: xen-devel@lists.xenproject.org Date: Mon, 14 Aug 2017 09:08:33 +0200 Message-Id: <20170814070849.20986-37-jgross@suse.com> X-Mailer: git-send-email 2.12.3 In-Reply-To: <20170814070849.20986-1-jgross@suse.com> References: <20170814070849.20986-1-jgross@suse.com> Cc: Juergen Gross , Kevin Tian Subject: [Xen-devel] [PATCH v2 36/52] xen/drivers/passthrough/vtd/quirks.c: let custom parameter parsing routines return errno X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Modify the custom parameter parsing routines in: xen/drivers/passthrough/vtd/quirks.c to indicate whether the parameter value was parsed successfully. Cc: Kevin Tian Signed-off-by: Juergen Gross Acked-by: Wei Liu --- xen/drivers/passthrough/vtd/quirks.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/xen/drivers/passthrough/vtd/quirks.c b/xen/drivers/passthrough/vtd/quirks.c index 5bbbd96d51..4e61ac9ddb 100644 --- a/xen/drivers/passthrough/vtd/quirks.c +++ b/xen/drivers/passthrough/vtd/quirks.c @@ -247,9 +247,10 @@ void vtd_ops_postamble_quirk(struct iommu* iommu) } } -static void __init parse_snb_timeout(const char *s) +static int __init parse_snb_timeout(const char *s) { int t; + const char *q = NULL; t = parse_bool(s); if ( t < 0 ) @@ -259,13 +260,13 @@ static void __init parse_snb_timeout(const char *s) else if ( strcmp(s, "cap") == 0 ) t = SNB_IGD_TIMEOUT; else - t = strtoul(s, NULL, 0); + t = strtoul(s, &q, 0); } else t = t ? SNB_IGD_TIMEOUT_LEGACY : 0; snb_igd_timeout = MILLISECS(t); - return; + return (q && *q) ? -EINVAL : 0; } custom_param("snb_igd_quirk", parse_snb_timeout);