From patchwork Mon Aug 14 07:08:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?SsO8cmdlbiBHcm/Dnw==?= X-Patchwork-Id: 9898179 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 83E4B60230 for ; Mon, 14 Aug 2017 07:11:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 74A9626E1A for ; Mon, 14 Aug 2017 07:11:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 68C3A27F85; Mon, 14 Aug 2017 07:11:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C923426E1A for ; Mon, 14 Aug 2017 07:11:05 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dh9Uu-0003rr-8a; Mon, 14 Aug 2017 07:09:12 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dh9Us-0003nd-Gz for xen-devel@lists.xenproject.org; Mon, 14 Aug 2017 07:09:10 +0000 Received: from [85.158.137.68] by server-5.bemta-3.messagelabs.com id 18/B6-02181-59C41995; Mon, 14 Aug 2017 07:09:09 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrELMWRWlGSWpSXmKPExsVyuP0Ov+5Un4m RBgs3sFt83zKZyYHR4/CHKywBjFGsmXlJ+RUJrBmTFk5gLDjDU7F5xg72BsZ2ri5GTg4JASOJ txP/MXUxcnEICSxklHi27ycTSIJNQFViw/VTrCC2iICSxL1Vk8GKmAVmMUos2zybESQhLBAt8 ez0fKAiDg4WoIZPf81BwrwCpkDmG1aIBfISHQcms4DYnEDxS/uWgtlCAiYSfVu7WCYwci9gZF jFqFGcWlSWWqRrZKSXVJSZnlGSm5iZo2toYKyXm1pcnJiempOYVKyXnJ+7iRHo33oGBsYdjFN P+B1ilORgUhLlTfDpjRTiS8pPqcxILM6ILyrNSS0+xCjDwaEkwTvDe2KkkGBRanpqRVpmDjDQ YNISHDxKIrwrQNK8xQWJucWZ6RCpU4y6HK8m/P/GJMSSl5+XKiXOGwNSJABSlFGaBzcCFvSXG GWlhHkZGRgYhHgKUotyM0tQ5V8xinMwKgnzfgaZwpOZVwK36RXQEUxAR/SB3M9bXJKIkJJqYG z6aldzyE7GNvh076Lm2QaXtZ/9eKXXFpJe0zdNLTb5oOYFy+nmm86y7J749GRI/ozZjd8bvy0 J0z1veXbXHVtz5r6F90oC78hrSizY7GD/4eZ0icyyJ/8Va26+m/JFvXvFfNao2SIbBU6URhUs uyHTYzb1wZfGXdt95vr83yh4zrtR5tajSS5KLMUZiYZazEXFiQA+pz0OdQIAAA== X-Env-Sender: jgross@suse.com X-Msg-Ref: server-14.tower-31.messagelabs.com!1502694548!109701352!1 X-Originating-IP: [195.135.220.15] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 21227 invoked from network); 14 Aug 2017 07:09:09 -0000 Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by server-14.tower-31.messagelabs.com with DHE-RSA-CAMELLIA256-SHA encrypted SMTP; 14 Aug 2017 07:09:09 -0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id D3F72ABD9; Mon, 14 Aug 2017 07:09:08 +0000 (UTC) From: Juergen Gross To: xen-devel@lists.xenproject.org Date: Mon, 14 Aug 2017 09:08:39 +0200 Message-Id: <20170814070849.20986-43-jgross@suse.com> X-Mailer: git-send-email 2.12.3 In-Reply-To: <20170814070849.20986-1-jgross@suse.com> References: <20170814070849.20986-1-jgross@suse.com> Cc: Juergen Gross , Andrew Cooper , Paul Durrant , Jan Beulich Subject: [Xen-devel] [PATCH v2 42/52] xen/arch/x86/hvm/viridian.c: remove custom_param() error messages X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP With _cmdline_parse() now issuing error messages in case of illegal parameters signalled by parsing functions specified in custom_param() the message issued by parse_viridian_version() can be removed. Cc: Paul Durrant Cc: Jan Beulich Cc: Andrew Cooper Signed-off-by: Juergen Gross Reviewed-by: Paul Durrant --- xen/arch/x86/hvm/viridian.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/xen/arch/x86/hvm/viridian.c b/xen/arch/x86/hvm/viridian.c index 6f012bcb62..b15556b98b 100644 --- a/xen/arch/x86/hvm/viridian.c +++ b/xen/arch/x86/hvm/viridian.c @@ -1102,15 +1102,15 @@ static int __init parse_viridian_version(char *arg) n[i++] = simple_strtoul(t, &e, 0); if ( *e != '\0' ) - goto fail; + return -EINVAL; } if ( i != 3 ) - goto fail; + return -EINVAL; if ( ((typeof(viridian_major))n[0] != n[0]) || ((typeof(viridian_minor))n[1] != n[1]) || ((typeof(viridian_build))n[2] != n[2]) ) - goto fail; + return -EINVAL; viridian_major = n[0]; viridian_minor = n[1]; @@ -1119,10 +1119,6 @@ static int __init parse_viridian_version(char *arg) printk("viridian-version = %#x,%#x,%#x\n", viridian_major, viridian_minor, viridian_build); return 0; - - fail: - printk(XENLOG_WARNING "Invalid viridian-version, using default\n"); - return -EINVAL; } custom_param("viridian-version", parse_viridian_version);