From patchwork Mon Aug 14 14:23:52 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 9899013 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 765AC603B5 for ; Mon, 14 Aug 2017 14:27:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 689CD284D1 for ; Mon, 14 Aug 2017 14:27:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5B3B62868C; Mon, 14 Aug 2017 14:27:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 15C862867D for ; Mon, 14 Aug 2017 14:27:19 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhGIF-0000Af-G4; Mon, 14 Aug 2017 14:24:35 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhGID-0000A9-9L for xen-devel@lists.xen.org; Mon, 14 Aug 2017 14:24:33 +0000 Received: from [85.158.143.35] by server-4.bemta-6.messagelabs.com id D4/5A-02962-0A2B1995; Mon, 14 Aug 2017 14:24:32 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrJLMWRWlGSWpSXmKPExsVysyfVTXfBpom RBht6eS2WfFzM4sDocXT3b6YAxijWzLyk/IoE1ox7i9+yFKxir+i9voapgfE1axcjF4eQwGZG iSvz1zJDOKcZJR6cXsnUxcjJwSagKXHn8ycwW0RAWuLa58uMIEXMAssZJTbsX8EOkhAW8JTYu XYvSxcjBweLgKrEhF+GIGFeAUuJhxNfM4LYEgLyErvaLrKC2JwCVhKdd3eygNhCQDUnVs9mm8 DIvYCRYRWjRnFqUVlqka6RmV5SUWZ6RkluYmaOrqGBmV5uanFxYnpqTmJSsV5yfu4mRqCHGYB gB+OZBYGHGCU5mJREeRN8eiOF+JLyUyozEosz4otKc1KLDzHKcHAoSfCmbpwYKSRYlJqeWpGW mQMMNZi0BAePkgjvDZA0b3FBYm5xZjpE6hSjMUfThy1fmDheTfj/jUmIJS8/L1VKnLccpFQAp DSjNA9uECwGLjHKSgnzMgKdJsRTkFqUm1mCKv+KUZyDUUmYdzPIFJ7MvBK4fa+ATmECOqUP5A ve4pJEhJRUA+ODaJc18wVvunWb2mUWb+xOLZbJZjoXpPScJcrE1aNENt1swiPZuMvXV/1fe+1 h1uJZAe1Oz18v+2V0KHtDya/tL4tZast1nimrZNUpFYdYnX5emW+5O8Y29CmTkHXpg1+vDvYL clbcsi9301yfcyJov8WkCc1SZq/2H7DY+fibsHdF9NrDD5RYijMSDbWYi4oTATAafmJ8AgAA X-Env-Sender: julien.grall@arm.com X-Msg-Ref: server-11.tower-21.messagelabs.com!1502720671!74726571!1 X-Originating-IP: [217.140.101.70] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 41988 invoked from network); 14 Aug 2017 14:24:32 -0000 Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by server-11.tower-21.messagelabs.com with SMTP; 14 Aug 2017 14:24:32 -0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7CF2615A2; Mon, 14 Aug 2017 07:24:31 -0700 (PDT) Received: from e108454-lin.cambridge.arm.com (e108454-lin.cambridge.arm.com [10.1.206.53]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4A1213F483; Mon, 14 Aug 2017 07:24:30 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xen.org Date: Mon, 14 Aug 2017 15:23:52 +0100 Message-Id: <20170814142418.13267-2-julien.grall@arm.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170814142418.13267-1-julien.grall@arm.com> References: <20170814142418.13267-1-julien.grall@arm.com> Cc: andre.przywara@arm.com, Julien Grall , sstabellini@kernel.org, Jan Beulich , Andrew Cooper Subject: [Xen-devel] [PATCH 01/27] xen/x86: numa: Don't check alloc_boot_pages return X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP alloc_boot_pages will panic if it is not possible to allocate. So the check in the caller is pointless. Signed-off-by: Julien Grall Reviewed-by: Andre Przywara --- Cc: Jan Beulich Cc: Andrew Cooper --- xen/arch/x86/numa.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c index d45196fafc..ffeba6e180 100644 --- a/xen/arch/x86/numa.c +++ b/xen/arch/x86/numa.c @@ -101,14 +101,6 @@ static int __init allocate_cachealigned_memnodemap(void) unsigned long size = PFN_UP(memnodemapsize * sizeof(*memnodemap)); unsigned long mfn = alloc_boot_pages(size, 1); - if ( !mfn ) - { - printk(KERN_ERR - "NUMA: Unable to allocate Memory to Node hash map\n"); - memnodemapsize = 0; - return -1; - } - memnodemap = mfn_to_virt(mfn); mfn <<= PAGE_SHIFT; size <<= PAGE_SHIFT;