From patchwork Mon Aug 14 14:23:53 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 9899021 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2D30E602CA for ; Mon, 14 Aug 2017 14:27:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1D6B328558 for ; Mon, 14 Aug 2017 14:27:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 125A828573; Mon, 14 Aug 2017 14:27:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id BA5F5285FF for ; Mon, 14 Aug 2017 14:27:18 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhGIG-0000CC-Ql; Mon, 14 Aug 2017 14:24:36 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhGIF-0000Ae-UY for xen-devel@lists.xen.org; Mon, 14 Aug 2017 14:24:36 +0000 Received: from [85.158.137.68] by server-2.bemta-3.messagelabs.com id E5/21-22472-3A2B1995; Mon, 14 Aug 2017 14:24:35 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrFLMWRWlGSWpSXmKPExsVysyfVTXfRpom RBlf3alks+biYxYHR4+ju30wBjFGsmXlJ+RUJrBm/v01jKjjNVvFw4ga2BsbTrF2MXBxCApsZ JRaub2KHcE4zSrRevA3kcHKwCWhK3Pn8iQnEFhGQlrj2+TIjSBGzwHJGiQ37V4AVCQt4Ssxuv 8YIYrMIqEq8PXYHzOYVsJRYfvAYG4gtISAvsavtIiuIzSlgJdF5dycLiC0EVHNi9Wy2CYzcCx gZVjFqFKcWlaUW6RoZ6SUVZaZnlOQmZuboGhoY6+WmFhcnpqfmJCYV6yXn525iBPq4noGBcQf j1BN+hxglOZiURHkTfHojhfiS8lMqMxKLM+KLSnNSiw8xynBwKEnw3tg4MVJIsCg1PbUiLTMH GGwwaQkOHiUR3lkgad7igsTc4sx0iNQpRmOOpg9bvjBxvJrw/xuTEEtefl6qlDhvOUipAEhpR mke3CBYFFxilJUS5mVkYGAQ4ilILcrNLEGVf8UozsGoJMxbCTKFJzOvBG7fK6BTmIBO6QP5gr e4JBEhJdXAmK9lfPDM+9hNZ3Rnz39ak1z/TuPalO5lz99VtjDlBO3q5NjyTp+9T+yUzL5C68R b+++3pV6oOnLjZWiKzOfZl0LmzfjBzzMhY/WNbH+R8w1SLOaLn0S8+soh9cu6etkmsZ0nVTyE Km4nnHZd4KVsx5JTUdudoflH6Omf6msH7BSEHmfMzK1KVmIpzkg01GIuKk4EANYmj9B9AgAA X-Env-Sender: julien.grall@arm.com X-Msg-Ref: server-14.tower-31.messagelabs.com!1502720674!109784799!1 X-Originating-IP: [217.140.101.70] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 45832 invoked from network); 14 Aug 2017 14:24:34 -0000 Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by server-14.tower-31.messagelabs.com with SMTP; 14 Aug 2017 14:24:34 -0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EEA92164F; Mon, 14 Aug 2017 07:24:32 -0700 (PDT) Received: from e108454-lin.cambridge.arm.com (e108454-lin.cambridge.arm.com [10.1.206.53]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BBEB13F483; Mon, 14 Aug 2017 07:24:31 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xen.org Date: Mon, 14 Aug 2017 15:23:53 +0100 Message-Id: <20170814142418.13267-3-julien.grall@arm.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170814142418.13267-1-julien.grall@arm.com> References: <20170814142418.13267-1-julien.grall@arm.com> Cc: andre.przywara@arm.com, Julien Grall , sstabellini@kernel.org, Jan Beulich , Andrew Cooper Subject: [Xen-devel] [PATCH 02/27] xen/x86: srat: Don't check alloc_boot_pages return X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP alloc_boot_pages will panic if it is not possible to allocate. So the check in the caller is pointless. Signed-off-by: Julien Grall Reviewed-by: Andre Przywara --- Cc: Jan Beulich Cc: Andrew Cooper --- xen/arch/x86/srat.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c index cd1283e58c..95660a9bbc 100644 --- a/xen/arch/x86/srat.c +++ b/xen/arch/x86/srat.c @@ -194,11 +194,6 @@ void __init acpi_numa_slit_init(struct acpi_table_slit *slit) return; } mfn = alloc_boot_pages(PFN_UP(slit->header.length), 1); - if (!mfn) { - printk(KERN_ERR "ACPI: Unable to allocate memory for " - "saving ACPI SLIT numa information.\n"); - return; - } acpi_slit = mfn_to_virt(mfn); memcpy(acpi_slit, slit, slit->header.length); }