From patchwork Wed Sep 20 20:57:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tamas K Lengyel X-Patchwork-Id: 9962591 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B81B66056D for ; Wed, 20 Sep 2017 21:00:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AA50229244 for ; Wed, 20 Sep 2017 21:00:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A42762925B; Wed, 20 Sep 2017 21:00:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C373F29249 for ; Wed, 20 Sep 2017 21:00:34 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dum4Q-0007q3-TB; Wed, 20 Sep 2017 20:58:10 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dum4P-0007po-Gi for xen-devel@lists.xenproject.org; Wed, 20 Sep 2017 20:58:09 +0000 Received: from [85.158.139.211] by server-6.bemta-5.messagelabs.com id 10/EE-27708-066D2C95; Wed, 20 Sep 2017 20:58:08 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrHIsWRWlGSWpSXmKPExsVyMfT+Ed2Ea4c iDfY3c1l83zKZyYHR4/CHKywBjFGsmXlJ+RUJrBkTNm5jK/jGUfGq8xhzA+NS9i5GLg4hgemM Elf6dzODOBIC/awSrztmMXUxcgI5WRJLF3SxQNhpEu/vr4ayyyU+7H7DDGILCWhI3L7ZyA5hT 2GS2LKwGsRmE9CWaHu9ixXEFhFQkri3ajLQTA4OZgFfiV17+EDCwgJhEmsOnQBrZRFQlWi4+o 8NpIRXwELi1yWoC+QldrVdZAUJcwpYStzargyxyELiaucHtgmMAgsYGVYxahSnFpWlFukaWeo lFWWmZ5TkJmbm6BoamOrlphYXJ6an5iQmFesl5+duYgSGVD0DA+MOxstb/A4xSnIwKYnyHrxy KFKILyk/pTIjsTgjvqg0J7X4EKMMB4eSBK/tVaCcYFFqempFWmYOMLhh0hIcPEoivEYgad7ig sTc4sx0iNQpRnuOC3cu/WHiaOi5ASQP7LkFJDtu3v3DJMSSl5+XKiXOawPSJgDSllGaBzcUFo 2XGGWlhHkZGRgYhHgKUotyM0tQ5V8xinMwKgnzZoNM4cnMK4Hb/QroLCags7I3HAA5qyQRISX VwMjOcsCnUf0Wd7a0Qbcgh9ysGO6dfldXfp7QUtP49IV/ps5cjVtOXEGTt71drhnIvfuL77q5 Te6n5IqqFLbvMDd62eYcKtnleyd9/g6BF5JTbtzTz3i7lzkrX/jJjCuhGl5Ft379m3TK9AoD1 926n4HiXK4u3Ev/tb6P+hZcqHviaMKC2Guyu5VYijMSDbWYi4oTAfsUK/3BAgAA X-Env-Sender: tamas.k.lengyel@gmail.com X-Msg-Ref: server-15.tower-206.messagelabs.com!1505941087!98490054!1 X-Originating-IP: [209.85.223.196] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 7339 invoked from network); 20 Sep 2017 20:58:08 -0000 Received: from mail-io0-f196.google.com (HELO mail-io0-f196.google.com) (209.85.223.196) by server-15.tower-206.messagelabs.com with AES128-GCM-SHA256 encrypted SMTP; 20 Sep 2017 20:58:08 -0000 Received: by mail-io0-f196.google.com with SMTP id 93so3126729iol.4 for ; Wed, 20 Sep 2017 13:58:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=oZI5DYvQp1H3/E1d/XmJ8qKK1n//A+pGQ9YpSf0py38=; b=no9egVfQT6uWG3aFzd4Tb6E753WDHkmp0He3/ieyAk2ZZeZdR20NYwGQhK3fnFM4Rh OKjDcM0DutyuFOjul0vm+6rBvetKMJGqAB2KIMU4Y1wS5t0PaJY3rVi24xZvvNj3gR6Y h7ihDm/mhIZpbN8YUgK5wJ3vBtD0+K9coYflf8v1mEqdcmMBJyNIVGhrsCKz66zQw60u XFPdMpk9haSKE0wSYs3eg0NDo0DRDBnBEpaMB0gMDuoBjb9y3unfRwbjyLL4tr/6p405 t9YSdBZn4P/3yCdM5A/FyoP5td02NEvc6a9VSlWCrvmLc1eamfD7NSg09Q3S/8FWLCOB rGFw== X-Gm-Message-State: AHPjjUgzk8eOrrNZJ9R3Z6g/wFEdIBdpjQlM/Od7kij+Fi3rU6Uh8wZD uBN0isaUnjw/nvX1odkgqnfOC9B8 X-Google-Smtp-Source: AOwi7QA/fi8wrIOlSF6TbQPzIO/Jax5UR7IuMYNJ7PyRvhZxBPcT2itsWCdn85sVsEr4wNoy4ptomw== X-Received: by 10.107.9.90 with SMTP id j87mr250166ioi.111.1505941086318; Wed, 20 Sep 2017 13:58:06 -0700 (PDT) Received: from drtais0.lan (c-24-9-60-130.hsd1.co.comcast.net. [24.9.60.130]) by smtp.gmail.com with ESMTPSA id e78sm56957itd.36.2017.09.20.13.58.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Sep 2017 13:58:05 -0700 (PDT) From: Tamas K Lengyel To: xen-devel@lists.xenproject.org Date: Wed, 20 Sep 2017 14:57:18 -0600 Message-Id: <20170920205718.17747-2-tamas@tklengyel.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170920205718.17747-1-tamas@tklengyel.com> References: <20170920205718.17747-1-tamas@tklengyel.com> Cc: Jan Beulich , Tamas K Lengyel Subject: [Xen-devel] [PATCH 2/2] common/efi: give people some time to read messages when debugging X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Tamas K Lengyel The EFI messages flash by so fast that it is impossible to catch them without a serial debugger attached. Sometimes though we don't have that available so having some time to read the messages off the screen is valuable. Signed-off-by: Tamas K Lengyel Cc: Jan Beulich --- xen/common/efi/boot.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c index a3a439b838..1bce148bd9 100644 --- a/xen/common/efi/boot.c +++ b/xen/common/efi/boot.c @@ -321,6 +321,11 @@ static void __init noreturn blexit(const CHAR16 *str) PrintStr((CHAR16 *)str); PrintStr(newline); +#ifndef NDEBUG + if ( efi_bs ) + efi_bs->Stall(5000000); +#endif + if ( !efi_bs ) efi_arch_halt(); @@ -1300,6 +1305,10 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable) if ( gop ) efi_set_gop_mode(gop, gop_mode); +#ifndef NDEBUG + efi_bs->Stall(5000000); +#endif + efi_exit_boot(ImageHandle, SystemTable); efi_arch_post_exit_boot();