| Message ID | 20170928103625.896-3-wei.liu2@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
> -----Original Message----- > From: Wei Liu [mailto:wei.liu2@citrix.com] > Sent: 28 September 2017 11:36 > To: Xen-devel <xen-devel@lists.xenproject.org> > Cc: Anthony Perard <anthony.perard@citrix.com>; Wei Liu > <wei.liu2@citrix.com>; Ian Jackson <Ian.Jackson@citrix.com>; Paul Durrant > <Paul.Durrant@citrix.com> > Subject: [PATCH v2 2/2] libxendevicemodel: initialise extent to zero > > The pad field needs to be zero as required by the hypervisor. > > Instead of setting the pad separately, use C99 initialiser to clear > extent. > > Signed-off-by: Wei Liu <wei.liu2@citrix.com> > --- > Cc: Ian Jackson <ian.jackson@eu.citrix.com> > Cc: Paul Durrant <paul.durrant@citrix.com> > > Backport to 4.9 > --- > tools/libs/devicemodel/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/libs/devicemodel/core.c b/tools/libs/devicemodel/core.c > index fcb260d29b..986f147658 100644 > --- a/tools/libs/devicemodel/core.c > +++ b/tools/libs/devicemodel/core.c > @@ -483,7 +483,7 @@ int xendevicemodel_modified_memory( > xendevicemodel_handle *dmod, domid_t domid, uint64_t first_pfn, > uint32_t nr) > { > - struct xen_dm_op_modified_memory_extent extent; > + struct xen_dm_op_modified_memory_extent extent = { }; Not quite. I meant: struct xen_dm_op_modified_memory_extent extent = { .first_pfn = first_pfn, .nr = nr, }; then you can drop the lines below. Paul > > extent.first_pfn = first_pfn; > extent.nr = nr; > -- > 2.11.0
diff --git a/tools/libs/devicemodel/core.c b/tools/libs/devicemodel/core.c index fcb260d29b..986f147658 100644 --- a/tools/libs/devicemodel/core.c +++ b/tools/libs/devicemodel/core.c @@ -483,7 +483,7 @@ int xendevicemodel_modified_memory( xendevicemodel_handle *dmod, domid_t domid, uint64_t first_pfn, uint32_t nr) { - struct xen_dm_op_modified_memory_extent extent; + struct xen_dm_op_modified_memory_extent extent = { }; extent.first_pfn = first_pfn; extent.nr = nr;
The pad field needs to be zero as required by the hypervisor. Instead of setting the pad separately, use C99 initialiser to clear extent. Signed-off-by: Wei Liu <wei.liu2@citrix.com> --- Cc: Ian Jackson <ian.jackson@eu.citrix.com> Cc: Paul Durrant <paul.durrant@citrix.com> Backport to 4.9 --- tools/libs/devicemodel/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)