From patchwork Wed Oct 4 21:19:52 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Garnier X-Patchwork-Id: 9985533 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DEEF660586 for ; Wed, 4 Oct 2017 21:23:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CE83D28C2C for ; Wed, 4 Oct 2017 21:23:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C23FD28C31; Wed, 4 Oct 2017 21:23:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, RCVD_IN_DNSWL_MED, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8E6FF28C2C for ; Wed, 4 Oct 2017 21:23:11 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzr6V-00036k-Ru; Wed, 04 Oct 2017 21:21:19 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzr6U-000347-VI for xen-devel@lists.xenproject.org; Wed, 04 Oct 2017 21:21:19 +0000 Received: from [85.158.137.68] by server-2.bemta-3.messagelabs.com id B0/BE-02041-EC055D95; Wed, 04 Oct 2017 21:21:18 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrKIsWRWlGSWpSXmKPExsXiVRtsqHs24Gq kQfs8ZovvWyYzOTB6HP5whSWAMYo1My8pvyKBNWN7RydLwVLVinU9y1gaGP/JdjFycQgJzGSU +L+igx3EYRF4xSLx8NQsZhBHQqCfVeLLg89ADieQkyXx/Ps7Jgg7TWL32odsEHaVxNruySwgt pCAksTWDUuZIcb+ZZSYf/8lWAObgJbEnob5TCAJEYFZIhK3XvewgTjMAmeYJI73nWQFqRIWsJ KY8vQdO4jNIqAqsePra0YQm1fAUuLVy2tQq00kHh65BlbPCRQ/cuINM8RqC4nWM/eZJjAKLmB kWMWoUZxaVJZapGtkqZdUlJmeUZKbmJmja2hgrJebWlycmJ6ak5hUrJecn7uJERh49QwMjDsY m/b6HWKU5GBSEuXd5Hs1UogvKT+lMiOxOCO+qDQntfgQowwHh5IELycwkIUEi1LTUyvSMnOAM QCTluDgURLh5QdJ8xYXJOYWZ6ZDpE4xGnPs23PrDxNHx827f5iEWPLy81KlxHk3+wOVCoCUZp TmwQ2CxeYlRlkpYV5GBgYGIZ6C1KLczBJU+VeM4hyMSsK8siALeTLzSuD2vQI6hQnolDlNV0B OKUlESEk1MHJ55dSYb4yY5Fj6c5n2/GvSxbY+NiVLs9n0lb45pL3lPrXt80rLF+ez/vRN0Sq8 rb9736kuvWdh+9ofHPg8x3SHzQ3ptMe2bC2P9m+OyFnnZHsqoPjnn0KbH193Cfrsq7pZEXLnz /Wit5eXHJB8fMyZ4+7nEMfjr9O2RQizZTKbbv/HIGWSyKXEUpyRaKjFXFScCAAao/mzyAIAAA == X-Env-Sender: thgarnie@google.com X-Msg-Ref: server-12.tower-31.messagelabs.com!1507152075!101144730!1 X-Originating-IP: [74.125.83.49] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 54491 invoked from network); 4 Oct 2017 21:21:16 -0000 Received: from mail-pg0-f49.google.com (HELO mail-pg0-f49.google.com) (74.125.83.49) by server-12.tower-31.messagelabs.com with AES128-GCM-SHA256 encrypted SMTP; 4 Oct 2017 21:21:16 -0000 Received: by mail-pg0-f49.google.com with SMTP id c137so7166083pga.11 for ; Wed, 04 Oct 2017 14:21:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Sg/RqMfrN195pouS2/TQAS39jn3ubxi9dBE9AGWHJ5A=; b=rAZmPTP1V8+kIVcsIamvp85V7BzQ7t2zRou+vcZlngjkVgB1nTVggtOpMl5anXi+58 TrL43YP/i5Ylddz7K6i6U2EwWFSmfJhtFELsMcELZIwRaR7kuhbUNrFiVu4UYIYCkpOZ AcGPwvzth6mrEwJDD/jPesx31TGTPuV39ayg54LA+pOZ974FHHS7nxsgPpAaFOfyOlM4 vlts+VBeADDcP1KqHEv29NHw9x2UIGfteQ9jstSTXQI0+nTqmsb0ftiXjmg9d8qOg/QQ YXroCc3walHrJcYs5RJURYX8yoev/CcLW2jVPJUcyOVTLIunP2RbFQVXCnW/mHW4N/Pj Eo6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Sg/RqMfrN195pouS2/TQAS39jn3ubxi9dBE9AGWHJ5A=; b=V+CTso855giYb60eCH687QCZeA47bywwWmmTSQYNn9kZKx6gpSK2L+gsmG+bMfI2bm E4ZNSf+hDjqf9ZuSEmPforhXKhB84uH5Wfhxbf5TS4AAKnnAT9bfcCc7cP9kkKN7Dkhk xzBvhMGHmI4QUkpjTtbZyrN0LthftzKo0do7c2jWAaxUxXVmVh3i+S2TUbt2EywjXx1O D4tbt82Uns6NSv2wKzwtESccu9SDI0N/+Fs6iPz3gcqD1xkbGcspevpuEiJcJxE5RI8A hXVIrevHP1QTDBu+H6qOYtDziDW00XLDvcmoh3/gxsSuDjcac6S8ZlZY8JaqmfC9DGp+ Eu5A== X-Gm-Message-State: AHPjjUgWD3J5YMLuvn/xmWaPQkS6cZkELQ5+tFK6R2w4n3xGLQ5Mof7C 0oDkG8IqDTG1QBYErv2Djtj4aQ== X-Google-Smtp-Source: AOwi7QDGxOhvMPD1Dguh4oiz8ITQ7S3qAYlzuQr+VFjJdZMEoVaYJdXRrjqrD/URKSKacT/OVhSmaw== X-Received: by 10.84.246.137 with SMTP id m9mr21223084pll.222.1507152074386; Wed, 04 Oct 2017 14:21:14 -0700 (PDT) Received: from skynet.sea.corp.google.com ([172.31.92.33]) by smtp.gmail.com with ESMTPSA id s68sm30204019pfd.72.2017.10.04.14.21.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 04 Oct 2017 14:21:13 -0700 (PDT) From: Thomas Garnier To: Herbert Xu , "David S . Miller" , Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Peter Zijlstra , Josh Poimboeuf , Thomas Garnier , Arnd Bergmann , Kees Cook , Matthias Kaehlcke , Tom Lendacky , Andy Lutomirski , "Kirill A . Shutemov" , Borislav Petkov , "Rafael J . Wysocki" , Len Brown , Pavel Machek , Juergen Gross , Chris Wright , Alok Kataria , Rusty Russell , Tejun Heo , Christoph Lameter , Boris Ostrovsky , Alexey Dobriyan , Andrew Morton , Paul Gortmaker , Chris Metcalf , "Paul E . McKenney" , Nicolas Pitre , Borislav Petkov , "Luis R . Rodriguez" , Greg Kroah-Hartman , Christopher Li , Steven Rostedt , Jason Baron , Dou Liyang , "Rafael J . Wysocki" , Mika Westerberg , Lukas Wunner , Masahiro Yamada , Alexei Starovoitov , Daniel Borkmann , Markus Trippelsdorf , Paolo Bonzini , =?UTF-8?q?Radim=20Kr=C4=8Dm=C3=A1=C5=99?= , Joerg Roedel , Rik van Riel , David Howells , Ard Biesheuvel , Waiman Long , Kyle Huey , Andrey Ryabinin , Jonathan Corbet , Matthew Wilcox , Michal Hocko , Peter Foley , Paul Bolle , Jiri Kosina , Rob Landley , "H . J . Lu" , Baoquan He , =?UTF-8?q?Jan=20H=20=2E=20Sch=C3=B6nherr?= , Daniel Micay Date: Wed, 4 Oct 2017 14:19:52 -0700 Message-Id: <20171004212003.28296-17-thgarnie@google.com> X-Mailer: git-send-email 2.14.2.920.gcf0c67979c-goog In-Reply-To: <20171004212003.28296-1-thgarnie@google.com> References: <20171004212003.28296-1-thgarnie@google.com> Cc: linux-arch@vger.kernel.org, kvm@vger.kernel.org, linux-pm@vger.kernel.org, x86@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-sparse@vger.kernel.org, linux-crypto@vger.kernel.org, kernel-hardening@lists.openwall.com, xen-devel@lists.xenproject.org Subject: [Xen-devel] [RFC v3 16/27] x86/relocs: Handle PIE relocations X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Change the relocation tool to correctly handle relocations generated by -fPIE option: - Add relocation for each entry of the .got section given the linker does not generate R_X86_64_GLOB_DAT on a simple link. - Ignore R_X86_64_GOTPCREL and R_X86_64_PLT32. Signed-off-by: Thomas Garnier --- arch/x86/tools/relocs.c | 94 ++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 93 insertions(+), 1 deletion(-) diff --git a/arch/x86/tools/relocs.c b/arch/x86/tools/relocs.c index 73eb7fd4aec4..5d3eb2760198 100644 --- a/arch/x86/tools/relocs.c +++ b/arch/x86/tools/relocs.c @@ -31,6 +31,7 @@ struct section { Elf_Sym *symtab; Elf_Rel *reltab; char *strtab; + Elf_Addr *got; }; static struct section *secs; @@ -292,6 +293,35 @@ static Elf_Sym *sym_lookup(const char *symname) return 0; } +static Elf_Sym *sym_lookup_addr(Elf_Addr addr, const char **name) +{ + int i; + for (i = 0; i < ehdr.e_shnum; i++) { + struct section *sec = &secs[i]; + long nsyms; + Elf_Sym *symtab; + Elf_Sym *sym; + + if (sec->shdr.sh_type != SHT_SYMTAB) + continue; + + nsyms = sec->shdr.sh_size/sizeof(Elf_Sym); + symtab = sec->symtab; + + for (sym = symtab; --nsyms >= 0; sym++) { + if (sym->st_value == addr) { + if (name) { + *name = sym_name(sec->link->strtab, + sym); + } + return sym; + } + } + } + return 0; +} + + #if BYTE_ORDER == LITTLE_ENDIAN #define le16_to_cpu(val) (val) #define le32_to_cpu(val) (val) @@ -512,6 +542,33 @@ static void read_relocs(FILE *fp) } } +static void read_got(FILE *fp) +{ + int i; + for (i = 0; i < ehdr.e_shnum; i++) { + struct section *sec = &secs[i]; + sec->got = NULL; + if (sec->shdr.sh_type != SHT_PROGBITS || + strcmp(sec_name(i), ".got")) { + continue; + } + sec->got = malloc(sec->shdr.sh_size); + if (!sec->got) { + die("malloc of %d bytes for got failed\n", + sec->shdr.sh_size); + } + if (fseek(fp, sec->shdr.sh_offset, SEEK_SET) < 0) { + die("Seek to %d failed: %s\n", + sec->shdr.sh_offset, strerror(errno)); + } + if (fread(sec->got, 1, sec->shdr.sh_size, fp) + != sec->shdr.sh_size) { + die("Cannot read got: %s\n", + strerror(errno)); + } + } +} + static void print_absolute_symbols(void) { @@ -642,6 +699,32 @@ static void add_reloc(struct relocs *r, uint32_t offset) r->offset[r->count++] = offset; } +/* + * The linker does not generate relocations for the GOT for the kernel. + * If a GOT is found, simulate the relocations that should have been included. + */ +static void walk_got_table(int (*process)(struct section *sec, Elf_Rel *rel, + Elf_Sym *sym, const char *symname), + struct section *sec) +{ + int i; + Elf_Addr entry; + Elf_Sym *sym; + const char *symname; + Elf_Rel rel; + + for (i = 0; i < sec->shdr.sh_size/sizeof(Elf_Addr); i++) { + entry = sec->got[i]; + sym = sym_lookup_addr(entry, &symname); + if (!sym) + die("Could not found got symbol for entry %d\n", i); + rel.r_offset = sec->shdr.sh_addr + i * sizeof(Elf_Addr); + rel.r_info = ELF_BITS == 64 ? R_X86_64_GLOB_DAT + : R_386_GLOB_DAT; + process(sec, &rel, sym, symname); + } +} + static void walk_relocs(int (*process)(struct section *sec, Elf_Rel *rel, Elf_Sym *sym, const char *symname)) { @@ -655,6 +738,8 @@ static void walk_relocs(int (*process)(struct section *sec, Elf_Rel *rel, struct section *sec = &secs[i]; if (sec->shdr.sh_type != SHT_REL_TYPE) { + if (sec->got) + walk_got_table(process, sec); continue; } sec_symtab = sec->link; @@ -764,6 +849,8 @@ static int do_reloc64(struct section *sec, Elf_Rel *rel, ElfW(Sym) *sym, offset += per_cpu_load_addr; switch (r_type) { + case R_X86_64_PLT32: + case R_X86_64_GOTPCREL: case R_X86_64_NONE: /* NONE can be ignored. */ break; @@ -805,7 +892,7 @@ static int do_reloc64(struct section *sec, Elf_Rel *rel, ElfW(Sym) *sym, * the relocations are processed. * Make sure that the offset will fit. */ - if ((int32_t)offset != (int64_t)offset) + if (r_type != R_X86_64_64 && (int32_t)offset != (int64_t)offset) die("Relocation offset doesn't fit in 32 bits\n"); if (r_type == R_X86_64_64) @@ -814,6 +901,10 @@ static int do_reloc64(struct section *sec, Elf_Rel *rel, ElfW(Sym) *sym, add_reloc(&relocs32, offset); break; + case R_X86_64_GLOB_DAT: + add_reloc(&relocs64, offset); + break; + default: die("Unsupported relocation type: %s (%d)\n", rel_type(r_type), r_type); @@ -1083,6 +1174,7 @@ void process(FILE *fp, int use_real_mode, int as_text, read_strtabs(fp); read_symtabs(fp); read_relocs(fp); + read_got(fp); if (ELF_BITS == 64) percpu_init(); if (show_absolute_syms) {