Message ID | 20171004212003.28296-9-thgarnie@google.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <xen-devel-bounces@lists.xen.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4573B60586 for <patchwork-xen-devel@patchwork.kernel.org>; Wed, 4 Oct 2017 21:23:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3681E28C2C for <patchwork-xen-devel@patchwork.kernel.org>; Wed, 4 Oct 2017 21:23:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2ADC028C2F; Wed, 4 Oct 2017 21:23:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A13DF28C2C for <patchwork-xen-devel@patchwork.kernel.org>; Wed, 4 Oct 2017 21:23:38 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from <xen-devel-bounces@lists.xen.org>) id 1dzr6R-0002zq-Oi; Wed, 04 Oct 2017 21:21:15 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from <thgarnie@google.com>) id 1dzr6Q-0002xw-BC for xen-devel@lists.xenproject.org; Wed, 04 Oct 2017 21:21:14 +0000 Received: from [85.158.143.35] by server-8.bemta-6.messagelabs.com id 9E/6A-17770-9C055D95; Wed, 04 Oct 2017 21:21:13 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrCIsWRWlGSWpSXmKPExsXiVRtsoLs34Gq kwZ5ePYvvWyYzOTB6HP5whSWAMYo1My8pvyKBNWPByQnMBWe4K65MqWhgvMHZxcjFISQwnVFi ccs5ZhCHReAVi8TR452sII6EQD+rxJ4de4AcTiAnS6JryhMoO02i795dZgi7SmLrwvNsILaQg JLE1g1LmSHG/mWUOH5tPiNIgk1AS2JPw3wmkISIwCwRiVuve9hAHGaBM0wSx/tOgo0VFrCXaO +8BNbBIqAqsefIAxYQm1fAQqLp6zl2iHUmEg+PXAOr5xSwlDhy4g0zxGoLidYz95kmMAouYGR YxahRnFpUllqka2ykl1SUmZ5RkpuYmaNraGCml5taXJyYnpqTmFSsl5yfu4kRGHYMQLCD8fS6 wEOMkhxMSqK8m3yvRgrxJeWnVGYkFmfEF5XmpBYfYpTh4FCS4OUEhrGQYFFqempFWmYOMAJg0 hIcPEoivJP9gdK8xQWJucWZ6RCpU4zGHPv23PrDxNFx8+4fJiGWvPy8VClx3s0gpQIgpRmleX CDYJF5iVFWSpiXEeg0IZ6C1KLczBJU+VeM4hyMSsK8D0Cm8GTmlcDtewV0ChPQKXOaroCcUpK IkJJqYAz6uVw7T8FzwsTpzpfF973u+L6QuyCuYdMcy/6KT3dz1F888HmY5Xb73VQnCRaT9CXf LP2cHv5jkHvy5P6k2td5IZ51X43eKGbsfzr58AEfifiSrSWrHr16xVVsEJNkKKA+1aX7Q5DCb o6GuIlPl0TFce1d1fFJVi/30+rn02X838U/XMZ19LQSS3FGoqEWc1FxIgD86DKoxwIAAA== X-Env-Sender: thgarnie@google.com X-Msg-Ref: server-12.tower-21.messagelabs.com!1507152060!76370791!1 X-Originating-IP: [74.125.83.48] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 63029 invoked from network); 4 Oct 2017 21:21:01 -0000 Received: from mail-pg0-f48.google.com (HELO mail-pg0-f48.google.com) (74.125.83.48) by server-12.tower-21.messagelabs.com with AES128-GCM-SHA256 encrypted SMTP; 4 Oct 2017 21:21:01 -0000 Received: by mail-pg0-f48.google.com with SMTP id v13so7173601pgq.6 for <xen-devel@lists.xenproject.org>; Wed, 04 Oct 2017 14:21:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=PCJKT4rjVH4EM4bq/0M1IWsxOAMYjKIEbfsGvIKF65M=; b=jlUNHGoM94FS6l6Y48w89nxNQg2adrhZU9qc3oE5+vWT+ZHFAknI4JpzpIVJ4MqpdA SBLcIfyN3M6pBoH3wdVyQ9xbbrfKsrmOJQFgjjnP1kyvCiQ+2iGfGh30SiNcQjC3gnQy dhdBMZM4S05Z3tHwcYyMc1VEG3iiq87Tjju3H6hl+lZXt0rMAVwniZh6dvCDCmOX9rdD KqG2wT3vW/i3h6WuOYNfxrSoWlTDU17CdoJEL85uY0JXLVilbWftHhyXvFggg8UMIcEB SBoLmXvFuUnjkNqXvHfgKAVLDoE8vLTkOFj7BBR9MaW44s2GjX7cvJPd9OQa7qt0Hl2z aANA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=PCJKT4rjVH4EM4bq/0M1IWsxOAMYjKIEbfsGvIKF65M=; b=kO/AQ0L+Ebt9EpYSAEiytFLlIK4kwwo7fVUA6/gfA41dXbDUkHgtnqD6ooc8RcQCqv pxocf2uB3yCdz0LL3m4AGso0BAGPfmavUsFvl3traU1fgfqXLVuAFLUigBmYR48GW63R L4x0KkrcEAoyHQa3cdOZpBmsaKWnb7WWj4MdEVqNEEhN8Q0OJ5BoeVGFCzdpiFlUwG4H gUfC8L9luLEWr4HSf7W96KaoqJDOJEBqfanttCUihvg7+lvt2vMxaU2Euiidk2D1Ti0k bNjpTajY+pksjWFEbLhkUUFrJsjoHqjsUklfgfJroHzx5+1afk8nR5vy36vbGIkAvEGr W/kw== X-Gm-Message-State: AHPjjUjAMpRlQUA6SD4fcRrpmZPpZ1tv3F//HNZppE01ciPeBfCoMjj4 T7+5vDXm7fGec5sXnnIVbfb9UQ== X-Google-Smtp-Source: AOwi7QAJAjcfTPDKhKVF7kIRCcl7mMqH0oPakFtaP4kyHPsJIMmhRJ2E7ApNNmQJtub8F4uv5Rrx+g== X-Received: by 10.98.112.68 with SMTP id l65mr21366539pfc.292.1507152059556; Wed, 04 Oct 2017 14:20:59 -0700 (PDT) Received: from skynet.sea.corp.google.com ([172.31.92.33]) by smtp.gmail.com with ESMTPSA id s68sm30204019pfd.72.2017.10.04.14.20.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 04 Oct 2017 14:20:58 -0700 (PDT) From: Thomas Garnier <thgarnie@google.com> To: Herbert Xu <herbert@gondor.apana.org.au>, "David S . Miller" <davem@davemloft.net>, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>, Peter Zijlstra <peterz@infradead.org>, Josh Poimboeuf <jpoimboe@redhat.com>, Thomas Garnier <thgarnie@google.com>, Arnd Bergmann <arnd@arndb.de>, Kees Cook <keescook@chromium.org>, Matthias Kaehlcke <mka@chromium.org>, Tom Lendacky <thomas.lendacky@amd.com>, Andy Lutomirski <luto@kernel.org>, "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>, Borislav Petkov <bp@suse.de>, "Rafael J . Wysocki" <rjw@rjwysocki.net>, Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>, Juergen Gross <jgross@suse.com>, Chris Wright <chrisw@sous-sol.org>, Alok Kataria <akataria@vmware.com>, Rusty Russell <rusty@rustcorp.com.au>, Tejun Heo <tj@kernel.org>, Christoph Lameter <cl@linux.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, Alexey Dobriyan <adobriyan@gmail.com>, Andrew Morton <akpm@linux-foundation.org>, Paul Gortmaker <paul.gortmaker@windriver.com>, Chris Metcalf <cmetcalf@mellanox.com>, "Paul E . McKenney" <paulmck@linux.vnet.ibm.com>, Nicolas Pitre <nicolas.pitre@linaro.org>, Borislav Petkov <bp@alien8.de>, "Luis R . Rodriguez" <mcgrof@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Christopher Li <sparse@chrisli.org>, Steven Rostedt <rostedt@goodmis.org>, Jason Baron <jbaron@akamai.com>, Dou Liyang <douly.fnst@cn.fujitsu.com>, "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>, Mika Westerberg <mika.westerberg@linux.intel.com>, Lukas Wunner <lukas@wunner.de>, Masahiro Yamada <yamada.masahiro@socionext.com>, Alexei Starovoitov <ast@kernel.org>, Daniel Borkmann <daniel@iogearbox.net>, Markus Trippelsdorf <markus@trippelsdorf.de>, Paolo Bonzini <pbonzini@redhat.com>, =?UTF-8?q?Radim=20Kr=C4=8Dm=C3=A1=C5=99?= <rkrcmar@redhat.com>, Joerg Roedel <joro@8bytes.org>, Rik van Riel <riel@redhat.com>, David Howells <dhowells@redhat.com>, Ard Biesheuvel <ard.biesheuvel@linaro.org>, Waiman Long <longman@redhat.com>, Kyle Huey <me@kylehuey.com>, Andrey Ryabinin <aryabinin@virtuozzo.com>, Jonathan Corbet <corbet@lwn.net>, Matthew Wilcox <mawilcox@microsoft.com>, Michal Hocko <mhocko@suse.com>, Peter Foley <pefoley2@pefoley.com>, Paul Bolle <pebolle@tiscali.nl>, Jiri Kosina <jkosina@suse.cz>, Rob Landley <rob@landley.net>, "H . J . Lu" <hjl.tools@gmail.com>, Baoquan He <bhe@redhat.com>, =?UTF-8?q?Jan=20H=20=2E=20Sch=C3=B6nherr?= <jschoenh@amazon.de>, Daniel Micay <danielmicay@gmail.com> Date: Wed, 4 Oct 2017 14:19:44 -0700 Message-Id: <20171004212003.28296-9-thgarnie@google.com> X-Mailer: git-send-email 2.14.2.920.gcf0c67979c-goog In-Reply-To: <20171004212003.28296-1-thgarnie@google.com> References: <20171004212003.28296-1-thgarnie@google.com> Cc: linux-arch@vger.kernel.org, kvm@vger.kernel.org, linux-pm@vger.kernel.org, x86@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-sparse@vger.kernel.org, linux-crypto@vger.kernel.org, kernel-hardening@lists.openwall.com, xen-devel@lists.xenproject.org Subject: [Xen-devel] [RFC v3 08/27] x86/CPU: Adapt assembly for PIE support X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion <xen-devel.lists.xen.org> List-Unsubscribe: <https://lists.xen.org/cgi-bin/mailman/options/xen-devel>, <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe> List-Post: <mailto:xen-devel@lists.xen.org> List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help> List-Subscribe: <https://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xen.org?subject=subscribe> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org> X-Virus-Scanned: ClamAV using ClamSMTP |
diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm/processor.h index b446c5a082ad..b09bd50b06c7 100644 --- a/arch/x86/include/asm/processor.h +++ b/arch/x86/include/asm/processor.h @@ -49,7 +49,7 @@ static inline void *current_text_addr(void) { void *pc; - asm volatile("mov $1f, %0; 1:":"=r" (pc)); + asm volatile(_ASM_GET_PTR(1f, %0) "; 1:":"=r" (pc)); return pc; } @@ -695,6 +695,7 @@ static inline void sync_core(void) : ASM_CALL_CONSTRAINT : : "memory"); #else unsigned int tmp; + unsigned long tmp2; asm volatile ( UNWIND_HINT_SAVE @@ -705,11 +706,13 @@ static inline void sync_core(void) "pushfq\n\t" "mov %%cs, %0\n\t" "pushq %q0\n\t" - "pushq $1f\n\t" + "leaq 1f(%%rip), %1\n\t" + "pushq %1\n\t" "iretq\n\t" UNWIND_HINT_RESTORE "1:" - : "=&r" (tmp), ASM_CALL_CONSTRAINT : : "cc", "memory"); + : "=&r" (tmp), "=&r" (tmp2), ASM_CALL_CONSTRAINT + : : "cc", "memory"); #endif }
Change the assembly code to use only relative references of symbols for the kernel to be PIE compatible. Use the new _ASM_GET_PTR macro instead of the 'mov $symbol, %dst' construct to not have an absolute reference. Position Independent Executable (PIE) support will allow to extended the KASLR randomization range below the -2G memory limit. Signed-off-by: Thomas Garnier <thgarnie@google.com> --- arch/x86/include/asm/processor.h | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)