From patchwork Thu Oct 12 20:50:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Douglas Goldstein X-Patchwork-Id: 10002889 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 76B9B6028A for ; Thu, 12 Oct 2017 20:54:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 698DD28DDE for ; Thu, 12 Oct 2017 20:54:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5EB2028EC3; Thu, 12 Oct 2017 20:54:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RCVD_IN_SORBS_SPAM,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 6790228E8D for ; Thu, 12 Oct 2017 20:54:16 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e2kSV-0001QS-7P; Thu, 12 Oct 2017 20:51:59 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e2kST-0001QK-La for xen-devel@lists.xenproject.org; Thu, 12 Oct 2017 20:51:57 +0000 Received: from [85.158.143.35] by server-1.bemta-6.messagelabs.com id E3/B1-31121-CE5DFD95; Thu, 12 Oct 2017 20:51:56 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrOIsWRWlGSWpSXmKPExsVyMfTGId03V+9 HGnw5zW3xfctkJgdGj8MfrrAEMEaxZuYl5VcksGZcffabqeAie8WfYyfZGxgb2LoYuTiEBGYw Smy+v4kZxGERaGeW6N70gBHEkRB4xyJxdNN0oDJOICdP4ti1TSwQdprE5fcgRSB2lcSeWxdZQ WwhAQWJ3xMOMUGMXcYksW3tDLBmNgENiSe/IGwRASWJe6smgxUxC8xnlDh3t4MZJCEsYCaxY+ FBsCIWAVWJaf9Wgk3lBYo37vkGtI0DaJu8xI7NghMY+RcwMqxi1ChOLSpLLdI1NNdLKspMzyj JTczM0TU0MNPLTS0uTkxPzUlMKtZLzs/dxAgMIgYg2MF4e2PAIUZJDiYlUd6MwPuRQnxJ+SmV GYnFGfFFpTmpxYcYZTg4lCR45YBBKSRYlJqeWpGWmQMMZ5i0BAePkgivPUiat7ggMbc4Mx0id YrRnuPCnUt/mDhuPLwOJA/suQUkO27e/cMkxJKXn5cqJc6rA9ImANKWUZoHNxQWf5cYZaWEeR mBzhTiKUgtys0sQZV/xSjOwagkzMsCMoUnM68EbvcroLOYgM4STbsDclZJIkJKqoGxpa9FT27 6mzKZMp/va3wVX/TVLZuU9easYPLBG2I3An9ZfhB4Up1huvXGTlO1CZkma9UiN7odmPa+5fqv F/3H7z67MWPlNjnltA0Ljj3JefDNeNoFrUsBCequm1Znx0z4re5SblrjV27jUJ+hm7LOViD/g 72sdo9w1B2B3oA5S8/tM8pcNp9diaU4I9FQi7moOBEAJQ9NJroCAAA= X-Env-Sender: cardoe@cardoe.com X-Msg-Ref: server-4.tower-21.messagelabs.com!1507841515!70466145!1 X-Originating-IP: [209.85.216.194] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 26602 invoked from network); 12 Oct 2017 20:51:56 -0000 Received: from mail-qt0-f194.google.com (HELO mail-qt0-f194.google.com) (209.85.216.194) by server-4.tower-21.messagelabs.com with AES128-GCM-SHA256 encrypted SMTP; 12 Oct 2017 20:51:56 -0000 Received: by mail-qt0-f194.google.com with SMTP id f8so16041747qta.5 for ; Thu, 12 Oct 2017 13:51:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cardoe.com; s=google; h=from:to:cc:subject:date:message-id; bh=9he5CSCad1XLiGsqHS4BXuTTawK1w7b30a1z4zL7Gn0=; b=YKTwmlSA8Oa0kq7MEJT37qjPch4TfLBxnP2PfH7d8yIj9avXvcBgyUeF1mLu2N4ske aktQp/o5c4fd1Lsow4xJ4NyZdrhrydLt30DMg+ThpY84UEIFWM79TeOzvTKZbmCP5S9S hV9miB6TGJKbWxvaa2ipUBPlgyB0xfSM6uJ2A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=9he5CSCad1XLiGsqHS4BXuTTawK1w7b30a1z4zL7Gn0=; b=MuNL8O6zIi2CNm9no7aZnaG5si3mGjvrTroRmYkzVfNMcmftCMqX7PbR50QwwFeEX8 b6fej6ysj3LLNjfUV5K5H6kNLE7LZsPmsPujZuF8Ff5656u2ORGnuHatn3G4/6zs712C 352doPP3fzeuSZ8xtKxDLMeIgz0mDi27xSJbXyMnszztg8RKBUd1tW9s7dpQGWBdzbnM YpogISYBM7+ZW8Okz8eVnN8XlEsp2bkdW3iXUJUnwe+Va2N1Ild1EYnTgeYEpuSKxqiH 5hDZzMhn9wb2pkn/vpNNWwdASFottpkNy6DS/q3iV6jiE4c8g9exf26WxSU+gGenGrX6 W3YQ== X-Gm-Message-State: AMCzsaWSpbfF7jtx2o8oU/H0MbJGR3qTFTS7aGUePEpEMuomhBQ3lyck mipJGHydiHycxfsaxOvBIvlq/NZ7cJg= X-Google-Smtp-Source: AOwi7QDWPuMhI7ruc+SWT2ZkWZ2shQa3C9uh43La4QGID4uxD5FUF/1rRLD2yRnFFaQHdBL01CGSew== X-Received: by 10.200.39.236 with SMTP id x41mr5430683qtx.287.1507841514953; Thu, 12 Oct 2017 13:51:54 -0700 (PDT) Received: from swanson.localdomain (104-179-196-18.lightspeed.brhmal.sbcglobal.net. [104.179.196.18]) by smtp.gmail.com with ESMTPSA id 23sm9812084qkf.68.2017.10.12.13.51.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 12 Oct 2017 13:51:54 -0700 (PDT) From: Doug Goldstein To: xen-devel@lists.xenproject.org Date: Thu, 12 Oct 2017 15:50:06 -0500 Message-Id: <20171012205007.13001-1-cardoe@cardoe.com> X-Mailer: git-send-email 2.13.5 Cc: Andrew Cooper , Daniel Kiper , David Esler , Jan Beulich Subject: [Xen-devel] [PATCH 1/2] x86/boot: fix early error display X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: David Esler In 9180f5365524 a change was made to the send_chr function to take in C-strings and print out a character at a time until a NULL was encountered. However there is no code to increment the current character position resulting in an endless loop of the first character. This adds a simple increment. Reviewed-by: Doug Goldstein Signed-off-by: David Esler Reviewed-by: Andrew Cooper --- xen/arch/x86/boot/head.S | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S index fd6fc337fe..f48bbbd2e5 100644 --- a/xen/arch/x86/boot/head.S +++ b/xen/arch/x86/boot/head.S @@ -174,6 +174,7 @@ not_multiboot: mov sym_esi(vga_text_buffer),%edi .Lsend_chr: mov (%esi),%bl + inc %esi test %bl,%bl # Terminate on '\0' sentinel je .Lhalt mov $0x3f8+5,%dx # UART Line Status Register