| Message ID | 20171020103840.32762-4-wei.liu2@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Wei Liu writes ("[OSSTEST PATCH 03/16] ts-xen-build-prep: don't install w3c-dtd-xhtml for Stretch onward"):
> It is not included in Stretch.
>
> That package was installed because libvirt build needed it. However
> libvirt builds fine without it in Stretch. It should be fine to just not
> install it on Stretch.
...
> + if ($ho->{Suite} !~ m/stretch/) {
> + push(@packages, "w3c-dtd-xhtml");
> + }
This is not correct because it will break when buster is released.
Instead you should list all still-supported old suites for which (you
think) it is required.
I suggest for `still-supported' we arbitrarily go back to `squeeze',
so you want if ... m/squeeze|jessie/
Ian.
On Fri, Oct 20, 2017 at 11:50:11AM +0100, Ian Jackson wrote: > Wei Liu writes ("[OSSTEST PATCH 03/16] ts-xen-build-prep: don't install w3c-dtd-xhtml for Stretch onward"): > > It is not included in Stretch. > > > > That package was installed because libvirt build needed it. However > > libvirt builds fine without it in Stretch. It should be fine to just not > > install it on Stretch. > ... > > + if ($ho->{Suite} !~ m/stretch/) { > > + push(@packages, "w3c-dtd-xhtml"); > > + } > > This is not correct because it will break when buster is released. > Instead you should list all still-supported old suites for which (you > think) it is required. > > I suggest for `still-supported' we arbitrarily go back to `squeeze', > so you want if ... m/squeeze|jessie/ > No problem.
diff --git a/ts-xen-build-prep b/ts-xen-build-prep index 3e98364..6152d0a 100755 --- a/ts-xen-build-prep +++ b/ts-xen-build-prep @@ -206,9 +206,12 @@ sub prep () { libglib2.0-dev liblzma-dev pkg-config autoconf automake libtool xsltproc libxml2-utils libxml2-dev - libdevmapper-dev w3c-dtd-xhtml libxml-xpath-perl + libdevmapper-dev libxml-xpath-perl ccache nasm checkpolicy ebtables); + if ($ho->{Suite} !~ m/stretch/) { + push(@packages, "w3c-dtd-xhtml"); + } if ($ho->{Suite} !~ m/squeeze|wheezy/) { push(@packages, qw(ocaml-nox ocaml-findlib)); }
It is not included in Stretch. That package was installed because libvirt build needed it. However libvirt builds fine without it in Stretch. It should be fine to just not install it on Stretch. Signed-off-by: Wei Liu <wei.liu2@citrix.com> --- ts-xen-build-prep | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)