| Message ID | 20171020103840.32762-6-wei.liu2@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Wei Liu writes ("[OSSTEST PATCH 05/16] mg-debian-installer-update-all: put quotes around arguments"):
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
...
> suite=$1
> arch=$2
> -packages="$3"
> +packages=$3
Not sure why this needless style change, but if you did it
deliberately I don't really mind...
> site=http://ftp.debian.org/debian/
> sbase=$site/dists/$suite
> diff --git a/mg-debian-installer-update-all b/mg-debian-installer-update-all
> index d88ebf5..d590b2b 100755
> --- a/mg-debian-installer-update-all
> +++ b/mg-debian-installer-update-all
> @@ -31,5 +31,5 @@ fws=`getconfig DebianNonfreeFirmware`
> arches="arm64 armhf amd64 i386"
>
> for arch in $arches ; do
> - ./mg-debian-installer-update $suite $arch $fws
> + ./mg-debian-installer-update "$suite" "$arch" "$fws"
> done
This hunk LGTM. Although the "" around $suite and $arch are
unnecessary I don't really mind them.
Thanks,
Ian.
diff --git a/mg-debian-installer-update b/mg-debian-installer-update index 37cec58..dc807a2 100755 --- a/mg-debian-installer-update +++ b/mg-debian-installer-update @@ -26,7 +26,7 @@ set -e -o posix suite=$1 arch=$2 -packages="$3" +packages=$3 site=http://ftp.debian.org/debian/ sbase=$site/dists/$suite diff --git a/mg-debian-installer-update-all b/mg-debian-installer-update-all index d88ebf5..d590b2b 100755 --- a/mg-debian-installer-update-all +++ b/mg-debian-installer-update-all @@ -31,5 +31,5 @@ fws=`getconfig DebianNonfreeFirmware` arches="arm64 armhf amd64 i386" for arch in $arches ; do - ./mg-debian-installer-update $suite $arch $fws + ./mg-debian-installer-update "$suite" "$arch" "$fws" done
Signed-off-by: Wei Liu <wei.liu2@citrix.com> --- mg-debian-installer-update | 2 +- mg-debian-installer-update-all | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)