From patchwork Thu Nov 2 18:51:22 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Gustavo A. R. Silva" X-Patchwork-Id: 10039211 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 130AD6032D for ; Thu, 2 Nov 2017 18:53:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0530429323 for ; Thu, 2 Nov 2017 18:53:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EDF3829329; Thu, 2 Nov 2017 18:53:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 90F2D29323 for ; Thu, 2 Nov 2017 18:53:46 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAKaP-0002bh-Sm; Thu, 02 Nov 2017 18:51:29 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eAKaP-0002bb-0S for xen-devel@lists.xenproject.org; Thu, 02 Nov 2017 18:51:29 +0000 Received: from [193.109.254.147] by server-7.bemta-6.messagelabs.com id D1/79-25852-0396BF95; Thu, 02 Nov 2017 18:51:28 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrBKsWRWlGSWpSXmKPExsVyYKfRTl39zN+ RBtuOqVt83zKZyYHR4/CHKywBjFGsmXlJ+RUJrBl7Tm9lK5jLXvHn5FGmBsaJbF2MXBxCAvcY JXas+84O4XQxSlyetocZwrnIKHFh2V2mLkZODhYBFYmNi98A2RwcbAKmEuc3mIKYIgJBEl83g 1UwCxRJfP6wHaxCWMBVYnejOEiYV8BIYtP/r4wQtqDEyZlPWCDKtSRu/HsJVs4sIC2x/B8HiC kKtOfVwXqQCgmBKIm/u6+yQNjmEq9mnWSDsI0lXr5awAxhW0n8PryGBSbeuPY/O4QtINH25yQ rhC0t8bdhDpTNJ3HixXM2mPi7D0cYIWwuiQNT50HF+SUOz77HCFO/b+EGqLiJxMWJjUwQtprE 5h3zWGF2nXt7ESruJnHj4UcoW1ji4KdXjBMY5WYheX4WkudnITy/gJF5FaNGcWpRWWqRrqGFX lJRZnpGSW5iZo6uoYGZXm5qcXFiempOYlKxXnJ+7iZGYJwzAMEOxpsbAw4xSnIwKYny3t34K1 KILyk/pTIjsTgjvqg0J7X4EKMMB4eSBO/EjN+RQoJFqempFWmZOcCEA5OW4OBREuFdBpLmLS5 IzC3OTIdInWK05zi26fIfJo4bD68DyUuvbgHJZzNfNzALseTl56VKifP6gLQJgLRllObBDYUl yEuMslLCvIxAZwrxFKQW5WaWoMq/YhTnYFQS5pUAmcKTmVcCt/sV0FlMQGd5SfwAOaskESEl1 cCo++PvNp4UN337r5z7j+kHvkpzbnyZvXlOoGm9MXfQvZnue3Z5/3Pr2XTz+e8ZqpELhCKqZ8 3rWxTFr5/6g+GJ7KXl597vnvXM6nmrx7u1vJOlVr298ddsFdeEsuUNHkaqpTzc1WrRqyZG3Fn Z+m2JkO6/tOJVlh+WHtKckv0l1rZz0/fVO3/+VWIpzkg01GIuKk4EADa5qIWLAwAA X-Env-Sender: garsilva@embeddedor.com X-Msg-Ref: server-3.tower-27.messagelabs.com!1509648686!114379777!1 X-Originating-IP: [192.185.50.185] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 47172 invoked from network); 2 Nov 2017 18:51:27 -0000 Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.50.185) by server-3.tower-27.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 2 Nov 2017 18:51:27 -0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 779D07185 for ; Thu, 2 Nov 2017 13:51:25 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id AKaLeycwLtuxmAKaLeMPxA; Thu, 02 Nov 2017 13:51:25 -0500 Received: from [189.145.38.148] (port=39040 helo=embeddedor) by gator4166.hostgator.com with esmtpa (Exim 4.87) (envelope-from ) id 1eAKaL-000ZbE-25; Thu, 02 Nov 2017 13:51:25 -0500 Date: Thu, 2 Nov 2017 13:51:22 -0500 From: "Gustavo A. R. Silva" To: Boris Ostrovsky , Juergen Gross Message-ID: <20171102185122.GA6817@embeddedor.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - lists.xenproject.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.145.38.148 X-Source-L: No X-Exim-ID: 1eAKaL-000ZbE-25 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [189.145.38.148]:39040 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 7 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Cc: xen-devel@lists.xenproject.org, "Gustavo A. R. Silva" , linux-kernel@vger.kernel.org Subject: [Xen-devel] [PATCH] xen/pvcalls-front: mark expected switch fall-through X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that in this particular case I placed the "fall through" comment on its own line, which is what GCC is expecting to find. Signed-off-by: Gustavo A. R. Silva Reviewed-by: Juergen Gross --- drivers/xen/pvcalls-front.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen/pvcalls-front.c index 0c1ec68..ed94ea0 100644 --- a/drivers/xen/pvcalls-front.c +++ b/drivers/xen/pvcalls-front.c @@ -1250,7 +1250,8 @@ static void pvcalls_front_changed(struct xenbus_device *dev, case XenbusStateClosed: if (dev->state == XenbusStateClosed) break; - /* Missed the backend's CLOSING state -- fallthrough */ + /* Missed the backend's CLOSING state */ + /* fall through */ case XenbusStateClosing: xenbus_frontend_closed(dev); break;