diff mbox series

ALSA: xen-front: Do not use stream buffer size before it is set

Message ID 20190404123838.22162-1-andr2000@gmail.com (mailing list archive)
State Accepted
Commit 8b030a57e35a0efc1a8aa18bb10555bc5066ac40
Headers show
Series ALSA: xen-front: Do not use stream buffer size before it is set | expand

Commit Message

Oleksandr Andrushchenko April 4, 2019, 12:38 p.m. UTC 
From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

This fixes the regression introduced while moving to Xen shared
buffer implementation.

Fixes: 58f9d806d16a ("ALSA: xen-front: Use Xen common shared buffer implementation")

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
---
 sound/xen/xen_snd_front_alsa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jürgen Groß April 4, 2019, 12:42 p.m. UTC | #1 
On 04/04/2019 14:38, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> This fixes the regression introduced while moving to Xen shared
> buffer implementation.
> 
> Fixes: 58f9d806d16a ("ALSA: xen-front: Use Xen common shared buffer implementation")
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen
Takashi Iwai April 4, 2019, 12:45 p.m. UTC | #2 
On Thu, 04 Apr 2019 14:42:44 +0200,
Juergen Gross wrote:
> 
> On 04/04/2019 14:38, Oleksandr Andrushchenko wrote:
> > From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> > 
> > This fixes the regression introduced while moving to Xen shared
> > buffer implementation.
> > 
> > Fixes: 58f9d806d16a ("ALSA: xen-front: Use Xen common shared buffer implementation")
> > 
> > Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> Reviewed-by: Juergen Gross <jgross@suse.com>

Applied now, thanks.
I put Cc to stable since the bug was already in 5.0.


Takashi
Oleksandr Andrushchenko April 4, 2019, 12:46 p.m. UTC | #3 
On 4/4/19 3:45 PM, Takashi Iwai wrote:
> On Thu, 04 Apr 2019 14:42:44 +0200,
> Juergen Gross wrote:
>> On 04/04/2019 14:38, Oleksandr Andrushchenko wrote:
>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>>
>>> This fixes the regression introduced while moving to Xen shared
>>> buffer implementation.
>>>
>>> Fixes: 58f9d806d16a ("ALSA: xen-front: Use Xen common shared buffer implementation")
>>>
>>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>> Reviewed-by: Juergen Gross <jgross@suse.com>
> Applied now, thanks.
> I put Cc to stable since the bug was already in 5.0.
>
>
> Takashi
Thank you,
Oleksandr
diff mbox series

Patch

diff --git a/sound/xen/xen_snd_front_alsa.c b/sound/xen/xen_snd_front_alsa.c
index a7f413cb704d..b14ab512c2ce 100644
--- a/sound/xen/xen_snd_front_alsa.c
+++ b/sound/xen/xen_snd_front_alsa.c
@@ -441,7 +441,7 @@  static int shbuf_setup_backstore(struct xen_snd_front_pcm_stream_info *stream,
 {
 	int i;
 
-	stream->buffer = alloc_pages_exact(stream->buffer_sz, GFP_KERNEL);
+	stream->buffer = alloc_pages_exact(buffer_sz, GFP_KERNEL);
 	if (!stream->buffer)
 		return -ENOMEM;