| Message ID | 20190416040651.186468-1-maowenan@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8a46b39f3aff8e665c9893f9c4534a6b67ff4d6c |
| Headers | show |
| Series | xenbus: drop useless LIST_HEAD in xenbus_write_watch() and xenbus_file_write() | expand |
On 16/04/2019 06:06, Mao Wenan wrote: > Drop LIST_HEAD where the variable it declares is never used. > > The declarations were introduced with the file, but the declared > variables were not used. > > Fixes: 1107ba885e469("xen: add xenfs to allow usermode <-> Xen interaction") > Signed-off-by: Mao Wenan <maowenan@huawei.com> Reviewed-by: Juergen Gross <jgross@suse.com> Juergen
On 4/16/19 12:06 AM, Mao Wenan wrote: > Drop LIST_HEAD where the variable it declares is never used. > > The declarations were introduced with the file, but the declared > variables were not used. > > Fixes: 1107ba885e469("xen: add xenfs to allow usermode <-> Xen interaction") > Signed-off-by: Mao Wenan <maowenan@huawei.com> Applied to for-linus-5.2
diff --git a/drivers/xen/xenbus/xenbus_dev_frontend.c b/drivers/xen/xenbus/xenbus_dev_frontend.c index 0782ff3..faf452d 100644 --- a/drivers/xen/xenbus/xenbus_dev_frontend.c +++ b/drivers/xen/xenbus/xenbus_dev_frontend.c @@ -465,7 +465,6 @@ static int xenbus_write_watch(unsigned msg_type, struct xenbus_file_priv *u) struct watch_adapter *watch; char *path, *token; int err, rc; - LIST_HEAD(staging_q); path = u->u.buffer + sizeof(u->u.msg); token = memchr(path, 0, u->u.msg.len); @@ -523,7 +522,6 @@ static ssize_t xenbus_file_write(struct file *filp, uint32_t msg_type; int rc = len; int ret; - LIST_HEAD(staging_q); /* * We're expecting usermode to be writing properly formed
Drop LIST_HEAD where the variable it declares is never used. The declarations were introduced with the file, but the declared variables were not used. Fixes: 1107ba885e469("xen: add xenfs to allow usermode <-> Xen interaction") Signed-off-by: Mao Wenan <maowenan@huawei.com> --- drivers/xen/xenbus/xenbus_dev_frontend.c | 2 -- 1 file changed, 2 deletions(-)