From patchwork Fri Apr 26 16:39:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Jackson X-Patchwork-Id: 10919411 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7B29B14C0 for ; Fri, 26 Apr 2019 16:43:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6C55C28DEB for ; Fri, 26 Apr 2019 16:43:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 60EBA28E17; Fri, 26 Apr 2019 16:43:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 5EC1528DEB for ; Fri, 26 Apr 2019 16:43:15 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hK3um-00089R-BL; Fri, 26 Apr 2019 16:41:32 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hK3ul-00087i-55 for xen-devel@lists.xenproject.org; Fri, 26 Apr 2019 16:41:31 +0000 X-Inumbo-ID: 2451b3cb-6842-11e9-843c-bc764e045a96 Received: from SMTP03.CITRIX.COM (unknown [162.221.156.55]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTPS id 2451b3cb-6842-11e9-843c-bc764e045a96; Fri, 26 Apr 2019 16:41:29 +0000 (UTC) X-IronPort-AV: E=Sophos;i="5.60,398,1549929600"; d="scan'208";a="84519708" From: Ian Jackson To: Date: Fri, 26 Apr 2019 17:39:55 +0100 Message-ID: <20190426164002.22381-9-ian.jackson@eu.citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190426164002.22381-1-ian.jackson@eu.citrix.com> References: <20190426164002.22381-1-ian.jackson@eu.citrix.com> MIME-Version: 1.0 Subject: [Xen-devel] [OSSTEST PATCH 08/15] arch replumbing: make-flight: Fix $r{arch} comment X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Ian Jackson Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP This comment was lamenting the very problem we are fixing now. It would now be possible to test i386->amd64 tools migration, by writing an appropriate test job with different src_host_arch and dst_host_arch etc. Signed-off-by: Ian Jackson --- make-flight | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/make-flight b/make-flight index c5411412..020ad5f1 100755 --- a/make-flight +++ b/make-flight @@ -833,8 +833,8 @@ test_matrix_do_one () { all_hostflags="$hf" fi # TODO it would be nice to test i386->amd64 tools migration too (for - # Xen >= 4.6), but currently $r{arch} is used in several places, - # which would need looking at. + # Xen >= 4.6). Previously $r{arch} was used in several places, + # which made this more complicated, but this is now fixed. fi if [ x$test_pvh = xy -a $xenarch = amd64 -a $dom0arch = amd64 ]; then