From patchwork Mon May 6 06:56:03 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?SsO8cmdlbiBHcm/Dnw==?= X-Patchwork-Id: 10930533 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A4C1C912 for ; Mon, 6 May 2019 06:58:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 93EBD28397 for ; Mon, 6 May 2019 06:58:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8808628627; Mon, 6 May 2019 06:58:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id CD32528397 for ; Mon, 6 May 2019 06:58:44 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hNXYc-0001xi-Qc; Mon, 06 May 2019 06:57:02 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hNXYb-0001wp-NH for xen-devel@lists.xenproject.org; Mon, 06 May 2019 06:57:01 +0000 X-Inumbo-ID: 1f18b870-6fcc-11e9-9193-ab607bdbffc7 Received: from mx1.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1f18b870-6fcc-11e9-9193-ab607bdbffc7; Mon, 06 May 2019 06:56:50 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 6111BAD03; Mon, 6 May 2019 06:56:49 +0000 (UTC) From: Juergen Gross To: xen-devel@lists.xenproject.org Date: Mon, 6 May 2019 08:56:03 +0200 Message-Id: <20190506065644.7415-5-jgross@suse.com> X-Mailer: git-send-email 2.16.4 In-Reply-To: <20190506065644.7415-1-jgross@suse.com> References: <20190506065644.7415-1-jgross@suse.com> Subject: [Xen-devel] [PATCH RFC V2 04/45] xen/sched: move per-vcpu scheduler private data pointer to sched_item X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Tim Deegan , Stefano Stabellini , Wei Liu , Konrad Rzeszutek Wilk , George Dunlap , Andrew Cooper , Ian Jackson , Robert VanVossen , Dario Faggioli , Julien Grall , Josh Whitehead , Meng Xu , Jan Beulich MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP This prepares making the different schedulers vcpu agnostic. Signed-off-by: Juergen Gross --- xen/common/sched_arinc653.c | 4 ++-- xen/common/sched_credit.c | 6 +++--- xen/common/sched_credit2.c | 10 +++++----- xen/common/sched_null.c | 4 ++-- xen/common/sched_rt.c | 4 ++-- xen/common/schedule.c | 24 ++++++++++++------------ xen/include/xen/sched.h | 2 +- 7 files changed, 27 insertions(+), 27 deletions(-) diff --git a/xen/common/sched_arinc653.c b/xen/common/sched_arinc653.c index fffe23113e..f5af8b972d 100644 --- a/xen/common/sched_arinc653.c +++ b/xen/common/sched_arinc653.c @@ -53,7 +53,7 @@ * Return a pointer to the ARINC 653-specific scheduler data information * associated with the given VCPU (vc) */ -#define AVCPU(vc) ((arinc653_vcpu_t *)(vc)->sched_priv) +#define AVCPU(vc) ((arinc653_vcpu_t *)(vc)->sched_item->priv) /** * Return the global scheduler private data given the scheduler ops pointer @@ -647,7 +647,7 @@ a653_switch_sched(struct scheduler *new_ops, unsigned int cpu, ASSERT(!pdata && svc && is_idle_vcpu(svc->vc)); - idle_vcpu[cpu]->sched_priv = vdata; + idle_vcpu[cpu]->sched_item->priv = vdata; per_cpu(scheduler, cpu) = new_ops; per_cpu(schedule_data, cpu).sched_priv = NULL; /* no pdata */ diff --git a/xen/common/sched_credit.c b/xen/common/sched_credit.c index 3735486b4c..cb8e167fc9 100644 --- a/xen/common/sched_credit.c +++ b/xen/common/sched_credit.c @@ -83,7 +83,7 @@ ((struct csched_private *)((_ops)->sched_data)) #define CSCHED_PCPU(_c) \ ((struct csched_pcpu *)per_cpu(schedule_data, _c).sched_priv) -#define CSCHED_VCPU(_vcpu) ((struct csched_vcpu *) (_vcpu)->sched_priv) +#define CSCHED_VCPU(_vcpu) ((struct csched_vcpu *) (_vcpu)->sched_item->priv) #define CSCHED_DOM(_dom) ((struct csched_dom *) (_dom)->sched_priv) #define RUNQ(_cpu) (&(CSCHED_PCPU(_cpu)->runq)) @@ -641,7 +641,7 @@ csched_switch_sched(struct scheduler *new_ops, unsigned int cpu, ASSERT(svc && is_idle_vcpu(svc->vcpu)); - idle_vcpu[cpu]->sched_priv = vdata; + idle_vcpu[cpu]->sched_item->priv = vdata; /* * We are holding the runqueue lock already (it's been taken in @@ -1031,7 +1031,7 @@ static void csched_item_insert(const struct scheduler *ops, struct sched_item *item) { struct vcpu *vc = item->vcpu; - struct csched_vcpu *svc = vc->sched_priv; + struct csched_vcpu *svc = item->priv; spinlock_t *lock; BUG_ON( is_idle_vcpu(vc) ); diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c index f44286c2a5..9c052c24a7 100644 --- a/xen/common/sched_credit2.c +++ b/xen/common/sched_credit2.c @@ -572,7 +572,7 @@ static inline struct csched2_pcpu *csched2_pcpu(unsigned int cpu) static inline struct csched2_vcpu *csched2_vcpu(const struct vcpu *v) { - return v->sched_priv; + return v->sched_item->priv; } static inline struct csched2_dom *csched2_dom(const struct domain *d) @@ -970,7 +970,7 @@ _runq_assign(struct csched2_vcpu *svc, struct csched2_runqueue_data *rqd) static void runq_assign(const struct scheduler *ops, struct vcpu *vc) { - struct csched2_vcpu *svc = vc->sched_priv; + struct csched2_vcpu *svc = vc->sched_item->priv; ASSERT(svc->rqd == NULL); @@ -997,7 +997,7 @@ _runq_deassign(struct csched2_vcpu *svc) static void runq_deassign(const struct scheduler *ops, struct vcpu *vc) { - struct csched2_vcpu *svc = vc->sched_priv; + struct csched2_vcpu *svc = vc->sched_item->priv; ASSERT(svc->rqd == c2rqd(ops, vc->processor)); @@ -3108,7 +3108,7 @@ static void csched2_item_insert(const struct scheduler *ops, struct sched_item *item) { struct vcpu *vc = item->vcpu; - struct csched2_vcpu *svc = vc->sched_priv; + struct csched2_vcpu *svc = item->priv; struct csched2_dom * const sdom = svc->sdom; spinlock_t *lock; @@ -3888,7 +3888,7 @@ csched2_switch_sched(struct scheduler *new_ops, unsigned int cpu, ASSERT(!local_irq_is_enabled()); write_lock(&prv->lock); - idle_vcpu[cpu]->sched_priv = vdata; + idle_vcpu[cpu]->sched_item->priv = vdata; rqi = init_pdata(prv, pdata, cpu); diff --git a/xen/common/sched_null.c b/xen/common/sched_null.c index 7b508f35a4..eb51ddbccb 100644 --- a/xen/common/sched_null.c +++ b/xen/common/sched_null.c @@ -117,7 +117,7 @@ static inline struct null_private *null_priv(const struct scheduler *ops) static inline struct null_vcpu *null_vcpu(const struct vcpu *v) { - return v->sched_priv; + return v->sched_item->priv; } static inline bool vcpu_check_affinity(struct vcpu *v, unsigned int cpu, @@ -391,7 +391,7 @@ static void null_switch_sched(struct scheduler *new_ops, unsigned int cpu, ASSERT(nvc && is_idle_vcpu(nvc->vcpu)); - idle_vcpu[cpu]->sched_priv = vdata; + idle_vcpu[cpu]->sched_item->priv = vdata; /* * We are holding the runqueue lock already (it's been taken in diff --git a/xen/common/sched_rt.c b/xen/common/sched_rt.c index ab8fa02306..c830aac92f 100644 --- a/xen/common/sched_rt.c +++ b/xen/common/sched_rt.c @@ -235,7 +235,7 @@ static inline struct rt_private *rt_priv(const struct scheduler *ops) static inline struct rt_vcpu *rt_vcpu(const struct vcpu *vcpu) { - return vcpu->sched_priv; + return vcpu->sched_item->priv; } static inline struct list_head *rt_runq(const struct scheduler *ops) @@ -761,7 +761,7 @@ rt_switch_sched(struct scheduler *new_ops, unsigned int cpu, dprintk(XENLOG_DEBUG, "RTDS: timer initialized on cpu %u\n", cpu); } - idle_vcpu[cpu]->sched_priv = vdata; + idle_vcpu[cpu]->sched_item->priv = vdata; per_cpu(scheduler, cpu) = new_ops; per_cpu(schedule_data, cpu).sched_priv = NULL; /* no pdata */ diff --git a/xen/common/schedule.c b/xen/common/schedule.c index 071289b9c0..795d56a793 100644 --- a/xen/common/schedule.c +++ b/xen/common/schedule.c @@ -269,8 +269,8 @@ int sched_init_vcpu(struct vcpu *v, unsigned int processor) init_timer(&v->poll_timer, poll_timer_fn, v, v->processor); - v->sched_priv = sched_alloc_vdata(dom_scheduler(d), item, d->sched_priv); - if ( v->sched_priv == NULL ) + item->priv = sched_alloc_vdata(dom_scheduler(d), item, d->sched_priv); + if ( item->priv == NULL ) { v->sched_item = NULL; xfree(item); @@ -365,7 +365,7 @@ int sched_move_domain(struct domain *d, struct cpupool *c) { spinlock_t *lock; - vcpudata = v->sched_priv; + vcpudata = v->sched_item->priv; migrate_timer(&v->periodic_timer, new_p); migrate_timer(&v->singleshot_timer, new_p); @@ -383,7 +383,7 @@ int sched_move_domain(struct domain *d, struct cpupool *c) */ spin_unlock_irq(lock); - v->sched_priv = vcpu_priv[v->vcpu_id]; + v->sched_item->priv = vcpu_priv[v->vcpu_id]; if ( !d->is_dying ) sched_move_irqs(v); @@ -415,7 +415,7 @@ void sched_destroy_vcpu(struct vcpu *v) if ( test_and_clear_bool(v->is_urgent) ) atomic_dec(&per_cpu(schedule_data, v->processor).urgent_count); sched_remove_item(vcpu_scheduler(v), item); - sched_free_vdata(vcpu_scheduler(v), v->sched_priv); + sched_free_vdata(vcpu_scheduler(v), item->priv); xfree(item); v->sched_item = NULL; } @@ -1593,6 +1593,7 @@ static int cpu_schedule_up(unsigned int cpu) else { struct vcpu *idle = idle_vcpu[cpu]; + struct sched_item *item = idle->sched_item; /* * During (ACPI?) suspend the idle vCPU for this pCPU is not freed, @@ -1604,11 +1605,10 @@ static int cpu_schedule_up(unsigned int cpu) * with a different scheduler, it is schedule_cpu_switch(), invoked * later, that will set things up as appropriate. */ - ASSERT(idle->sched_priv == NULL); + ASSERT(item->priv == NULL); - idle->sched_priv = sched_alloc_vdata(&ops, idle->sched_item, - idle->domain->sched_priv); - if ( idle->sched_priv == NULL ) + item->priv = sched_alloc_vdata(&ops, item, idle->domain->sched_priv); + if ( item->priv == NULL ) return -ENOMEM; } if ( idle_vcpu[cpu] == NULL ) @@ -1634,9 +1634,9 @@ static void cpu_schedule_down(unsigned int cpu) struct scheduler *sched = per_cpu(scheduler, cpu); sched_free_pdata(sched, sd->sched_priv, cpu); - sched_free_vdata(sched, idle_vcpu[cpu]->sched_priv); + sched_free_vdata(sched, idle_vcpu[cpu]->sched_item->priv); - idle_vcpu[cpu]->sched_priv = NULL; + idle_vcpu[cpu]->sched_item->priv = NULL; sd->sched_priv = NULL; kill_timer(&sd->s_timer); @@ -1861,7 +1861,7 @@ int schedule_cpu_switch(unsigned int cpu, struct cpupool *c) */ old_lock = pcpu_schedule_lock_irq(cpu); - vpriv_old = idle->sched_priv; + vpriv_old = idle->sched_item->priv; ppriv_old = per_cpu(schedule_data, cpu).sched_priv; sched_switch_sched(new_ops, cpu, ppriv, vpriv); diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index 85f9119d48..45857b4d35 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -162,7 +162,6 @@ struct vcpu struct timer poll_timer; /* timeout for SCHEDOP_poll */ struct sched_item *sched_item; - void *sched_priv; /* scheduler-specific data */ struct vcpu_runstate_info runstate; #ifndef CONFIG_COMPAT @@ -279,6 +278,7 @@ struct vcpu struct sched_item { struct vcpu *vcpu; + void *priv; /* scheduler private data */ }; /* Per-domain lock can be recursively acquired in fault handlers. */