| Message ID | 20190507133625.11502-1-wei.liu2@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | libxl: don't enable synthetic timer by default | expand |
> -----Original Message----- > From: Wei Liu [mailto:wei.liu2@citrix.com] > Sent: 07 May 2019 14:36 > To: xen-devel@lists.xenproject.org > Cc: Wei Liu <wei.liu2@citrix.com>; Ian Jackson <Ian.Jackson@citrix.com>; Paul Durrant > <Paul.Durrant@citrix.com>; Juergen Gross <jgross@suse.com> > Subject: [PATCH] libxl: don't enable synthetic timer by default > > It broke Windows installation. More investigation is needed. Don't > enable it by default. > > Signed-off-by: Wei Liu <wei.liu2@citrix.com> Reviewed-by: Paul Durrant <paul.durrant@citrix.com> > --- > Cc: Ian Jackson <ian.jackson@eu.citrix.com> > Cc: Paul Durrant <paul.durrant@citrix.com> > Cc: Juergen Gross <jgross@suse.com> > --- > tools/libxl/libxl_dom.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c > index 879c806139..c5685b061c 100644 > --- a/tools/libxl/libxl_dom.c > +++ b/tools/libxl/libxl_dom.c > @@ -269,7 +269,6 @@ static int hvm_set_viridian_features(libxl__gc *gc, uint32_t domid, > libxl_bitmap_set(&enlightenments, LIBXL_VIRIDIAN_ENLIGHTENMENT_TIME_REF_COUNT); > libxl_bitmap_set(&enlightenments, LIBXL_VIRIDIAN_ENLIGHTENMENT_APIC_ASSIST); > libxl_bitmap_set(&enlightenments, LIBXL_VIRIDIAN_ENLIGHTENMENT_CRASH_CTL); > - libxl_bitmap_set(&enlightenments, LIBXL_VIRIDIAN_ENLIGHTENMENT_STIMER); > } > > libxl_for_each_set_bit(v, info->u.hvm.viridian_enable) { > -- > 2.20.1
On 07/05/2019 15:36, Wei Liu wrote: > It broke Windows installation. More investigation is needed. Don't > enable it by default. > > Signed-off-by: Wei Liu <wei.liu2@citrix.com> Thanks! Juergen
diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c index 879c806139..c5685b061c 100644 --- a/tools/libxl/libxl_dom.c +++ b/tools/libxl/libxl_dom.c @@ -269,7 +269,6 @@ static int hvm_set_viridian_features(libxl__gc *gc, uint32_t domid, libxl_bitmap_set(&enlightenments, LIBXL_VIRIDIAN_ENLIGHTENMENT_TIME_REF_COUNT); libxl_bitmap_set(&enlightenments, LIBXL_VIRIDIAN_ENLIGHTENMENT_APIC_ASSIST); libxl_bitmap_set(&enlightenments, LIBXL_VIRIDIAN_ENLIGHTENMENT_CRASH_CTL); - libxl_bitmap_set(&enlightenments, LIBXL_VIRIDIAN_ENLIGHTENMENT_STIMER); } libxl_for_each_set_bit(v, info->u.hvm.viridian_enable) {
It broke Windows installation. More investigation is needed. Don't enable it by default. Signed-off-by: Wei Liu <wei.liu2@citrix.com> --- Cc: Ian Jackson <ian.jackson@eu.citrix.com> Cc: Paul Durrant <paul.durrant@citrix.com> Cc: Juergen Gross <jgross@suse.com> --- tools/libxl/libxl_dom.c | 1 - 1 file changed, 1 deletion(-)