| Message ID | 20190513134714.3124-5-wei.liu2@citrix.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Misc patches | expand |
>>> On 13.05.19 at 15:47, <wei.liu2@citrix.com> wrote: > --- a/INSTALL > +++ b/INSTALL > @@ -225,7 +225,6 @@ XEN_BUILD_TIME=hh:mm:ss > SMBIOS_REL_DATE=mm/dd/yyyy > VGABIOS_REL_DATE="dd Mon yyyy" > > -During tools build external repos will be cloned into the source tree. > This variable can be used to point to a different git binary to be used. > GIT= To me it would seem more logical to delete the other, later instance of the sentence. You wouldn't need $(GIT) if there was no cloning. Jan
On Mon, May 13, 2019 at 08:29:14AM -0600, Jan Beulich wrote: > >>> On 13.05.19 at 15:47, <wei.liu2@citrix.com> wrote: > > --- a/INSTALL > > +++ b/INSTALL > > @@ -225,7 +225,6 @@ XEN_BUILD_TIME=hh:mm:ss > > SMBIOS_REL_DATE=mm/dd/yyyy > > VGABIOS_REL_DATE="dd Mon yyyy" > > > > -During tools build external repos will be cloned into the source tree. > > This variable can be used to point to a different git binary to be used. > > GIT= > > To me it would seem more logical to delete the other, later > instance of the sentence. You wouldn't need $(GIT) if there > was no cloning. But deleting that one would be wrong -- it would make that paragraph seems to be only about stubdom, while in fact most of those envars are about tools build. Wei. > > Jan > >
diff --git a/INSTALL b/INSTALL index 9aa9ebdddc..1665ddd6a4 100644 --- a/INSTALL +++ b/INSTALL @@ -225,7 +225,6 @@ XEN_BUILD_TIME=hh:mm:ss SMBIOS_REL_DATE=mm/dd/yyyy VGABIOS_REL_DATE="dd Mon yyyy" -During tools build external repos will be cloned into the source tree. This variable can be used to point to a different git binary to be used. GIT=
The same sentence is repeated in the next paragraph. Signed-off-by: Wei Liu <wei.liu2@citrix.com> --- INSTALL | 1 - 1 file changed, 1 deletion(-)