diff mbox series

[v2,28/35] xen/arm32: head: Document enable_mmu()

Message ID	20190722213958.5761-29-julien.grall@arm.com (mailing list archive)
State	Superseded
Headers	show Return-Path: <xen-devel-bounces@lists.xenproject.org> From: Julien Grall <julien.grall@arm.com> To: xen-devel@lists.xenproject.org Date: Mon, 22 Jul 2019 22:39:51 +0100 Message-Id: <20190722213958.5761-29-julien.grall@arm.com> In-Reply-To: <20190722213958.5761-1-julien.grall@arm.com> References: <20190722213958.5761-1-julien.grall@arm.com> Subject: [Xen-devel] [PATCH v2 28/35] xen/arm32: head: Document enable_mmu() Precedence: list Cc: Julien Grall <julien.grall@arm.com>, Stefano Stabellini <sstabellini@kernel.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
Series	xen/arm: Rework head.S to make it more compliant with the Arm Arm \| expand [v2,00/35] xen/arm: Rework head.S to make it more compliant with the Arm Arm [v2,01/35] xen/arm64: macros: Introduce an assembly macro to alias x30 [v2,02/35] xen/arm64: head: Mark the end of subroutines with ENDPROC [v2,03/35] xen/arm64: head: Don't clobber x30/lr in the macro PRINT [v2,04/35] xen/arm64: head: Rework UART initialization on boot CPU [v2,05/35] xen/arm64: head: Introduce print_reg [v2,06/35] xen/arm64: head: Introduce distinct paths for the boot CPU and secondary CPUs [v2,07/35] xen/arm64: head: Rework and document check_cpu_mode() [v2,08/35] xen/arm64: head: Rework and document zero_bss() [v2,09/35] xen/arm64: head: Improve coding style and document cpu_init() [v2,10/35] xen/arm64: head: Improve coding style and document create_pages_tables() [v2,11/35] xen/arm64: head: Document enable_mmu() [v2,12/35] xen/arm64: head: Move assembly switch to the runtime PT in secondary CPUs path [v2,13/35] xen/arm64: head: Don't setup the fixmap on secondary CPUs [v2,14/35] xen/arm64: head: Remove 1:1 mapping as soon as it is not used [v2,15/35] xen/arm64: head: Rework and document setup_fixmap() [v2,16/35] xen/arm64: head: Rework and document launch() [v2,17/35] xen/arm64: head: Setup TTBR_EL2 in enable_mmu() and add missing isb [v2,18/35] xen/arm64: head: Introduce a macro to get a PC-relative address of a symbol [v2,19/35] xen/arm32: head: Add a macro to move an immediate constant into a 32-bit register [v2,20/35] xen/arm32: head: Mark the end of subroutines with ENDPROC [v2,21/35] xen/arm32: head: Don't clobber r14/lr in the macro PRINT [v2,22/35] xen/arm32: head: Rework UART initialization on boot CPU [v2,23/35] xen/arm32: head: Introduce print_reg [v2,24/35] xen/arm32: head: Introduce distinct paths for the boot CPU and secondary CPUs [v2,25/35] xen/arm32: head: Rework and document check_cpu_mode() [v2,26/35] xen/arm32: head: Rework and document zero_bss() [v2,27/35] xen/arm32: head: Document create_pages_tables() [v2,28/35] xen/arm32: head: Document enable_mmu() [v2,29/35] xen/arm32: head: Move assembly switch to the runtime PT in secondary CPUs path [v2,30/35] xen/arm32: head: Don't setup the fixmap on secondary CPUs [v2,31/35] xen/arm32: head: Remove 1:1 mapping as soon as it is not used [v2,32/35] xen/arm32: head: Rework and document setup_fixmap() [v2,33/35] xen/arm32: head: Rework and document launch() [v2,34/35] xen/arm32: head: Setup HTTBR in enable_mmu() and add missing isb [v2,35/35] xen/arm: Zero BSS after the MMU and D-cache is turned on

Commit Message

Julien Grall July 22, 2019, 9:39 p.m. UTC

Document the behavior and the main registers usage within enable_mmu().

Signed-off-by: Julien Grall <julien.grall@arm.com>

---
    Changes in v2:
        - Patch added
---
 xen/arch/arm/arm32/head.S | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Stefano Stabellini July 30, 2019, 8:19 p.m. UTC | #1

On Mon, 22 Jul 2019, Julien Grall wrote:
> Document the behavior and the main registers usage within enable_mmu().
> 
> Signed-off-by: Julien Grall <julien.grall@arm.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
>     Changes in v2:
>         - Patch added
> ---
>  xen/arch/arm/arm32/head.S | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S
> index ef8979959b..4081a52dfa 100644
> --- a/xen/arch/arm/arm32/head.S
> +++ b/xen/arch/arm/arm32/head.S
> @@ -422,6 +422,13 @@ virtphys_clash:
>          b     fail
>  ENDPROC(create_page_tables)
>  
> +/*
> + * Turn on the Data Cache and the MMU. The function will return on the 1:1
> + * mapping. In other word, the caller is responsible to switch to the runtime
> + * mapping.
> + *
> + * Clobbers r0 - r3
> + */
>  enable_mmu:
>          PRINT("- Turning on paging -\r\n")
>  
> -- 
> 2.11.0
>

diff mbox series

Patch

diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S
index ef8979959b..4081a52dfa 100644
--- a/xen/arch/arm/arm32/head.S
+++ b/xen/arch/arm/arm32/head.S
@@ -422,6 +422,13 @@  virtphys_clash:
         b     fail
 ENDPROC(create_page_tables)
 
+/*
+ * Turn on the Data Cache and the MMU. The function will return on the 1:1
+ * mapping. In other word, the caller is responsible to switch to the runtime
+ * mapping.
+ *
+ * Clobbers r0 - r3
+ */
 enable_mmu:
         PRINT("- Turning on paging -\r\n")